[Intel-gfx] [PATCH] drm/i915/gt: add missing new-line to GT_TRACE

[Intel-gfx] [PATCH] drm/i915/gt: add missing new-line to GT_TRACE

[Andrzej Hajda]

Trace requires new-line at the end of message (in opposition to printk),
otherwise trace dump becomes messy.

Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_gt_pm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm.c b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
index f5899d503e234b..471b7cdc10ba0f 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_pm.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
@@ -167,7 +167,7 @@ static void gt_sanitize(struct intel_gt *gt, bool force)
 	enum intel_engine_id id;
 	intel_wakeref_t wakeref;
 
-	GT_TRACE(gt, "force:%s", str_yes_no(force));
+	GT_TRACE(gt, "force:%s\n", str_yes_no(force));
 
 	/* Use a raw wakeref to avoid calling intel_display_power_get early */
 	wakeref = intel_runtime_pm_get(gt->uncore->rpm);

---
base-commit: 1489bab52c281a869295414031a56506a375b036
change-id: 20231115-eols-20f9f52cf338

Best regards,
-- 
Andrzej Hajda <andrzej.hajda@intel.com>

Re: [Intel-gfx] [PATCH] drm/i915/gt: add missing new-line to GT_TRACE

[Janusz Krzysztofik]

On Wednesday, 15 November 2023 13:10:33 CET Andrzej Hajda wrote:
> Trace requires new-line at the end of message (in opposition to printk),
> otherwise trace dump becomes messy.
> 
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>

Acked-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/gt/intel_gt_pm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm.c b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
> index f5899d503e234b..471b7cdc10ba0f 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_pm.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
> @@ -167,7 +167,7 @@ static void gt_sanitize(struct intel_gt *gt, bool force)
>  	enum intel_engine_id id;
>  	intel_wakeref_t wakeref;
>  
> -	GT_TRACE(gt, "force:%s", str_yes_no(force));
> +	GT_TRACE(gt, "force:%s\n", str_yes_no(force));
>  
>  	/* Use a raw wakeref to avoid calling intel_display_power_get early */
>  	wakeref = intel_runtime_pm_get(gt->uncore->rpm);
> 
> ---
> base-commit: 1489bab52c281a869295414031a56506a375b036
> change-id: 20231115-eols-20f9f52cf338
> 
> Best regards,
> 

Re: [Intel-gfx] [PATCH] drm/i915/gt: add missing new-line to GT_TRACE

[Nirmoy Das]

On 11/15/2023 1:10 PM, Andrzej Hajda wrote:
> Trace requires new-line at the end of message (in opposition to printk),
> otherwise trace dump becomes messy.
>
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>

Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>

> ---
>   drivers/gpu/drm/i915/gt/intel_gt_pm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm.c b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
> index f5899d503e234b..471b7cdc10ba0f 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_pm.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
> @@ -167,7 +167,7 @@ static void gt_sanitize(struct intel_gt *gt, bool force)
>   	enum intel_engine_id id;
>   	intel_wakeref_t wakeref;
>   
> -	GT_TRACE(gt, "force:%s", str_yes_no(force));
> +	GT_TRACE(gt, "force:%s\n", str_yes_no(force));
>   
>   	/* Use a raw wakeref to avoid calling intel_display_power_get early */
>   	wakeref = intel_runtime_pm_get(gt->uncore->rpm);
>
> ---
> base-commit: 1489bab52c281a869295414031a56506a375b036
> change-id: 20231115-eols-20f9f52cf338
>
> Best regards,

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: add missing new-line to GT_TRACE

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 3838 bytes --]

== Series Details ==

Series: drm/i915/gt: add missing new-line to GT_TRACE
URL   : https://patchwork.freedesktop.org/series/126460/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_13881 -> Patchwork_126460v1
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_126460v1 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_126460v1, please notify your bug team (lgci.bug.filing@intel.com) to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126460v1/index.html

Participating hosts (40 -> 36)
------------------------------

  Missing    (4): bat-rpls-1 bat-dg2-9 fi-snb-2520m fi-hsw-4770 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_126460v1:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live@workarounds:
    - bat-dg2-11:         [PASS][1] -> [DMESG-FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13881/bat-dg2-11/igt@i915_selftest@live@workarounds.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126460v1/bat-dg2-11/igt@i915_selftest@live@workarounds.html

  
Known issues
------------

  Here are the changes found in Patchwork_126460v1 that come from known issues:

### CI changes ###

#### Issues hit ####

  * boot:
    - bat-adlp-11:        [PASS][3] -> [FAIL][4] ([i915#8293])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13881/bat-adlp-11/boot.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126460v1/bat-adlp-11/boot.html

  
#### Possible fixes ####

  * boot:
    - fi-bsw-n3050:       [FAIL][5] ([i915#8293]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13881/fi-bsw-n3050/boot.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126460v1/fi-bsw-n3050/boot.html

  

### IGT changes ###

#### Issues hit ####

  * igt@gem_lmem_swapping@random-engines:
    - fi-bsw-n3050:       NOTRUN -> [SKIP][7] ([fdo#109271]) +14 other tests skip
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126460v1/fi-bsw-n3050/igt@gem_lmem_swapping@random-engines.html

  * igt@kms_hdmi_inject@inject-audio:
    - fi-kbl-guc:         [PASS][8] -> [FAIL][9] ([IGT#3])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13881/fi-kbl-guc/igt@kms_hdmi_inject@inject-audio.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126460v1/fi-kbl-guc/igt@kms_hdmi_inject@inject-audio.html
    - fi-bsw-n3050:       NOTRUN -> [FAIL][10] ([IGT#3])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126460v1/fi-bsw-n3050/igt@kms_hdmi_inject@inject-audio.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [IGT#3]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/3
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [i915#8293]: https://gitlab.freedesktop.org/drm/intel/issues/8293


Build changes
-------------

  * Linux: CI_DRM_13881 -> Patchwork_126460v1

  CI-20190529: 20190529
  CI_DRM_13881: 36732395a74634a9ff9db10c79c4c52719cdab40 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_7590: c484e1422184a3183d11f1595e53a6715574520f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_126460v1: 36732395a74634a9ff9db10c79c4c52719cdab40 @ git://anongit.freedesktop.org/gfx-ci/linux


### Linux commits

a0c2c0418ac0 drm/i915/gt: add missing new-line to GT_TRACE

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126460v1/index.html

[-- Attachment #2: Type: text/html, Size: 4736 bytes --]

Re: [Intel-gfx] [PATCH] drm/i915/gt: add missing new-line to GT_TRACE

[Andi Shyti]

Hi Andrzej,

On Wed, Nov 15, 2023 at 01:10:33PM +0100, Andrzej Hajda wrote:
> Trace requires new-line at the end of message (in opposition to printk),
> otherwise trace dump becomes messy.
> 
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

Thanks,
Andi

Re: [Intel-gfx] [PATCH] drm/i915/gt: add missing new-line to GT_TRACE

[Andrzej Hajda]

On 16.11.2023 12:45, Andi Shyti wrote:
> Hi Andrzej,
>
> On Wed, Nov 15, 2023 at 01:10:33PM +0100, Andrzej Hajda wrote:
>> Trace requires new-line at the end of message (in opposition to printk),
>> otherwise trace dump becomes messy.
>>
>> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

Thx all, pushed.

Regards
Andrzej

> Thanks,
> Andi