From: Andi Shyti <andi.shyti@linux.intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Andi Shyti <andi.shyti@linux.intel.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Nirmoy Das <nirmoy.das@intel.com>,
Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>,
Andi Shyti <andi.shyti@kernel.org>
Subject: Re: [PATCH v2] drm/i915: Increase FLR timeout from 3s to 9s
Date: Mon, 27 May 2024 11:47:49 +0100 [thread overview]
Message-ID: <ZlRk1Qdr8i2YPITh@ashyti-mobl2.lan> (raw)
In-Reply-To: <ZlCfMPZpvQJmHybR@intel.com>
On Fri, May 24, 2024 at 10:07:44AM -0400, Rodrigo Vivi wrote:
> On Fri, May 24, 2024 at 01:58:53AM +0200, Andi Shyti wrote:
> > Following the guidelines it takes 3 seconds to perform an FLR
> > reset. Let's give it a bit more slack because this time can
> > change depending on the platform and on the firmware
>
> But did we see any issue with that?
yes, we have some FLR expiration timeouts that apparently are not
able to bring up the device and the memory is not accessible
anymore. It's worth giving it a bit more time.
> if that changes per platform and per firmware, shouldn't it all
> be explicit in the spec as well?
Is it always documented? We might anyway die after the FLR reset
failure, so that I see it quite safe to wait and pray a little
more.
Andi
next prev parent reply other threads:[~2024-05-27 10:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 23:58 [PATCH v2] drm/i915: Increase FLR timeout from 3s to 9s Andi Shyti
2024-05-24 0:40 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-05-24 14:07 ` [PATCH v2] " Rodrigo Vivi
2024-05-27 10:47 ` Andi Shyti [this message]
2024-05-27 15:00 ` Andi Shyti
2024-05-28 16:36 ` Rodrigo Vivi
2024-05-25 8:25 ` ✗ Fi.CI.IGT: failure for " Patchwork
2024-05-29 8:42 ` [PATCH v2] " Nirmoy Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZlRk1Qdr8i2YPITh@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=janusz.krzysztofik@linux.intel.com \
--cc=nirmoy.das@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox