Re: [PATCH v3 6/8] drm/i915/dp: Write the source OUI for eDP before detecting sink capabilities

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Wed, Oct 16, 2024 at 04:24:03PM +0300, Imre Deak wrote:
> The eDP sink's capabilities, like DSC, may depend on the source OUI
> written to the sink, so ensure the OUI is written before reading out the
> capabilities.
> 
> Signed-off-by: Imre Deak <imre.deak@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_dp.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index e2c37680caa91..520cc6f50a126 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -4200,6 +4200,12 @@ intel_edp_init_dpcd(struct intel_dp *intel_dp, struct intel_connector *connector
>  		intel_dp->use_max_params = intel_dp->edp_dpcd[0] < DP_EDP_14;
>  	}
>  
> +	/*
> +	 * If needed, program our source OUI so we can make various Intel-specific AUX services
> +	 * available (such as HDR backlight controls)
> +	 */
> +	intel_dp_init_source_oui(intel_dp);
> +
>  	/*
>  	 * This has to be called after intel_dp->edp_dpcd is filled, PSR checks
>  	 * for SET_POWER_CAPABLE bit in intel_dp->edp_dpcd[1]
> @@ -4212,12 +4218,6 @@ intel_edp_init_dpcd(struct intel_dp *intel_dp, struct intel_connector *connector
>  	/* Read the eDP DSC DPCD registers */
>  	intel_dp_detect_dsc_caps(intel_dp, connector);
>  
> -	/*
> -	 * If needed, program our source OUI so we can make various Intel-specific AUX services
> -	 * available (such as HDR backlight controls)
> -	 */
> -	intel_dp_init_source_oui(intel_dp);
> -
>  	return true;
>  }
>  
> -- 
> 2.44.2

-- 
Ville Syrjälä
Intel