Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3 7/8] drm/i915/dp: Write the source OUI during connector detection
Date: Wed, 23 Oct 2024 15:46:37 +0300	[thread overview]
Message-ID: <ZxjwLa14Ycs13ctD@intel.com> (raw)
In-Reply-To: <20241016132405.2231744-8-imre.deak@intel.com>

On Wed, Oct 16, 2024 at 04:24:04PM +0300, Imre Deak wrote:
> The DP sink's capabilities, like DSC, may depend on the source OUI
> written to the sink. On eDP this OUI value could have been reset before
> the detection started if the panel power on it got disabled. Make sure
> the OUI is re-written at the beginning of detection in this case, before
> the sink capabilities are read out.
> 
> Signed-off-by: Imre Deak <imre.deak@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_dp.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 520cc6f50a126..063fe92d43786 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -5669,6 +5669,8 @@ intel_dp_detect(struct drm_connector *connector,
>  		goto out_unset_edid;
>  	}
>  
> +	intel_dp_init_source_oui(intel_dp);
> +
>  	ret = intel_dp_tunnel_detect(intel_dp, ctx);
>  	if (ret == -EDEADLK) {
>  		status = ret;
> -- 
> 2.44.2

-- 
Ville Syrjälä
Intel

  reply	other threads:[~2024-10-23 12:46 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-16 13:23 [PATCH v3 0/8] drm/i915: Write source OUI for non-eDP sinks Imre Deak
2024-10-16 13:23 ` [PATCH v3 1/8] drm/i915/dp: Flush modeset commits during connector detection Imre Deak
2024-10-23 12:15   ` Ville Syrjälä
2024-10-23 14:19     ` Imre Deak
2024-10-16 13:23 ` [PATCH v3 2/8] drm/i915/dp: Ensure panel power remains enabled " Imre Deak
2024-10-23 12:43   ` Ville Syrjälä
2024-10-23 15:19   ` Jani Nikula
2024-10-23 15:48     ` Imre Deak
2024-10-16 13:24 ` [PATCH v3 3/8] drm/i915/dp: Initialize the source OUI write timestamp always Imre Deak
2024-10-23 12:15   ` Ville Syrjälä
2024-10-16 13:24 ` [PATCH v3 4/8] drm/i915/dp: Track source OUI validity explicitly Imre Deak
2024-10-22  9:46   ` [PATCH v4 " Imre Deak
2024-10-23 12:16     ` Ville Syrjälä
2024-10-23 14:40       ` Imre Deak
2024-10-25  7:18         ` Ville Syrjälä
2024-10-16 13:24 ` [PATCH v3 5/8] drm/i915/dp: Reuse intel_dp_detect_dsc_caps() for eDP Imre Deak
2024-10-23 12:15   ` Ville Syrjälä
2024-10-16 13:24 ` [PATCH v3 6/8] drm/i915/dp: Write the source OUI for eDP before detecting sink capabilities Imre Deak
2024-10-23 12:15   ` Ville Syrjälä
2024-10-16 13:24 ` [PATCH v3 7/8] drm/i915/dp: Write the source OUI during connector detection Imre Deak
2024-10-23 12:46   ` Ville Syrjälä [this message]
2024-10-16 13:24 ` [PATCH v3 8/8] drm/i915/dp: Write the source OUI for non-eDP sinks as well Imre Deak
2024-10-22  9:46   ` [PATCH v4 " Imre Deak
2024-10-16 19:12 ` ✗ Fi.CI.SPARSE: warning for drm/i915: Write source OUI for non-eDP sinks Patchwork
2024-10-16 19:12 ` ✓ Fi.CI.BAT: success " Patchwork
2024-10-16 20:48 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-10-22 12:21 ` ✗ Fi.CI.SPARSE: warning for drm/i915: Write source OUI for non-eDP sinks (rev3) Patchwork
2024-10-22 12:27 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-10-22 13:04   ` Imre Deak
2024-10-22 13:25     ` Imre Deak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZxjwLa14Ycs13ctD@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox