Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] drm/atomic: WARN about missing acquire_ctx in drm_atomic_get_private_obj_state()
@ 2025-10-17 16:33 Ville Syrjala
  2025-10-17 16:33 ` [PATCH 2/2] drm/atomic: WARN about invalid drm_foo_get_state() usage Ville Syrjala
                   ` (5 more replies)
  0 siblings, 6 replies; 9+ messages in thread
From: Ville Syrjala @ 2025-10-17 16:33 UTC (permalink / raw)
  To: dri-devel; +Cc: intel-gfx, intel-xe, Maxime Ripard, Dan Carpenter

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

The crtc/plane/connector counterparts of
drm_atomic_get_private_obj_state() all WARN about a missing
acquire_ctx. Do the same in drm_atomic_get_private_obj_state()
for consistency.

Cc: Maxime Ripard <mripard@kernel.org>
Cc: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/drm_atomic.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
index be2cb6e43cb0..5d31b20e67ab 100644
--- a/drivers/gpu/drm/drm_atomic.c
+++ b/drivers/gpu/drm/drm_atomic.c
@@ -836,6 +836,8 @@ drm_atomic_get_private_obj_state(struct drm_atomic_state *state,
 	struct __drm_private_objs_state *arr;
 	struct drm_private_state *obj_state;
 
+	WARN_ON(!state->acquire_ctx);
+
 	obj_state = drm_atomic_get_new_private_obj_state(state, obj);
 	if (obj_state)
 		return obj_state;
-- 
2.49.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2025-10-28 20:52 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-17 16:33 [PATCH 1/2] drm/atomic: WARN about missing acquire_ctx in drm_atomic_get_private_obj_state() Ville Syrjala
2025-10-17 16:33 ` [PATCH 2/2] drm/atomic: WARN about invalid drm_foo_get_state() usage Ville Syrjala
2025-10-20  7:29   ` Maxime Ripard
2025-10-28 20:52     ` Ville Syrjälä
2025-10-17 17:36 ` ✗ i915.CI.BAT: failure for series starting with [1/2] drm/atomic: WARN about missing acquire_ctx in drm_atomic_get_private_obj_state() Patchwork
2025-10-20  7:29 ` [PATCH 1/2] " Maxime Ripard
2025-10-21 14:05 ` ✗ i915.CI.BAT: failure for series starting with [1/2] drm/atomic: WARN about missing acquire_ctx in drm_atomic_get_private_obj_state() (rev2) Patchwork
2025-10-23 18:07 ` ✓ i915.CI.BAT: success for series starting with [1/2] drm/atomic: WARN about missing acquire_ctx in drm_atomic_get_private_obj_state() (rev3) Patchwork
2025-10-24  7:12 ` ✗ i915.CI.Full: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox