From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 7/7] drm/i915: enable ppgtt
Date: Thu, 09 Feb 2012 16:39:06 +0000 [thread overview]
Message-ID: <aefc95$34qdib@orsmga001.jf.intel.com> (raw)
In-Reply-To: <1328804150-19522-8-git-send-email-daniel.vetter@ffwll.ch>
On Thu, 9 Feb 2012 17:15:50 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> v3: Pimp commit message and make Chris Wilson less grumpy by adding a
> module option.
> +void i915_gem_init_ppgtt(struct drm_device *dev)
> +{
> + drm_i915_private_t *dev_priv = dev->dev_private;
> + uint32_t pd_offset;
> + struct intel_ring_buffer *ring;
> + int i;
> +
> + if (i915_enable_ppgtt && !HAS_ALIASING_PPGTT(dev))
> + return;
> +
This is quite a late check since we have already partitioned the
aperture and run i915_gem_init_aliasing_ppgtt. I think the enable check
should be done earlier and this check reduced to
if (!dev_priv->mm.aliasing_ppgtt)
return;
Bah humbug!
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-02-09 16:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 16:15 [PATCH 0/7] updated ppgtt patches Daniel Vetter
2012-02-09 16:15 ` [PATCH 1/7] agp/intel-gtt: export the scratch page dma address Daniel Vetter
2012-02-09 16:15 ` [PATCH 2/7] agp/intel-gtt: export the gtt pagetable iomapping Daniel Vetter
2012-02-09 16:15 ` [PATCH 3/7] drm/i915: initialization/teardown for the aliasing ppgtt Daniel Vetter
2012-02-09 16:15 ` [PATCH 4/7] drm/i915: ppgtt binding/unbinding support Daniel Vetter
2012-02-09 16:15 ` [PATCH 5/7] drm/i915: ppgtt register definitions Daniel Vetter
2012-02-09 16:15 ` [PATCH 6/7] drm/i915: ppgtt debugfs info Daniel Vetter
2012-02-09 16:15 ` [PATCH 7/7] drm/i915: enable ppgtt Daniel Vetter
2012-02-09 16:39 ` Chris Wilson [this message]
2012-02-09 18:17 ` Eugeni Dodonov
2012-02-09 19:53 ` [PATCH] " Daniel Vetter
2012-02-10 7:27 ` Television turns greenish after stand-by Angela Schmid
[not found] ` <4f34c700.6748440a.0159.07dbSMTPIN_ADDED@mx.google.com>
2012-02-10 9:17 ` John Obaterspok
[not found] ` <4f34c6ef.8401440a.462d.0295SMTPIN_ADDED@mx.google.com>
2012-02-10 15:45 ` Daniel Vetter
2012-02-13 7:33 ` Angela Schmid
[not found] ` <4f38bcc6.10bc0e0a.7970.ffffa668SMTPIN_ADDED@mx.google.com>
2012-02-13 8:32 ` Daniel Vetter
2012-02-14 7:09 ` Angela Schmid
[not found] ` <4f3a08bb.cd640e0a.25f2.408dSMTPIN_ADDED@mx.google.com>
2012-02-14 9:54 ` Daniel Vetter
2012-02-09 16:40 ` [PATCH 0/7] updated ppgtt patches Chris Wilson
2012-02-09 18:21 ` Eugeni Dodonov
2012-02-09 21:06 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='aefc95$34qdib@orsmga001.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox