From: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [RFC v3 7/9] drm/i915: Skip rotated offset adjustment for unsupported modifiers
Date: Thu, 03 Oct 2019 14:18:29 -0700 [thread overview]
Message-ID: <af67dd9c0cf31c312748a29656ec5b7153ca59ce.camel@intel.com> (raw)
In-Reply-To: <20190923102935.5860-8-dhinakaran.pandiyan@intel.com>
On Mon, 2019-09-23 at 03:29 -0700, Dhinakaran Pandiyan wrote:
> During framebuffer creation, we pre-compute offsets for 90/270 plane
> rotation. However, only Y and Yf modifiers support 90/270 rotation. So,
> skip the calculations for other modifiers.
>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> b/drivers/gpu/drm/i915/display/intel_display.c
> index 7447001c1f85..6f0f38157697 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -2784,7 +2784,9 @@ intel_fill_fb_info(struct drm_i915_private *dev_priv,
> tile_size);
> offset /= tile_size;
>
> - if (!is_surface_linear(fb->modifier, i)) {
> + /* Y or Yf modifiers required for 90/270 rotation */
> + if (fb->modifier == I915_FORMAT_MOD_Y_TILED ||
> + fb->modifier == I915_FORMAT_MOD_Yf_TILED) {
This is wrong, as CI results clearly show igt@kms_addfb_basic@bo-too-small-due-to-tiling fails.
Please ignore this patch.
-DK
> unsigned int tile_width, tile_height;
> unsigned int pitch_tiles;
> struct drm_rect r;
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-10-03 21:18 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 10:29 [RFC v3 0/9] Gen12 E2E compression Dhinakaran Pandiyan
2019-09-23 10:29 ` [RFC v3 1/9] drm/framebuffer: Format modifier for Intel Gen-12 render compression Dhinakaran Pandiyan
2019-09-23 10:29 ` [RFC v3 2/9] drm/i915: Use intel_tile_height() instead of re-implementing Dhinakaran Pandiyan
2019-10-02 22:29 ` Matt Roper
2019-09-23 10:29 ` [RFC v3 3/9] drm/i915: Move CCS stride alignment W/A inside intel_fb_stride_alignment Dhinakaran Pandiyan
2019-10-02 22:29 ` Matt Roper
2019-10-03 21:29 ` Pandiyan, Dhinakaran
2019-09-23 10:29 ` [RFC v3 4/9] drm/i915/tgl: Gen-12 render decompression Dhinakaran Pandiyan
2019-10-02 22:32 ` Matt Roper
2019-10-03 12:00 ` Ville Syrjälä
2019-09-23 10:29 ` [RFC v3 5/9] drm/i915: Extract framebufer CCS offset checks into a function Dhinakaran Pandiyan
2019-10-04 15:10 ` Ville Syrjälä
2019-10-04 20:33 ` Matt Roper
2019-09-23 10:29 ` [RFC v3 6/9] drm/framebuffer: Format modifier for Intel Gen-12 media compression Dhinakaran Pandiyan
2019-09-26 6:42 ` Pandiyan, Dhinakaran
2019-09-23 10:29 ` [RFC v3 7/9] drm/i915: Skip rotated offset adjustment for unsupported modifiers Dhinakaran Pandiyan
2019-10-03 21:18 ` Dhinakaran Pandiyan [this message]
2019-09-23 10:29 ` [RFC v3 8/9] drm/fb: Extend format_info member arrays to handle four planes Dhinakaran Pandiyan
2019-09-23 10:29 ` [RFC v3 9/9] Gen-12 display can decompress surfaces compressed by the media engine Dhinakaran Pandiyan
2019-09-26 10:55 ` [PATCH v4 " Dhinakaran Pandiyan
2019-10-04 15:36 ` Ville Syrjälä
2019-10-04 23:54 ` Dhinakaran Pandiyan
2019-10-04 20:27 ` Matt Roper
2019-10-04 23:20 ` Dhinakaran Pandiyan
2019-09-23 13:53 ` ✗ Fi.CI.CHECKPATCH: warning for Gen12 E2E compression Patchwork
2019-09-23 14:16 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-09-26 11:01 ` ✗ Fi.CI.CHECKPATCH: warning for Gen12 E2E compression (rev2) Patchwork
2019-09-26 11:25 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-10-10 10:14 ` ✗ Fi.CI.CHECKPATCH: warning for Gen12 E2E compression (rev3) Patchwork
2019-10-10 10:39 ` ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af67dd9c0cf31c312748a29656ec5b7153ca59ce.camel@intel.com \
--to=dhinakaran.pandiyan@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox