Re: [PATCH v3 2/6] drm/i915/irq: constify pipe stats parameters

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Wed, May 13, 2026 at 01:10:07PM +0300, Jani Nikula wrote:
> The pipe stat irq handling doesn't need to modify the pipe stats
> arrays. Make them const.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_display_irq.c | 6 +++---
>  drivers/gpu/drm/i915/display/intel_display_irq.h | 6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_irq.c b/drivers/gpu/drm/i915/display/intel_display_irq.c
> index bf4b5e7b6011..d30b063714b0 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_irq.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_irq.c
> @@ -597,7 +597,7 @@ void i9xx_pipestat_irq_ack(struct intel_display *display,
>  }
>  
>  void i915_pipestat_irq_handler(struct intel_display *display,
> -			       u32 iir, u32 pipe_stats[I915_MAX_PIPES])
> +			       u32 iir, const u32 pipe_stats[I915_MAX_PIPES])
>  {
>  	bool blc_event = false;
>  	enum pipe pipe;
> @@ -621,7 +621,7 @@ void i915_pipestat_irq_handler(struct intel_display *display,
>  }
>  
>  void i965_pipestat_irq_handler(struct intel_display *display,
> -			       u32 iir, u32 pipe_stats[I915_MAX_PIPES])
> +			       u32 iir, const u32 pipe_stats[I915_MAX_PIPES])
>  {
>  	bool blc_event = false;
>  	enum pipe pipe;
> @@ -648,7 +648,7 @@ void i965_pipestat_irq_handler(struct intel_display *display,
>  }
>  
>  void valleyview_pipestat_irq_handler(struct intel_display *display,
> -				     u32 pipe_stats[I915_MAX_PIPES])
> +				     const u32 pipe_stats[I915_MAX_PIPES])
>  {
>  	enum pipe pipe;
>  
> diff --git a/drivers/gpu/drm/i915/display/intel_display_irq.h b/drivers/gpu/drm/i915/display/intel_display_irq.h
> index e2b1674fae06..d25b9ea4272b 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_irq.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_irq.h
> @@ -78,9 +78,9 @@ void i915_disable_pipestat(struct intel_display *display, enum pipe pipe, u32 st
>  
>  void i9xx_pipestat_irq_ack(struct intel_display *display, u32 iir, u32 pipe_stats[I915_MAX_PIPES]);
>  
> -void i915_pipestat_irq_handler(struct intel_display *display, u32 iir, u32 pipe_stats[I915_MAX_PIPES]);
> -void i965_pipestat_irq_handler(struct intel_display *display, u32 iir, u32 pipe_stats[I915_MAX_PIPES]);
> -void valleyview_pipestat_irq_handler(struct intel_display *display, u32 pipe_stats[I915_MAX_PIPES]);
> +void i915_pipestat_irq_handler(struct intel_display *display, u32 iir, const u32 pipe_stats[I915_MAX_PIPES]);
> +void i965_pipestat_irq_handler(struct intel_display *display, u32 iir, const u32 pipe_stats[I915_MAX_PIPES]);
> +void valleyview_pipestat_irq_handler(struct intel_display *display, const u32 pipe_stats[I915_MAX_PIPES]);
>  
>  void vlv_display_error_irq_ack(struct intel_display *display, u32 *eir, u32 *dpinvgtt);
>  void vlv_display_error_irq_handler(struct intel_display *display, u32 eir, u32 dpinvgtt);
> -- 
> 2.47.3

-- 
Ville Syrjälä
Intel