intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@kernel.org>
To: Krzysztof Karas <krzysztof.karas@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	 Jani Nikula <jani.nikula@linux.intel.com>,
	Andi Shyti <andi.shyti@linux.intel.com>,
	 Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>,
	Sebastian Brzezinka <sebastian.brzezinka@intel.com>,
	 Krzysztof Niemiec <krzysztof.niemiec@intel.com>
Subject: Re: [PATCH v3 4/8] drm/i915/gt/selftests: Use drm_* prints in aggregated gt selftests
Date: Tue, 29 Sep 2026 23:27:00 +0200	[thread overview]
Message-ID: <arws71LttyyKPINu@zenone.zhora.eu> (raw)
In-Reply-To: <d6n6pdqhf62m33vvawh2b2ayzsratsoae6n6v57kyjbbrvyius@zs3wyc6jszov>

Hi Krzysztof,

On Tue, Sep 29, 2026 at 12:06:15PM +0000, Krzysztof Karas wrote:
> On 2026-09-09 at 23:25:55 +0200, Andi Shyti wrote:
> > On Thu, Sep 03, 2026 at 12:39:10PM +0000, Krzysztof Karas wrote:
> > > On 2026-08-28 at 18:18:35 +0200, Andi Shyti wrote:
> > > > On Fri, Aug 28, 2026 at 10:03:35AM +0000, Krzysztof Karas wrote:
> > > > > Move away from generic pr prints to device context aware drm
> > > > > versions.
> > > > > 
> > > > > Assisted-by: GitHub-Copilot:claude-opus-5
> > > > 
> > > > what a ride!
> > > > 
> > > > While reviewing everything I was thinking whether it would make
> > > > sense to add an i915_err() like xe and gt.
> > > The idea makes sense, the question is when to introduce this
> > > macro. I have the v4 pretty much ready to send, apart from a few
> > > minor issues I have to fix, but I am not against modifying it to
> > > accomodate i915_* family of prints.
> > > If we agreed on this, then we'd have this new macro ready when
> > > we'd be replacing pr_* prints in other parts of the driver.
> > > 
> > > I think it would be worth to keep the series in the oven for a
> > > few more days, especially when it is not that critical of a
> > > change. What do you think?
> > 
> > yes, i915_* can come later, of course, it's out of the scope of
> > this series.
> > 
> > Andi
> 
> I checked again and again these past two weeks for your reply
> and none came into my inbox, only for me to notice today that it
> was finally pulled by my mailer client recently. I posted
> another version of this series, because I was under the
> impression that silence meant I should introduce the i915_*
> prints. That version was met with disapproval from Jani as well,
> so please just ignore v4.
> Sorry for the spam.

it's also true that I haven't been very active in reviews lately.

Are you now preparing a v5?

Andi

  reply	other threads:[~2026-09-29 21:27 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-28 10:03 [PATCH v3 0/8] drm/i915/selftests: Modernize printing in i915 selftests Krzysztof Karas
2026-08-28 10:03 ` [PATCH v3 1/8] drm/i915/selftest: Fix a typo in alloc_workqueue call Krzysztof Karas
2026-08-28 14:24   ` Andi Shyti
2026-08-28 16:54   ` Andi Shyti
2026-08-28 10:03 ` [PATCH v3 2/8] drm/i915/selftests: Use drm_* prints in live selftests Krzysztof Karas
2026-08-28 14:34   ` Andi Shyti
2026-08-31  8:35     ` Jani Nikula
2026-08-28 16:41   ` Krzysztof Niemiec
2026-08-31  8:39     ` Jani Nikula
2026-08-28 10:03 ` [PATCH v3 3/8] drm/i915/selftests: Use drm_* prints in selftest helpers Krzysztof Karas
2026-08-28 15:58   ` Andi Shyti
2026-08-28 16:49   ` Krzysztof Niemiec
2026-08-28 10:03 ` [PATCH v3 4/8] drm/i915/gt/selftests: Use drm_* prints in aggregated gt selftests Krzysztof Karas
2026-08-28 16:18   ` Andi Shyti
2026-09-03 12:39     ` Krzysztof Karas
2026-09-09 21:25       ` Andi Shyti
2026-09-29 12:06         ` Krzysztof Karas
2026-09-29 21:27           ` Andi Shyti [this message]
2026-09-30  6:01             ` Krzysztof Karas
2026-09-30 17:10               ` Andi Shyti
2026-08-28 17:40   ` Krzysztof Niemiec
2026-08-28 10:03 ` [PATCH v3 5/8] drm/i915/gt/selftests: Use drm_* prints in gt standalone tests Krzysztof Karas
2026-08-28 16:23   ` Andi Shyti
2026-08-28 18:02   ` Krzysztof Niemiec
2026-08-28 10:03 ` [PATCH v3 6/8] drm/i915/gt/selftests: Use drm_* prints in gt selftest helpers Krzysztof Karas
2026-08-28 16:28   ` Andi Shyti
2026-08-28 18:06   ` Krzysztof Niemiec
2026-08-28 10:03 ` [PATCH v3 7/8] drm/i915/selftests: Use drm_* prints in selftest headers Krzysztof Karas
2026-08-28 16:30   ` Andi Shyti
2026-08-28 18:08   ` Krzysztof Niemiec
2026-08-28 10:03 ` [PATCH v3 8/8] drm/i915/selftests: Add drm_device to selftest wrappers Krzysztof Karas
2026-08-28 16:36   ` Andi Shyti
2026-08-28 11:31 ` ✗ i915.CI.BAT: failure for drm/i915/selftests: Modernize printing in i915 selftests (rev4) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arws71LttyyKPINu@zenone.zhora.eu \
    --to=andi.shyti@kernel.org \
    --cc=andi.shyti@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=janusz.krzysztofik@linux.intel.com \
    --cc=krzysztof.karas@intel.com \
    --cc=krzysztof.niemiec@intel.com \
    --cc=sebastian.brzezinka@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).