* [Intel-gfx] [PATCH] drm/i915/mtl: Add workaround 14018778641
@ 2023-04-20 11:21 Tejas Upadhyay
2023-04-20 11:45 ` Das, Nirmoy
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Tejas Upadhyay @ 2023-04-20 11:21 UTC (permalink / raw)
To: intel-gfx; +Cc: Matt Roper
WA 18018781329 is applicable now across all MTL
steppings.
Cc: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 20 +++++++++++++-------
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 312eb8b5f949..c73d2b5410d8 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -1695,17 +1695,22 @@ pvc_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)
static void
xelpg_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)
{
- if (IS_MTL_GRAPHICS_STEP(gt->i915, M, STEP_A0, STEP_B0) ||
- IS_MTL_GRAPHICS_STEP(gt->i915, P, STEP_A0, STEP_B0)) {
- /* Wa_14014830051 */
- wa_mcr_write_clr(wal, SARB_CHICKEN1, COMP_CKN_IN);
+ /* Wa_14018778641: MTL */
+ if (IS_METEORLAKE(gt->i915)) {
/* Wa_18018781329 */
wa_mcr_write_or(wal, RENDER_MOD_CTRL, FORCE_MISS_FTLB);
wa_mcr_write_or(wal, COMP_MOD_CTRL, FORCE_MISS_FTLB);
- /* Wa_14015795083 */
- wa_write_clr(wal, GEN7_MISCCPCTL, GEN12_DOP_CLOCK_GATE_RENDER_ENABLE);
+ if (IS_MTL_GRAPHICS_STEP(gt->i915, M, STEP_A0, STEP_B0) ||
+ IS_MTL_GRAPHICS_STEP(gt->i915, P, STEP_A0, STEP_B0)) {
+ /* Wa_14014830051 */
+ wa_mcr_write_clr(wal, SARB_CHICKEN1, COMP_CKN_IN);
+
+ /* Wa_14015795083 */
+ wa_write_clr(wal, GEN7_MISCCPCTL,
+ GEN12_DOP_CLOCK_GATE_RENDER_ENABLE);
+ }
}
/*
@@ -1718,7 +1723,8 @@ xelpg_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)
static void
xelpmp_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)
{
- if (IS_MTL_MEDIA_STEP(gt->i915, STEP_A0, STEP_B0)) {
+ /* Wa_14018778641: MTL */
+ if (IS_METEORLAKE(gt->i915)) {
/*
* Wa_18018781329
*
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915/mtl: Add workaround 14018778641 2023-04-20 11:21 [Intel-gfx] [PATCH] drm/i915/mtl: Add workaround 14018778641 Tejas Upadhyay @ 2023-04-20 11:45 ` Das, Nirmoy 2023-04-20 12:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork ` (2 subsequent siblings) 3 siblings, 0 replies; 5+ messages in thread From: Das, Nirmoy @ 2023-04-20 11:45 UTC (permalink / raw) To: Tejas Upadhyay, intel-gfx; +Cc: Matt Roper On 4/20/2023 1:21 PM, Tejas Upadhyay wrote: > WA 18018781329 is applicable now across all MTL > steppings. > > Cc: Matt Roper <matthew.d.roper@intel.com> > Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com> Acked-by: Nirmoy Das <nirmoy.das@intel.com> > --- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 20 +++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c > index 312eb8b5f949..c73d2b5410d8 100644 > --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c > +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c > @@ -1695,17 +1695,22 @@ pvc_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal) > static void > xelpg_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal) > { > - if (IS_MTL_GRAPHICS_STEP(gt->i915, M, STEP_A0, STEP_B0) || > - IS_MTL_GRAPHICS_STEP(gt->i915, P, STEP_A0, STEP_B0)) { > - /* Wa_14014830051 */ > - wa_mcr_write_clr(wal, SARB_CHICKEN1, COMP_CKN_IN); > + /* Wa_14018778641: MTL */ > + if (IS_METEORLAKE(gt->i915)) { > > /* Wa_18018781329 */ > wa_mcr_write_or(wal, RENDER_MOD_CTRL, FORCE_MISS_FTLB); > wa_mcr_write_or(wal, COMP_MOD_CTRL, FORCE_MISS_FTLB); > > - /* Wa_14015795083 */ > - wa_write_clr(wal, GEN7_MISCCPCTL, GEN12_DOP_CLOCK_GATE_RENDER_ENABLE); > + if (IS_MTL_GRAPHICS_STEP(gt->i915, M, STEP_A0, STEP_B0) || > + IS_MTL_GRAPHICS_STEP(gt->i915, P, STEP_A0, STEP_B0)) { > + /* Wa_14014830051 */ > + wa_mcr_write_clr(wal, SARB_CHICKEN1, COMP_CKN_IN); > + > + /* Wa_14015795083 */ > + wa_write_clr(wal, GEN7_MISCCPCTL, > + GEN12_DOP_CLOCK_GATE_RENDER_ENABLE); > + } > } > > /* > @@ -1718,7 +1723,8 @@ xelpg_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal) > static void > xelpmp_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal) > { > - if (IS_MTL_MEDIA_STEP(gt->i915, STEP_A0, STEP_B0)) { > + /* Wa_14018778641: MTL */ > + if (IS_METEORLAKE(gt->i915)) { > /* > * Wa_18018781329 > * ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Add workaround 14018778641 2023-04-20 11:21 [Intel-gfx] [PATCH] drm/i915/mtl: Add workaround 14018778641 Tejas Upadhyay 2023-04-20 11:45 ` Das, Nirmoy @ 2023-04-20 12:01 ` Patchwork 2023-04-20 15:23 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2023-04-21 0:00 ` [Intel-gfx] [PATCH] " Matt Roper 3 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2023-04-20 12:01 UTC (permalink / raw) To: Tejas Upadhyay; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 3692 bytes --] == Series Details == Series: drm/i915/mtl: Add workaround 14018778641 URL : https://patchwork.freedesktop.org/series/116750/ State : success == Summary == CI Bug Log - changes from CI_DRM_13033 -> Patchwork_116750v1 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116750v1/index.html Participating hosts (37 -> 36) ------------------------------ Missing (1): fi-snb-2520m Known issues ------------ Here are the changes found in Patchwork_116750v1 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@kms_chamelium_hpd@common-hpd-after-suspend: - bat-rpls-1: NOTRUN -> [SKIP][1] ([i915#7828]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116750v1/bat-rpls-1/igt@kms_chamelium_hpd@common-hpd-after-suspend.html * igt@kms_pipe_crc_basic@suspend-read-crc: - bat-rpls-1: NOTRUN -> [SKIP][2] ([i915#1845]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116750v1/bat-rpls-1/igt@kms_pipe_crc_basic@suspend-read-crc.html #### Possible fixes #### * igt@gem_exec_suspend@basic-s3@smem: - bat-rpls-1: [ABORT][3] ([i915#6687] / [i915#7978]) -> [PASS][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13033/bat-rpls-1/igt@gem_exec_suspend@basic-s3@smem.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116750v1/bat-rpls-1/igt@gem_exec_suspend@basic-s3@smem.html * igt@i915_selftest@live@gt_heartbeat: - fi-apl-guc: [DMESG-FAIL][5] ([i915#5334]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13033/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116750v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html #### Warnings #### * igt@i915_selftest@live@slpc: - bat-rpls-1: [DMESG-FAIL][7] ([i915#6367] / [i915#6997]) -> [DMESG-FAIL][8] ([i915#6367] / [i915#7996]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13033/bat-rpls-1/igt@i915_selftest@live@slpc.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116750v1/bat-rpls-1/igt@i915_selftest@live@slpc.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845 [i915#2017]: https://gitlab.freedesktop.org/drm/intel/issues/2017 [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334 [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367 [i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687 [i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997 [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828 [i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978 [i915#7996]: https://gitlab.freedesktop.org/drm/intel/issues/7996 [i915#8379]: https://gitlab.freedesktop.org/drm/intel/issues/8379 Build changes ------------- * Linux: CI_DRM_13033 -> Patchwork_116750v1 CI-20190529: 20190529 CI_DRM_13033: 9e075fd5e9f743c09bf3c220ffda0e32d868667b @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7261: 364d0b3291cba6e99deda07499c876bb2b6c1c1d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_116750v1: 9e075fd5e9f743c09bf3c220ffda0e32d868667b @ git://anongit.freedesktop.org/gfx-ci/linux ### Linux commits 4404d549bdf1 drm/i915/mtl: Add workaround 14018778641 == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116750v1/index.html [-- Attachment #2: Type: text/html, Size: 4343 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/mtl: Add workaround 14018778641 2023-04-20 11:21 [Intel-gfx] [PATCH] drm/i915/mtl: Add workaround 14018778641 Tejas Upadhyay 2023-04-20 11:45 ` Das, Nirmoy 2023-04-20 12:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork @ 2023-04-20 15:23 ` Patchwork 2023-04-21 0:00 ` [Intel-gfx] [PATCH] " Matt Roper 3 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2023-04-20 15:23 UTC (permalink / raw) To: Tejas Upadhyay; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 10823 bytes --] == Series Details == Series: drm/i915/mtl: Add workaround 14018778641 URL : https://patchwork.freedesktop.org/series/116750/ State : success == Summary == CI Bug Log - changes from CI_DRM_13033_full -> Patchwork_116750v1_full ==================================================== Summary ------- **SUCCESS** No regressions found. Participating hosts (7 -> 7) ------------------------------ No changes in participating hosts Known issues ------------ Here are the changes found in Patchwork_116750v1_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@kms_color@ctm-max@pipe-a-hdmi-a-1: - shard-snb: NOTRUN -> [SKIP][1] ([fdo#109271]) +32 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116750v1/shard-snb1/igt@kms_color@ctm-max@pipe-a-hdmi-a-1.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-glk: [PASS][2] -> [FAIL][3] ([i915#2346]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13033/shard-glk2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116750v1/shard-glk4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html * igt@kms_psr@psr2_primary_page_flip: - shard-glk: NOTRUN -> [SKIP][4] ([fdo#109271]) +12 similar issues [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116750v1/shard-glk1/igt@kms_psr@psr2_primary_page_flip.html #### Possible fixes #### * igt@drm_fdinfo@most-busy-idle-check-all@rcs0: - {shard-rkl}: [FAIL][5] ([i915#7742]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13033/shard-rkl-1/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116750v1/shard-rkl-2/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html * igt@gem_ctx_exec@basic-nohangcheck: - {shard-rkl}: [FAIL][7] ([i915#6268]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13033/shard-rkl-6/igt@gem_ctx_exec@basic-nohangcheck.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116750v1/shard-rkl-7/igt@gem_ctx_exec@basic-nohangcheck.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-glk: [FAIL][9] ([i915#2842]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13033/shard-glk7/igt@gem_exec_fair@basic-pace-share@rcs0.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116750v1/shard-glk4/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_fair@basic-pace@rcs0: - {shard-rkl}: [FAIL][11] ([i915#2842]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13033/shard-rkl-6/igt@gem_exec_fair@basic-pace@rcs0.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116750v1/shard-rkl-2/igt@gem_exec_fair@basic-pace@rcs0.html * igt@gen9_exec_parse@allowed-single: - shard-glk: [ABORT][13] ([i915#5566]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13033/shard-glk7/igt@gen9_exec_parse@allowed-single.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116750v1/shard-glk1/igt@gen9_exec_parse@allowed-single.html * igt@i915_pm_rpm@dpms-lpsp: - {shard-rkl}: [SKIP][15] ([i915#1397]) -> [PASS][16] +1 similar issue [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13033/shard-rkl-1/igt@i915_pm_rpm@dpms-lpsp.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116750v1/shard-rkl-7/igt@i915_pm_rpm@dpms-lpsp.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size: - shard-apl: [FAIL][17] ([i915#2346]) -> [PASS][18] [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13033/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116750v1/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html * igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2: - shard-glk: [FAIL][19] ([i915#79]) -> [PASS][20] +1 similar issue [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13033/shard-glk1/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116750v1/shard-glk5/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307 [fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309 [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506 [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615 [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397 [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839 [i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437 [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527 [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575 [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587 [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672 [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705 [i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2876]: https://gitlab.freedesktop.org/drm/intel/issues/2876 [i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315 [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297 [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359 [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458 [i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528 [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638 [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804 [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886 [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955 [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212 [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213 [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 [i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391 [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538 [i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565 [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579 [i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771 [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812 [i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816 [i915#4818]: https://gitlab.freedesktop.org/drm/intel/issues/4818 [i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833 [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852 [i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860 [i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873 [i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880 [i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885 [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176 [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235 [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286 [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289 [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325 [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354 [i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563 [i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566 [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784 [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095 [i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230 [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268 [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946 [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116 [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561 [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697 [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711 [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742 [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 Build changes ------------- * Linux: CI_DRM_13033 -> Patchwork_116750v1 CI-20190529: 20190529 CI_DRM_13033: 9e075fd5e9f743c09bf3c220ffda0e32d868667b @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7261: 364d0b3291cba6e99deda07499c876bb2b6c1c1d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_116750v1: 9e075fd5e9f743c09bf3c220ffda0e32d868667b @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116750v1/index.html [-- Attachment #2: Type: text/html, Size: 6808 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/mtl: Add workaround 14018778641 2023-04-20 11:21 [Intel-gfx] [PATCH] drm/i915/mtl: Add workaround 14018778641 Tejas Upadhyay ` (2 preceding siblings ...) 2023-04-20 15:23 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork @ 2023-04-21 0:00 ` Matt Roper 3 siblings, 0 replies; 5+ messages in thread From: Matt Roper @ 2023-04-21 0:00 UTC (permalink / raw) To: Tejas Upadhyay; +Cc: intel-gfx On Thu, Apr 20, 2023 at 04:51:23PM +0530, Tejas Upadhyay wrote: > WA 18018781329 is applicable now across all MTL > steppings. > > Cc: Matt Roper <matthew.d.roper@intel.com> > Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com> > --- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 20 +++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c > index 312eb8b5f949..c73d2b5410d8 100644 > --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c > +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c > @@ -1695,17 +1695,22 @@ pvc_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal) > static void > xelpg_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal) > { > - if (IS_MTL_GRAPHICS_STEP(gt->i915, M, STEP_A0, STEP_B0) || > - IS_MTL_GRAPHICS_STEP(gt->i915, P, STEP_A0, STEP_B0)) { > - /* Wa_14014830051 */ > - wa_mcr_write_clr(wal, SARB_CHICKEN1, COMP_CKN_IN); > + /* Wa_14018778641: MTL */ > + if (IS_METEORLAKE(gt->i915)) { It's already MTL if we're inside this function. No need for the condition. Same for the one in xelpmp_gt_workarounds_init farther down. In the future it's possible that other platforms could re-use the Xe_LPG and/or Xe_LPM+ chips in a different platform. If that happens, we'd also want these workarounds to apply on those other non-MTL platforms as well since the workaround is tied to the IP rather than the platform. Matt > > /* Wa_18018781329 */ > wa_mcr_write_or(wal, RENDER_MOD_CTRL, FORCE_MISS_FTLB); > wa_mcr_write_or(wal, COMP_MOD_CTRL, FORCE_MISS_FTLB); > > - /* Wa_14015795083 */ > - wa_write_clr(wal, GEN7_MISCCPCTL, GEN12_DOP_CLOCK_GATE_RENDER_ENABLE); > + if (IS_MTL_GRAPHICS_STEP(gt->i915, M, STEP_A0, STEP_B0) || > + IS_MTL_GRAPHICS_STEP(gt->i915, P, STEP_A0, STEP_B0)) { > + /* Wa_14014830051 */ > + wa_mcr_write_clr(wal, SARB_CHICKEN1, COMP_CKN_IN); > + > + /* Wa_14015795083 */ > + wa_write_clr(wal, GEN7_MISCCPCTL, > + GEN12_DOP_CLOCK_GATE_RENDER_ENABLE); > + } > } > > /* > @@ -1718,7 +1723,8 @@ xelpg_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal) > static void > xelpmp_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal) > { > - if (IS_MTL_MEDIA_STEP(gt->i915, STEP_A0, STEP_B0)) { > + /* Wa_14018778641: MTL */ > + if (IS_METEORLAKE(gt->i915)) { > /* > * Wa_18018781329 > * > -- > 2.25.1 > -- Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-04-21 0:00 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-04-20 11:21 [Intel-gfx] [PATCH] drm/i915/mtl: Add workaround 14018778641 Tejas Upadhyay 2023-04-20 11:45 ` Das, Nirmoy 2023-04-20 12:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2023-04-20 15:23 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2023-04-21 0:00 ` [Intel-gfx] [PATCH] " Matt Roper
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox