From: Chris Wilson <chris@chris-wilson.co.uk>
To: Zhenyu Wang <zhenyuw@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Fix KMS regression on Sandybridge/CPT
Date: Thu, 04 Nov 2010 02:23:46 +0000 [thread overview]
Message-ID: <b9dded$gvojco@orsmga002.jf.intel.com> (raw)
In-Reply-To: <20101102062422.GA6369@zhen-devel.sh.intel.com>
On Tue, 2 Nov 2010 14:24:22 +0800, Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
> I don't think transcoder bpc setting should matter, but sorry that I'm short
> of time to track down which one extra read made the difference, my sandybridge
> laptop normally refuse to boot on first time.. ;)
>
> The code operation is same as what we have in .36 kernel, so could you restore
> behavior back first?
The original patch was unacceptable since it did more than it claimed to
in its changelog. Just disabling the Ironlake workaround and restoring the
FDI normal train on crtc disable is insufficient. I remain dubious that
adding the POSTING_READs is sufficient without at least some explanation
and some testing.
I could break the original patch down into the 5 separate patches (of
which it sounds like we only need 3) and I would still be waiting on
someone to test them...
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2010-11-04 2:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 8:38 [PATCH] drm/i915: Fix KMS regression on Sandybridge/CPT Zhenyu Wang
2010-10-28 9:50 ` Chris Wilson
2010-10-29 2:34 ` Zhenyu Wang
2010-10-29 8:52 ` Chris Wilson
2010-11-02 6:24 ` Zhenyu Wang
2010-11-04 2:23 ` Chris Wilson [this message]
[not found] ` <20101104055024.GJ6369@zhen-devel.sh.intel.com>
2010-11-04 6:26 ` Zhenyu Wang
2010-11-04 9:08 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='b9dded$gvojco@orsmga002.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=zhenyuw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox