From: Chris Wilson <chris@chris-wilson.co.uk>
To: Simon Farnsworth <simon.farnsworth@onelan.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/sdvo: Only enable HDMI encodings only if the commandset is supported
Date: Mon, 22 Nov 2010 13:31:03 +0000 [thread overview]
Message-ID: <b9dded$h5irsg@orsmga002.jf.intel.com> (raw)
In-Reply-To: <201011221316.43859.simon.farnsworth@onelan.co.uk>
On Mon, 22 Nov 2010 13:16:43 +0000, Simon Farnsworth <simon.farnsworth@onelan.co.uk> wrote:
> On Monday 22 November 2010, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > As we conflated intel_sdvo->is_hdmi with both having HDMI support on the
> > ADD along with having HDMI support on the monitor, we would attempt to
> > use HDMI encodings even if the interface did not support those commands.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> This fixes my problems with the image being in the middle third or so of the
> screen. I've also read the patch and resulting state of code, and it looks
> like the right thing to do, so take your pick of:
>
> Tested-by: Simon Farnsworth <simon.farnsworth@onelan.co.uk>
> Reviewed-by: Simon Farnsworth <simon.farnsworth@onelan.co.uk>
Excellent! Pushed to -fixes.
Thanks,
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2010-11-22 13:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <id:0d30dc$k89l8c@orsmga001.jf.intel.com>
2010-11-22 11:30 ` [PATCH] drm/i915/sdvo: Only enable HDMI encodings only if the commandset is supported Chris Wilson
2010-11-22 13:16 ` Simon Farnsworth
2010-11-22 13:31 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='b9dded$h5irsg@orsmga002.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=simon.farnsworth@onelan.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox