Re: [PATCH v2 4/7] drm/i915/dp_mst: Reuse the DP-SST helper function to compute FEC config

["Hogander, Jouni" <jouni.hogander@intel.com>]

On Wed, 2025-10-15 at 19:19 +0300, Imre Deak wrote:
> Reuse the DP-SST helper to compute the state for the FEC enabled
> state
> for DP-MST as well.
> 
> Signed-off-by: Imre Deak <imre.deak@intel.com>

Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_dp_mst.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> index d0590b5ffffd7..0cbb4c3a8e22f 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> @@ -298,12 +298,10 @@ int intel_dp_mtp_tu_compute_config(struct
> intel_dp *intel_dp,
>  	 * after it was set by intel_dp_dsc_compute_config() ->
>  	 * intel_dp_needs_8b10b_fec().
>  	 */
> -	if (dsc) {
> -		if (!intel_dp_supports_fec(intel_dp, connector,
> crtc_state))
> -			return -EINVAL;
> -
> -		crtc_state->fec_enable =
> !intel_dp_is_uhbr(crtc_state);
> -	}
> +	crtc_state->fec_enable =
> intel_dp_needs_8b10b_fec(crtc_state, dsc);
> +	if (crtc_state->fec_enable &&
> +	    !intel_dp_supports_fec(intel_dp, connector, crtc_state))
> +		return -EINVAL;
>  
>  	max_dpt_bpp_x16 =
> fxp_q4_from_int(intel_dp_mst_max_dpt_bpp(crtc_state, dsc));
>  	if (max_dpt_bpp_x16 && max_bpp_x16 > max_dpt_bpp_x16) {