From: Chris Wilson <chris@chris-wilson.co.uk>
To: david may <david.may10@ntlworld.com>,
Zhenyu Wang <zhenyuw@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: patches for occlusion query fix on sandybridge
Date: Tue, 14 Dec 2010 21:47:45 +0000 [thread overview]
Message-ID: <c6d829$prvese@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <944877732.20101214205909@ntlworld.com>
On Tue, 14 Dec 2010 20:59:09 +0000, david may <david.may10@ntlworld.com> wrote:
> Hello Eric,
>
> Tuesday, December 14, 2010, 5:58:58 PM, you wrote:
>
> > Why don't we just keep all of our BOs LLC cached? This was supposed to
> > be a big win of the new chipset, as it means we don't need to clflush.
>
> Ohh,the implication here is that people are/have been writing the
> code,But Not bothering Actually benching/Profiling it to see if it actually is faster and
> better throughput than before, that seems wrong, especially given sandy bridge is
> supposed to be better, i Do Hope you are/will be testing/benching/Profiling
> to see if it/all SB Code is actually "a big win" one way or the other before passing for
> release.
No, the default on SNB was changed back to uncached in order to fix some
coherency issues in the short term. Correctness first.
commit 8d0f56708292ca5c256ee3b7187d124afee81d93
Author: Zhenyu Wang <zhenyuw@linux.intel.com>
Date: Tue Nov 2 17:30:47 2010 +0800
agp/intel: restore cache behavior on sandybridge
This restores cache behavior for default AGP_USER_MEMORY as
uncached, and leave default AGP_USER_CACHED_MEMORY as LLC only.
I've seen different cache behavior on one sandybridge desktop CPU vs.
another mobile CPU. Until we figure out how to detect the real cache
config, restore back to the original behavior now.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2010-12-14 21:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 4:55 patches for occlusion query fix on sandybridge Zhenyu Wang
2010-12-14 4:56 ` [PATCH] drm/i915: Add cached bo create interface Zhenyu Wang
2010-12-14 4:56 ` [PATCH] intel: new interface for cached bo create Zhenyu Wang
2010-12-14 9:35 ` Chris Wilson
2010-12-14 4:56 ` [PATCH] i965: alloc cached bo for query object on Sandybridge Zhenyu Wang
2010-12-14 17:58 ` patches for occlusion query fix on sandybridge Eric Anholt
2010-12-14 20:59 ` david may
2010-12-14 21:47 ` Chris Wilson [this message]
2010-12-15 1:18 ` Zhenyu Wang
2010-12-14 18:13 ` Daniel Vetter
2010-12-15 1:29 ` Zhenyu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='c6d829$prvese@fmsmga001.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=david.may10@ntlworld.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=zhenyuw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox