From: Eric Anholt <eric@anholt.net>
To: Zhenyu Wang <zhenyuw@linux.intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: patches for occlusion query fix on sandybridge
Date: Tue, 14 Dec 2010 09:58:58 -0800 [thread overview]
Message-ID: <877hfcgrrx.fsf@pollan.anholt.net> (raw)
In-Reply-To: <1292302562-5800-1-git-send-email-zhenyuw@linux.intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 801 bytes --]
On Tue, 14 Dec 2010 12:55:59 +0800, Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
> It appears Sandybridge PIPE_CONTROL write out buffer need
> to be set as cached, currently LLC cached, in order to read
> back correct counter. Otherwise I can always be possible to
> get corrupted 64-bit PS_DEPTH_COUNT from PIPE_CONTROL write.
>
> So below patches try to add new flag during bo create with
> cacheable type, to be sure that GTT entry's cache bits would
> be setup for that.
>
> This fixes occlusion query piglit test and mesa demos on my
> sandybridge. Note that below patches don't include necessary
> component version check changes.
Why don't we just keep all of our BOs LLC cached? This was supposed to
be a big win of the new chipset, as it means we don't need to clflush.
[-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2010-12-14 17:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 4:55 patches for occlusion query fix on sandybridge Zhenyu Wang
2010-12-14 4:56 ` [PATCH] drm/i915: Add cached bo create interface Zhenyu Wang
2010-12-14 4:56 ` [PATCH] intel: new interface for cached bo create Zhenyu Wang
2010-12-14 9:35 ` Chris Wilson
2010-12-14 4:56 ` [PATCH] i965: alloc cached bo for query object on Sandybridge Zhenyu Wang
2010-12-14 17:58 ` Eric Anholt [this message]
2010-12-14 20:59 ` patches for occlusion query fix on sandybridge david may
2010-12-14 21:47 ` Chris Wilson
2010-12-15 1:18 ` Zhenyu Wang
2010-12-14 18:13 ` Daniel Vetter
2010-12-15 1:29 ` Zhenyu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877hfcgrrx.fsf@pollan.anholt.net \
--to=eric@anholt.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=zhenyuw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox