From: "Das, Nirmoy" <nirmoy.das@linux.intel.com>
To: Matthew Auld <matthew.auld@intel.com>, igt-dev@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org, Nirmoy Das <nirmoy.das@intel.com>
Subject: Re: [Intel-gfx] [PATCH i-g-t] tests/i915/module_load: fix resize-bar on DG1
Date: Mon, 10 Oct 2022 13:14:33 +0200 [thread overview]
Message-ID: <cd4ff9de-d369-ed86-2837-b6c55e67bd4f@linux.intel.com> (raw)
In-Reply-To: <20221010104840.28026-1-matthew.auld@intel.com>
On 10/10/2022 12:48 PM, Matthew Auld wrote:
> DG1, as expected only has a fixed sized bar, so attempting to force the
> BAR size should fail. Update the test to account for such devices, and
> perform a skip, instead of failing.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6458
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Nirmoy Das <nirmoy.das@intel.com>
Tested-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
> tests/i915/i915_module_load.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/i915/i915_module_load.c b/tests/i915/i915_module_load.c
> index 4c72157c..6d74de58 100644
> --- a/tests/i915/i915_module_load.c
> +++ b/tests/i915/i915_module_load.c
> @@ -422,7 +422,7 @@ igt_main
>
> /* Test for lmem_bar_size modparam support */
> lmem_bar_size = driver_load_with_lmem_bar_size(MIN_BAR_SIZE, true);
> - igt_assert_eq(lmem_bar_size, MIN_BAR_SIZE);
> + igt_skip_on_f(lmem_bar_size != MIN_BAR_SIZE, "Device lacks PCI resizeable BAR support.\n");
>
> lmem_bar_size = driver_load_with_lmem_bar_size(0, false);
>
prev parent reply other threads:[~2022-10-10 11:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 10:48 [Intel-gfx] [PATCH i-g-t] tests/i915/module_load: fix resize-bar on DG1 Matthew Auld
2022-10-10 11:14 ` Das, Nirmoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd4ff9de-d369-ed86-2837-b6c55e67bd4f@linux.intel.com \
--to=nirmoy.das@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
--cc=nirmoy.das@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox