* [Intel-gfx] [PATCH i-g-t] tests/i915/module_load: fix resize-bar on DG1
@ 2022-10-10 10:48 Matthew Auld
2022-10-10 11:14 ` Das, Nirmoy
0 siblings, 1 reply; 2+ messages in thread
From: Matthew Auld @ 2022-10-10 10:48 UTC (permalink / raw)
To: igt-dev; +Cc: intel-gfx, Nirmoy Das
DG1, as expected only has a fixed sized bar, so attempting to force the
BAR size should fail. Update the test to account for such devices, and
perform a skip, instead of failing.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6458
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Nirmoy Das <nirmoy.das@intel.com>
---
tests/i915/i915_module_load.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/i915/i915_module_load.c b/tests/i915/i915_module_load.c
index 4c72157c..6d74de58 100644
--- a/tests/i915/i915_module_load.c
+++ b/tests/i915/i915_module_load.c
@@ -422,7 +422,7 @@ igt_main
/* Test for lmem_bar_size modparam support */
lmem_bar_size = driver_load_with_lmem_bar_size(MIN_BAR_SIZE, true);
- igt_assert_eq(lmem_bar_size, MIN_BAR_SIZE);
+ igt_skip_on_f(lmem_bar_size != MIN_BAR_SIZE, "Device lacks PCI resizeable BAR support.\n");
lmem_bar_size = driver_load_with_lmem_bar_size(0, false);
--
2.37.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t] tests/i915/module_load: fix resize-bar on DG1
2022-10-10 10:48 [Intel-gfx] [PATCH i-g-t] tests/i915/module_load: fix resize-bar on DG1 Matthew Auld
@ 2022-10-10 11:14 ` Das, Nirmoy
0 siblings, 0 replies; 2+ messages in thread
From: Das, Nirmoy @ 2022-10-10 11:14 UTC (permalink / raw)
To: Matthew Auld, igt-dev; +Cc: intel-gfx, Nirmoy Das
On 10/10/2022 12:48 PM, Matthew Auld wrote:
> DG1, as expected only has a fixed sized bar, so attempting to force the
> BAR size should fail. Update the test to account for such devices, and
> perform a skip, instead of failing.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6458
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Nirmoy Das <nirmoy.das@intel.com>
Tested-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
> tests/i915/i915_module_load.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/i915/i915_module_load.c b/tests/i915/i915_module_load.c
> index 4c72157c..6d74de58 100644
> --- a/tests/i915/i915_module_load.c
> +++ b/tests/i915/i915_module_load.c
> @@ -422,7 +422,7 @@ igt_main
>
> /* Test for lmem_bar_size modparam support */
> lmem_bar_size = driver_load_with_lmem_bar_size(MIN_BAR_SIZE, true);
> - igt_assert_eq(lmem_bar_size, MIN_BAR_SIZE);
> + igt_skip_on_f(lmem_bar_size != MIN_BAR_SIZE, "Device lacks PCI resizeable BAR support.\n");
>
> lmem_bar_size = driver_load_with_lmem_bar_size(0, false);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-10 11:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-10 10:48 [Intel-gfx] [PATCH i-g-t] tests/i915/module_load: fix resize-bar on DG1 Matthew Auld
2022-10-10 11:14 ` Das, Nirmoy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox