From: Chris Wilson <chris@chris-wilson.co.uk>
To: Zhigang Gong <zhigang.gong@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/3] glamor: turn on glamor.
Date: Fri, 11 Nov 2011 09:11:35 +0000 [thread overview]
Message-ID: <e0d58a$26gkgu@orsmga002.jf.intel.com> (raw)
In-Reply-To: <1321000281-5097-2-git-send-email-zhigang.gong@linux.intel.com>
On Fri, 11 Nov 2011 16:31:20 +0800, Zhigang Gong <zhigang.gong@linux.intel.com> wrote:
> @@ -965,6 +969,9 @@ void intel_uxa_block_handler(intel_screen_private *intel)
> * framebuffer until significantly later.
> */
> intel_flush_rendering(intel);
> +#ifdef GLAMOR
> + intel_glamor_block_handler(intel);
> +#endif
> }
I suspect this is the wrong way around as we are not flushing the
render cache of glamor's rendering to the scanout until the next block
handler.
In general, try to keep the #ifdef out of the body of the code. In this
case, and others, make intel_glamor_block_handler() be a no-op if GLAMOR
is not enabled.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-11-11 9:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-11 8:31 [PATCH 1/3] glamor: Initial commit to introduce glamor acceleration Zhigang Gong
2011-11-11 8:31 ` [PATCH 2/3] glamor: turn on glamor Zhigang Gong
2011-11-11 9:11 ` Chris Wilson [this message]
2011-11-11 10:52 ` Zhigang Gong
2011-11-11 13:12 ` Chris Wilson
2011-11-14 5:01 ` Zhigang Gong
2011-11-14 9:07 ` Chris Wilson
2011-11-14 12:02 ` Zhigang Gong
2011-11-11 12:58 ` Eugeni Dodonov
2011-11-14 5:05 ` Zhigang Gong
2011-11-11 8:31 ` [PATCH 3/3] glamor: Route fillspans and polyfillrects to glamor Zhigang Gong
2011-11-11 9:07 ` Chris Wilson
2011-11-11 10:48 ` Zhigang Gong
2011-11-11 13:54 ` Chris Wilson
2011-11-14 3:32 ` Zhigang Gong
2011-11-11 12:56 ` [PATCH 1/3] glamor: Initial commit to introduce glamor acceleration Eugeni Dodonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='e0d58a$26gkgu@orsmga002.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=zhigang.gong@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox