* [Intel-gfx] [PATCH v3 0/2] drm/i915/guc: Add GuC-Error-Capture-Init coverage of new engine types
@ 2022-10-19 7:29 Alan Previn
2022-10-19 7:29 ` [Intel-gfx] [PATCH v3 1/2] drm/i915/guc: Add error-capture init warnings when needed Alan Previn
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Alan Previn @ 2022-10-19 7:29 UTC (permalink / raw)
To: intel-gfx
After initial upstream merge of GuC error-capture feature, we eventually
decided to remove a lot of unnecessary warning messages when we couldn't
retrieve register lists for ADS-error-state-capture initialization. It was
a justified decision because the majority of that noise was being repeated
three times per GT reset and included list-types that are not supported
upstream. However after that change, we are not able to catch cases of
missing register lists for new engines that hadn't been added.
This series introduces new selective checks and warnings (such as skipping
if its a VF or if its an empty register list). This series also adds register
list for compute engine which is merely a duplicate of render class list.
Changes from prior revs:
v2 : - Fix build error.
v1 : - Fix the drm_warn string split (Tvrtko Ursulin / John Harrison)
- Minor cosmetics around the drm_warn message checks (Tvrtko Ursulin /
John Harrison)
- Dont use empy string in stringify functions (Tvrtko Ursulin)
- Ensure guc_capture_output_min_size_est doesn't trigger
the drm_warn when calculating estimation size for worst case
engine counts that may not exist (Alan Previn).
Alan Previn (2):
drm/i915/guc: Add error-capture init warnings when needed
drm/i915/guc: Add compute reglist for guc err capture
.../gpu/drm/i915/gt/uc/intel_guc_capture.c | 82 +++++++++++++++++--
1 file changed, 73 insertions(+), 9 deletions(-)
base-commit: b249abef9f86f788e6bacc657ae8eb7743948200
--
2.34.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] [PATCH v3 1/2] drm/i915/guc: Add error-capture init warnings when needed
2022-10-19 7:29 [Intel-gfx] [PATCH v3 0/2] drm/i915/guc: Add GuC-Error-Capture-Init coverage of new engine types Alan Previn
@ 2022-10-19 7:29 ` Alan Previn
2022-10-21 19:42 ` John Harrison
2022-10-19 7:29 ` [Intel-gfx] [PATCH v3 2/2] drm/i915/guc: Add compute reglist for guc err capture Alan Previn
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Alan Previn @ 2022-10-19 7:29 UTC (permalink / raw)
To: intel-gfx
If GuC is being used and we initialized GuC-error-capture,
we need to be warning if we don't provide an error-capture
register list in the firmware ADS, for valid GT engines.
A warning makes sense as this would impact debugability
without realizing why a reglist wasn't retrieved and reported
by GuC.
However, depending on the platform, we might have certain
engines that have a register list for engine instance error state
but not for engine class. Thus, add a check only to warn if the
register list was non existent vs an empty list (use the
empty lists to skip the warning).
NOTE: if a future platform were to introduce new registers
in place of what was an empty list on existing / legacy hardware
engines no warning is provided as the empty list is meant
to be used intentionally. As an example, if a future hardware
were to add blitter engine-class-registers (new) on top
of the legacy blitter engine-instance-register (HEAD, TAIL, etc.),
no warning is generated.
Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
---
.../gpu/drm/i915/gt/uc/intel_guc_capture.c | 78 ++++++++++++++++---
1 file changed, 69 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c
index d5c03e7a7843..abf6e5eb711e 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c
@@ -419,6 +419,44 @@ guc_capture_get_device_reglist(struct intel_guc *guc)
return default_lists;
}
+static const char *
+__stringify_type(u32 type)
+{
+ switch (type) {
+ case GUC_CAPTURE_LIST_TYPE_GLOBAL:
+ return "Global";
+ case GUC_CAPTURE_LIST_TYPE_ENGINE_CLASS:
+ return "Class";
+ case GUC_CAPTURE_LIST_TYPE_ENGINE_INSTANCE:
+ return "Instance";
+ default:
+ break;
+ }
+
+ return "unknown";
+}
+
+static const char *
+__stringify_engclass(u32 class)
+{
+ switch (class) {
+ case GUC_RENDER_CLASS:
+ return "Render";
+ case GUC_VIDEO_CLASS:
+ return "Video";
+ case GUC_VIDEOENHANCE_CLASS:
+ return "VideoEnhance";
+ case GUC_BLITTER_CLASS:
+ return "Blitter";
+ case GUC_COMPUTE_CLASS:
+ return "Compute";
+ default:
+ break;
+ }
+
+ return "unknown";
+}
+
static int
guc_capture_list_init(struct intel_guc *guc, u32 owner, u32 type, u32 classid,
struct guc_mmio_reg *ptr, u16 num_entries)
@@ -482,23 +520,38 @@ guc_cap_list_num_regs(struct intel_guc_state_capture *gc, u32 owner, u32 type, u
return num_regs;
}
-int
-intel_guc_capture_getlistsize(struct intel_guc *guc, u32 owner, u32 type, u32 classid,
- size_t *size)
+static int
+guc_capture_getlistsize(struct intel_guc *guc, u32 owner, u32 type, u32 classid,
+ size_t *size, bool is_purpose_est)
{
struct intel_guc_state_capture *gc = guc->capture;
+ struct drm_i915_private *i915 = guc_to_gt(guc)->i915;
struct __guc_capture_ads_cache *cache = &gc->ads_cache[owner][type][classid];
int num_regs;
- if (!gc->reglists)
+ if (!gc->reglists) {
+ drm_warn(&i915->drm, "GuC-capture: No reglist on this device\n");
return -ENODEV;
+ }
if (cache->is_valid) {
*size = cache->size;
return cache->status;
}
+ if (!is_purpose_est && owner == GUC_CAPTURE_LIST_INDEX_PF &&
+ !guc_capture_get_one_list(gc->reglists, owner, type, classid)) {
+ if (type == GUC_CAPTURE_LIST_TYPE_GLOBAL)
+ drm_warn(&i915->drm, "Missing GuC-Err-Cap reglist Global!\n");
+ else
+ drm_warn(&i915->drm, "Missing GuC-Err-Cap reglist %s(%u):%s(%u)!\n",
+ __stringify_type(type), type,
+ __stringify_engclass(classid), classid);
+ return -ENODATA;
+ }
+
num_regs = guc_cap_list_num_regs(gc, owner, type, classid);
+ /* intentional empty lists can exist depending on hw config */
if (!num_regs)
return -ENODATA;
@@ -508,6 +561,13 @@ intel_guc_capture_getlistsize(struct intel_guc *guc, u32 owner, u32 type, u32 cl
return 0;
}
+int
+intel_guc_capture_getlistsize(struct intel_guc *guc, u32 owner, u32 type, u32 classid,
+ size_t *size)
+{
+ return guc_capture_getlistsize(guc, owner, type, classid, size, false);
+}
+
static void guc_capture_create_prealloc_nodes(struct intel_guc *guc);
int
@@ -627,15 +687,15 @@ guc_capture_output_min_size_est(struct intel_guc *guc)
worst_min_size += sizeof(struct guc_state_capture_group_header_t) +
(3 * sizeof(struct guc_state_capture_header_t));
- if (!intel_guc_capture_getlistsize(guc, 0, GUC_CAPTURE_LIST_TYPE_GLOBAL, 0, &tmp))
+ if (!guc_capture_getlistsize(guc, 0, GUC_CAPTURE_LIST_TYPE_GLOBAL, 0, &tmp, true))
num_regs += tmp;
- if (!intel_guc_capture_getlistsize(guc, 0, GUC_CAPTURE_LIST_TYPE_ENGINE_CLASS,
- engine->class, &tmp)) {
+ if (!guc_capture_getlistsize(guc, 0, GUC_CAPTURE_LIST_TYPE_ENGINE_CLASS,
+ engine->class, &tmp, true)) {
num_regs += tmp;
}
- if (!intel_guc_capture_getlistsize(guc, 0, GUC_CAPTURE_LIST_TYPE_ENGINE_INSTANCE,
- engine->class, &tmp)) {
+ if (!guc_capture_getlistsize(guc, 0, GUC_CAPTURE_LIST_TYPE_ENGINE_INSTANCE,
+ engine->class, &tmp, true)) {
num_regs += tmp;
}
}
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] [PATCH v3 2/2] drm/i915/guc: Add compute reglist for guc err capture
2022-10-19 7:29 [Intel-gfx] [PATCH v3 0/2] drm/i915/guc: Add GuC-Error-Capture-Init coverage of new engine types Alan Previn
2022-10-19 7:29 ` [Intel-gfx] [PATCH v3 1/2] drm/i915/guc: Add error-capture init warnings when needed Alan Previn
@ 2022-10-19 7:29 ` Alan Previn
2022-10-21 18:49 ` John Harrison
2022-10-19 8:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Add GuC-Error-Capture-Init coverage of new engine types (rev3) Patchwork
2022-10-19 15:54 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
3 siblings, 1 reply; 8+ messages in thread
From: Alan Previn @ 2022-10-19 7:29 UTC (permalink / raw)
To: intel-gfx
We missed this at initial upstream because at that time
none of the GuC enabled platforms had a compute engine.
Add this now.
Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
---
drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c
index abf6e5eb711e..c4bee3bc15a9 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c
@@ -169,6 +169,8 @@ static struct __guc_mmio_reg_descr_group default_lists[] = {
MAKE_REGLIST(default_global_regs, PF, GLOBAL, 0),
MAKE_REGLIST(default_rc_class_regs, PF, ENGINE_CLASS, GUC_RENDER_CLASS),
MAKE_REGLIST(xe_lpd_rc_inst_regs, PF, ENGINE_INSTANCE, GUC_RENDER_CLASS),
+ MAKE_REGLIST(default_rc_class_regs, PF, ENGINE_CLASS, GUC_COMPUTE_CLASS),
+ MAKE_REGLIST(xe_lpd_rc_inst_regs, PF, ENGINE_INSTANCE, GUC_COMPUTE_CLASS),
MAKE_REGLIST(empty_regs_list, PF, ENGINE_CLASS, GUC_VIDEO_CLASS),
MAKE_REGLIST(xe_lpd_vd_inst_regs, PF, ENGINE_INSTANCE, GUC_VIDEO_CLASS),
MAKE_REGLIST(empty_regs_list, PF, ENGINE_CLASS, GUC_VIDEOENHANCE_CLASS),
@@ -182,6 +184,8 @@ static const struct __guc_mmio_reg_descr_group xe_lpd_lists[] = {
MAKE_REGLIST(xe_lpd_global_regs, PF, GLOBAL, 0),
MAKE_REGLIST(xe_lpd_rc_class_regs, PF, ENGINE_CLASS, GUC_RENDER_CLASS),
MAKE_REGLIST(xe_lpd_rc_inst_regs, PF, ENGINE_INSTANCE, GUC_RENDER_CLASS),
+ MAKE_REGLIST(xe_lpd_rc_class_regs, PF, ENGINE_CLASS, GUC_COMPUTE_CLASS),
+ MAKE_REGLIST(xe_lpd_rc_inst_regs, PF, ENGINE_INSTANCE, GUC_COMPUTE_CLASS),
MAKE_REGLIST(empty_regs_list, PF, ENGINE_CLASS, GUC_VIDEO_CLASS),
MAKE_REGLIST(xe_lpd_vd_inst_regs, PF, ENGINE_INSTANCE, GUC_VIDEO_CLASS),
MAKE_REGLIST(xe_lpd_vec_class_regs, PF, ENGINE_CLASS, GUC_VIDEOENHANCE_CLASS),
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Add GuC-Error-Capture-Init coverage of new engine types (rev3)
2022-10-19 7:29 [Intel-gfx] [PATCH v3 0/2] drm/i915/guc: Add GuC-Error-Capture-Init coverage of new engine types Alan Previn
2022-10-19 7:29 ` [Intel-gfx] [PATCH v3 1/2] drm/i915/guc: Add error-capture init warnings when needed Alan Previn
2022-10-19 7:29 ` [Intel-gfx] [PATCH v3 2/2] drm/i915/guc: Add compute reglist for guc err capture Alan Previn
@ 2022-10-19 8:53 ` Patchwork
2022-10-19 15:54 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2022-10-19 8:53 UTC (permalink / raw)
To: Alan Previn; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 8386 bytes --]
== Series Details ==
Series: drm/i915/guc: Add GuC-Error-Capture-Init coverage of new engine types (rev3)
URL : https://patchwork.freedesktop.org/series/109737/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12259 -> Patchwork_109737v3
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/index.html
Participating hosts (41 -> 41)
------------------------------
Additional (1): bat-adlm-1
Missing (1): fi-kbl-soraka
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_109737v3:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_pm_rpm@basic-rte:
- {bat-rplp-1}: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/bat-rplp-1/igt@i915_pm_rpm@basic-rte.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/bat-rplp-1/igt@i915_pm_rpm@basic-rte.html
Known issues
------------
Here are the changes found in Patchwork_109737v3 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_lmem_swapping@verify-random:
- fi-bdw-5557u: NOTRUN -> [SKIP][3] ([fdo#109271]) +13 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/fi-bdw-5557u/igt@gem_lmem_swapping@verify-random.html
* igt@gem_render_tiled_blits@basic:
- fi-apl-guc: [PASS][4] -> [INCOMPLETE][5] ([i915#7056])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/fi-apl-guc/igt@gem_render_tiled_blits@basic.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/fi-apl-guc/igt@gem_render_tiled_blits@basic.html
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [PASS][6] -> [INCOMPLETE][7] ([i915#4785])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
- fi-hsw-g3258: [PASS][8] -> [INCOMPLETE][9] ([i915#3303] / [i915#4785])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-bdw-5557u: NOTRUN -> [INCOMPLETE][10] ([i915#146] / [i915#6712])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/fi-bdw-5557u/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_chamelium@dp-edid-read:
- fi-bdw-5557u: NOTRUN -> [SKIP][11] ([fdo#109271] / [fdo#111827]) +7 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/fi-bdw-5557u/igt@kms_chamelium@dp-edid-read.html
* igt@runner@aborted:
- fi-hsw-4770: NOTRUN -> [FAIL][12] ([fdo#109271] / [i915#4312] / [i915#5594])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/fi-hsw-4770/igt@runner@aborted.html
- fi-hsw-g3258: NOTRUN -> [FAIL][13] ([fdo#109271] / [i915#4312] / [i915#4991])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/fi-hsw-g3258/igt@runner@aborted.html
#### Possible fixes ####
* igt@debugfs_test@read_all_entries:
- {fi-tgl-mst}: [DMESG-WARN][14] ([i915#6434]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/fi-tgl-mst/igt@debugfs_test@read_all_entries.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/fi-tgl-mst/igt@debugfs_test@read_all_entries.html
* igt@i915_selftest@live@gem_contexts:
- {fi-tgl-mst}: [DMESG-FAIL][16] -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/fi-tgl-mst/igt@i915_selftest@live@gem_contexts.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/fi-tgl-mst/igt@i915_selftest@live@gem_contexts.html
- {bat-jsl-1}: [DMESG-FAIL][18] -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/bat-jsl-1/igt@i915_selftest@live@gem_contexts.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/bat-jsl-1/igt@i915_selftest@live@gem_contexts.html
* igt@i915_selftest@live@requests:
- {bat-adln-1}: [DMESG-FAIL][20] -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/bat-adln-1/igt@i915_selftest@live@requests.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/bat-adln-1/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@reset:
- {bat-rpls-2}: [DMESG-FAIL][22] ([i915#4983]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/bat-rpls-2/igt@i915_selftest@live@reset.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/bat-rpls-2/igt@i915_selftest@live@reset.html
* igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-3:
- {bat-dg2-11}: [FAIL][24] ([i915#6818]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-3.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-3.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5537]: https://gitlab.freedesktop.org/drm/intel/issues/5537
[i915#5594]: https://gitlab.freedesktop.org/drm/intel/issues/5594
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6434]: https://gitlab.freedesktop.org/drm/intel/issues/6434
[i915#6503]: https://gitlab.freedesktop.org/drm/intel/issues/6503
[i915#6559]: https://gitlab.freedesktop.org/drm/intel/issues/6559
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6712]: https://gitlab.freedesktop.org/drm/intel/issues/6712
[i915#6818]: https://gitlab.freedesktop.org/drm/intel/issues/6818
[i915#7056]: https://gitlab.freedesktop.org/drm/intel/issues/7056
Build changes
-------------
* Linux: CI_DRM_12259 -> Patchwork_109737v3
CI-20190529: 20190529
CI_DRM_12259: af4d5174f9efe29241ffa082a7417fde95ca2f28 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7019: fdbafce2b74e84739bb1d81223ae6f01fb442980 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109737v3: af4d5174f9efe29241ffa082a7417fde95ca2f28 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
8ec77cd5e822 drm/i915/guc: Add compute reglist for guc err capture
07eedddd30da drm/i915/guc: Add error-capture init warnings when needed
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/index.html
[-- Attachment #2: Type: text/html, Size: 8539 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: Add GuC-Error-Capture-Init coverage of new engine types (rev3)
2022-10-19 7:29 [Intel-gfx] [PATCH v3 0/2] drm/i915/guc: Add GuC-Error-Capture-Init coverage of new engine types Alan Previn
` (2 preceding siblings ...)
2022-10-19 8:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Add GuC-Error-Capture-Init coverage of new engine types (rev3) Patchwork
@ 2022-10-19 15:54 ` Patchwork
2022-10-24 20:25 ` Teres Alexis, Alan Previn
3 siblings, 1 reply; 8+ messages in thread
From: Patchwork @ 2022-10-19 15:54 UTC (permalink / raw)
To: Alan Previn; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 31238 bytes --]
== Series Details ==
Series: drm/i915/guc: Add GuC-Error-Capture-Init coverage of new engine types (rev3)
URL : https://patchwork.freedesktop.org/series/109737/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12259_full -> Patchwork_109737v3_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_109737v3_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_109737v3_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (9 -> 11)
------------------------------
Additional (2): shard-rkl shard-dg1
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_109737v3_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-tglb3/igt@i915_suspend@fence-restore-tiled2untiled.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-tglb3/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_plane_lowres@tiling-none@pipe-c-hdmi-a-2:
- shard-glk: [PASS][3] -> [FAIL][4] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-glk3/igt@kms_plane_lowres@tiling-none@pipe-c-hdmi-a-2.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-glk5/igt@kms_plane_lowres@tiling-none@pipe-c-hdmi-a-2.html
#### Warnings ####
* igt@gem_pwrite@basic-exhaustion:
- shard-glk: [WARN][5] ([i915#2658]) -> [INCOMPLETE][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-glk9/igt@gem_pwrite@basic-exhaustion.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-glk8/igt@gem_pwrite@basic-exhaustion.html
* igt@runner@aborted:
- shard-skl: ([FAIL][7], [FAIL][8], [FAIL][9], [FAIL][10], [FAIL][11], [FAIL][12], [FAIL][13], [FAIL][14]) ([i915#3002] / [i915#4312] / [i915#6949]) -> ([FAIL][15], [FAIL][16], [FAIL][17], [FAIL][18], [FAIL][19]) ([i915#4312])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-skl4/igt@runner@aborted.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-skl4/igt@runner@aborted.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-skl7/igt@runner@aborted.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-skl5/igt@runner@aborted.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-skl2/igt@runner@aborted.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-skl9/igt@runner@aborted.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-skl9/igt@runner@aborted.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-skl1/igt@runner@aborted.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl4/igt@runner@aborted.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl6/igt@runner@aborted.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl10/igt@runner@aborted.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl1/igt@runner@aborted.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl1/igt@runner@aborted.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_eio@in-flight-suspend:
- {shard-dg1}: NOTRUN -> [INCOMPLETE][20]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-dg1-17/igt@gem_eio@in-flight-suspend.html
* igt@i915_selftest@mock@requests:
- {shard-rkl}: NOTRUN -> [DMESG-FAIL][21]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-rkl-1/igt@i915_selftest@mock@requests.html
Known issues
------------
Here are the changes found in Patchwork_109737v3_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_balancer@parallel-balancer:
- shard-iclb: [PASS][22] -> [SKIP][23] ([i915#4525])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-iclb1/igt@gem_exec_balancer@parallel-balancer.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-iclb5/igt@gem_exec_balancer@parallel-balancer.html
* igt@gem_exec_fair@basic-none@bcs0:
- shard-iclb: [PASS][24] -> [FAIL][25] ([i915#2842])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-iclb3/igt@gem_exec_fair@basic-none@bcs0.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-iclb3/igt@gem_exec_fair@basic-none@bcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [PASS][26] -> [FAIL][27] ([i915#2842])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-glk5/igt@gem_exec_fair@basic-throttle@rcs0.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-glk9/igt@gem_exec_fair@basic-throttle@rcs0.html
- shard-tglb: [PASS][28] -> [FAIL][29] ([i915#2842])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-tglb7/igt@gem_exec_fair@basic-throttle@rcs0.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-tglb7/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_lmem_swapping@basic:
- shard-skl: NOTRUN -> [SKIP][30] ([fdo#109271] / [i915#4613]) +2 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl9/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@smem-oom:
- shard-apl: NOTRUN -> [SKIP][31] ([fdo#109271] / [i915#4613]) +3 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-apl6/igt@gem_lmem_swapping@smem-oom.html
* igt@gem_tiled_wb:
- shard-skl: NOTRUN -> [TIMEOUT][32] ([i915#6990] / [i915#7065])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl1/igt@gem_tiled_wb.html
* igt@gem_userptr_blits@probe:
- shard-skl: NOTRUN -> [FAIL][33] ([i915#7224])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl1/igt@gem_userptr_blits@probe.html
* igt@gem_userptr_blits@unsync-overlap:
- shard-skl: NOTRUN -> [SKIP][34] ([fdo#109271]) +269 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl1/igt@gem_userptr_blits@unsync-overlap.html
* igt@i915_pipe_stress@stress-xrgb8888-ytiled:
- shard-apl: NOTRUN -> [FAIL][35] ([i915#7036])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-apl6/igt@i915_pipe_stress@stress-xrgb8888-ytiled.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][36] -> [FAIL][37] ([i915#3989] / [i915#454])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-iclb1/igt@i915_pm_dc@dc6-psr.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-iclb3/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_rps@engine-order:
- shard-apl: [PASS][38] -> [FAIL][39] ([i915#6537])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-apl6/igt@i915_pm_rps@engine-order.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-apl3/igt@i915_pm_rps@engine-order.html
* igt@i915_pm_sseu@full-enable:
- shard-skl: [PASS][40] -> [FAIL][41] ([i915#6991])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-skl7/igt@i915_pm_sseu@full-enable.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl4/igt@i915_pm_sseu@full-enable.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][42] ([i915#3763])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl7/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#3886]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-glk8/igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#3886]) +8 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl9/igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#3886]) +4 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-apl3/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_chamelium@common-hpd-after-suspend:
- shard-glk: NOTRUN -> [SKIP][46] ([fdo#109271] / [fdo#111827])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-glk8/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@hdmi-audio:
- shard-apl: NOTRUN -> [SKIP][47] ([fdo#109271] / [fdo#111827]) +5 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-apl3/igt@kms_chamelium@hdmi-audio.html
* igt@kms_chamelium@hdmi-crc-multiple:
- shard-skl: NOTRUN -> [SKIP][48] ([fdo#109271] / [fdo#111827]) +12 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl9/igt@kms_chamelium@hdmi-crc-multiple.html
* igt@kms_content_protection@atomic-dpms@pipe-a-dp-1:
- shard-apl: NOTRUN -> [INCOMPLETE][49] ([i915#7121] / [i915#7173])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-apl6/igt@kms_content_protection@atomic-dpms@pipe-a-dp-1.html
* igt@kms_cursor_crc@cursor-suspend@pipe-a-dp-1:
- shard-apl: [PASS][50] -> [DMESG-WARN][51] ([i915#180]) +3 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-apl6/igt@kms_cursor_crc@cursor-suspend@pipe-a-dp-1.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-apl3/igt@kms_cursor_crc@cursor-suspend@pipe-a-dp-1.html
* igt@kms_flip@2x-nonexisting-fb:
- shard-apl: NOTRUN -> [SKIP][52] ([fdo#109271]) +88 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-apl6/igt@kms_flip@2x-nonexisting-fb.html
* igt@kms_flip@flip-vs-expired-vblank@c-edp1:
- shard-skl: [PASS][53] -> [FAIL][54] ([i915#79]) +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-skl9/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl10/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-16bpp-yftile-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][55] ([i915#2672]) +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-16bpp-yftile-upscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][56] ([i915#2587] / [i915#2672])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-iclb6/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][57] ([i915#2672] / [i915#3555])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-iclb1/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode.html
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-glk: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#658])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-glk8/igt@kms_psr2_su@frontbuffer-xrgb8888.html
* igt@kms_psr2_su@page_flip-nv12:
- shard-iclb: NOTRUN -> [SKIP][59] ([fdo#109642] / [fdo#111068] / [i915#658])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-iclb1/igt@kms_psr2_su@page_flip-nv12.html
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-skl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#658]) +5 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl9/igt@kms_psr2_su@page_flip-xrgb8888.html
- shard-apl: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#658])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-apl3/igt@kms_psr2_su@page_flip-xrgb8888.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [PASS][62] -> [SKIP][63] ([fdo#109441]) +1 similar issue
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-iclb1/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_vblank@pipe-d-wait-busy:
- shard-glk: NOTRUN -> [SKIP][64] ([fdo#109271]) +20 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-glk8/igt@kms_vblank@pipe-d-wait-busy.html
* igt@kms_writeback@writeback-pixel-formats:
- shard-skl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#2437])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl1/igt@kms_writeback@writeback-pixel-formats.html
* igt@perf@non-zero-reason:
- shard-skl: NOTRUN -> [TIMEOUT][66] ([i915#6943] / [i915#7065])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl9/igt@perf@non-zero-reason.html
* igt@sysfs_clients@sema-50:
- shard-apl: NOTRUN -> [SKIP][67] ([fdo#109271] / [i915#2994]) +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-apl6/igt@sysfs_clients@sema-50.html
* igt@sysfs_clients@split-50:
- shard-skl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#2994])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl1/igt@sysfs_clients@split-50.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3@smem:
- shard-apl: [DMESG-WARN][69] ([i915#180]) -> [PASS][70] +3 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-apl6/igt@gem_exec_suspend@basic-s3@smem.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-apl6/igt@gem_exec_suspend@basic-s3@smem.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-tglb: [FAIL][71] ([i915#3743]) -> [PASS][72] +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-tglb5/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-tglb2/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [FAIL][73] ([i915#79]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-skl9/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl10/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [SKIP][75] ([i915#5235]) -> [PASS][76] +2 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-iclb2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-iclb1/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][77] ([fdo#109441]) -> [PASS][78] +3 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-iclb5/igt@kms_psr@psr2_primary_mmap_cpu.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@perf@short-reads:
- shard-skl: [FAIL][79] ([i915#51]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-skl4/igt@perf@short-reads.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl1/igt@perf@short-reads.html
#### Warnings ####
* igt@gem_pwrite@basic-exhaustion:
- shard-tglb: [INCOMPLETE][81] ([i915#7248]) -> [WARN][82] ([i915#2658])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-tglb7/igt@gem_pwrite@basic-exhaustion.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-tglb5/igt@gem_pwrite@basic-exhaustion.html
- shard-skl: [TIMEOUT][83] ([i915#7275]) -> [INCOMPLETE][84] ([i915#7248])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-skl2/igt@gem_pwrite@basic-exhaustion.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl10/igt@gem_pwrite@basic-exhaustion.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf:
- shard-iclb: [SKIP][85] ([i915#658]) -> [SKIP][86] ([i915#2920])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-iclb5/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-iclb2/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2435]: https://gitlab.freedesktop.org/drm/intel/issues/2435
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2532]: https://gitlab.freedesktop.org/drm/intel/issues/2532
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3763]: https://gitlab.freedesktop.org/drm/intel/issues/3763
[i915#3810]: https://gitlab.freedesktop.org/drm/intel/issues/3810
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3936]: https://gitlab.freedesktop.org/drm/intel/issues/3936
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4036]: https://gitlab.freedesktop.org/drm/intel/issues/4036
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4855]: https://gitlab.freedesktop.org/drm/intel/issues/4855
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4874]: https://gitlab.freedesktop.org/drm/intel/issues/4874
[i915#4877]: https://gitlab.freedesktop.org/drm/intel/issues/4877
[i915#4879]: https://gitlab.freedesktop.org/drm/intel/issues/4879
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#4884]: https://gitlab.freedesktop.org/drm/intel/issues/4884
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#4958]: https://gitlab.freedesktop.org/drm/intel/issues/4958
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#51]: https://gitlab.freedesktop.org/drm/intel/issues/51
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6259]: https://gitlab.freedesktop.org/drm/intel/issues/6259
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6463]: https://gitlab.freedesktop.org/drm/intel/issues/6463
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#6537]: https://gitlab.freedesktop.org/drm/intel/issues/6537
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6943]: https://gitlab.freedesktop.org/drm/intel/issues/6943
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6949]: https://gitlab.freedesktop.org/drm/intel/issues/6949
[i915#6990]: https://gitlab.freedesktop.org/drm/intel/issues/6990
[i915#6991]: https://gitlab.freedesktop.org/drm/intel/issues/6991
[i915#7036]: https://gitlab.freedesktop.org/drm/intel/issues/7036
[i915#7065]: https://gitlab.freedesktop.org/drm/intel/issues/7065
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7121]: https://gitlab.freedesktop.org/drm/intel/issues/7121
[i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
[i915#7178]: https://gitlab.freedesktop.org/drm/intel/issues/7178
[i915#7224]: https://gitlab.freedesktop.org/drm/intel/issues/7224
[i915#7247]: https://gitlab.freedesktop.org/drm/intel/issues/7247
[i915#7248]: https://gitlab.freedesktop.org/drm/intel/issues/7248
[i915#7267]: https://gitlab.freedesktop.org/drm/intel/issues/7267
[i915#7275]: https://gitlab.freedesktop.org/drm/intel/issues/7275
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12259 -> Patchwork_109737v3
CI-20190529: 20190529
CI_DRM_12259: af4d5174f9efe29241ffa082a7417fde95ca2f28 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7019: fdbafce2b74e84739bb1d81223ae6f01fb442980 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109737v3: af4d5174f9efe29241ffa082a7417fde95ca2f28 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/index.html
[-- Attachment #2: Type: text/html, Size: 26407 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/guc: Add compute reglist for guc err capture
2022-10-19 7:29 ` [Intel-gfx] [PATCH v3 2/2] drm/i915/guc: Add compute reglist for guc err capture Alan Previn
@ 2022-10-21 18:49 ` John Harrison
0 siblings, 0 replies; 8+ messages in thread
From: John Harrison @ 2022-10-21 18:49 UTC (permalink / raw)
To: Alan Previn, intel-gfx
On 10/19/2022 00:29, Alan Previn wrote:
> We missed this at initial upstream because at that time
> none of the GuC enabled platforms had a compute engine.
> Add this now.
>
> Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
Reviewed-by: John Harrison <John.C.Harrison@Intel.com>
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c
> index abf6e5eb711e..c4bee3bc15a9 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c
> @@ -169,6 +169,8 @@ static struct __guc_mmio_reg_descr_group default_lists[] = {
> MAKE_REGLIST(default_global_regs, PF, GLOBAL, 0),
> MAKE_REGLIST(default_rc_class_regs, PF, ENGINE_CLASS, GUC_RENDER_CLASS),
> MAKE_REGLIST(xe_lpd_rc_inst_regs, PF, ENGINE_INSTANCE, GUC_RENDER_CLASS),
> + MAKE_REGLIST(default_rc_class_regs, PF, ENGINE_CLASS, GUC_COMPUTE_CLASS),
> + MAKE_REGLIST(xe_lpd_rc_inst_regs, PF, ENGINE_INSTANCE, GUC_COMPUTE_CLASS),
> MAKE_REGLIST(empty_regs_list, PF, ENGINE_CLASS, GUC_VIDEO_CLASS),
> MAKE_REGLIST(xe_lpd_vd_inst_regs, PF, ENGINE_INSTANCE, GUC_VIDEO_CLASS),
> MAKE_REGLIST(empty_regs_list, PF, ENGINE_CLASS, GUC_VIDEOENHANCE_CLASS),
> @@ -182,6 +184,8 @@ static const struct __guc_mmio_reg_descr_group xe_lpd_lists[] = {
> MAKE_REGLIST(xe_lpd_global_regs, PF, GLOBAL, 0),
> MAKE_REGLIST(xe_lpd_rc_class_regs, PF, ENGINE_CLASS, GUC_RENDER_CLASS),
> MAKE_REGLIST(xe_lpd_rc_inst_regs, PF, ENGINE_INSTANCE, GUC_RENDER_CLASS),
> + MAKE_REGLIST(xe_lpd_rc_class_regs, PF, ENGINE_CLASS, GUC_COMPUTE_CLASS),
> + MAKE_REGLIST(xe_lpd_rc_inst_regs, PF, ENGINE_INSTANCE, GUC_COMPUTE_CLASS),
> MAKE_REGLIST(empty_regs_list, PF, ENGINE_CLASS, GUC_VIDEO_CLASS),
> MAKE_REGLIST(xe_lpd_vd_inst_regs, PF, ENGINE_INSTANCE, GUC_VIDEO_CLASS),
> MAKE_REGLIST(xe_lpd_vec_class_regs, PF, ENGINE_CLASS, GUC_VIDEOENHANCE_CLASS),
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH v3 1/2] drm/i915/guc: Add error-capture init warnings when needed
2022-10-19 7:29 ` [Intel-gfx] [PATCH v3 1/2] drm/i915/guc: Add error-capture init warnings when needed Alan Previn
@ 2022-10-21 19:42 ` John Harrison
0 siblings, 0 replies; 8+ messages in thread
From: John Harrison @ 2022-10-21 19:42 UTC (permalink / raw)
To: intel-gfx
On 10/19/2022 00:29, Alan Previn wrote:
> If GuC is being used and we initialized GuC-error-capture,
> we need to be warning if we don't provide an error-capture
> register list in the firmware ADS, for valid GT engines.
> A warning makes sense as this would impact debugability
> without realizing why a reglist wasn't retrieved and reported
> by GuC.
>
> However, depending on the platform, we might have certain
> engines that have a register list for engine instance error state
> but not for engine class. Thus, add a check only to warn if the
> register list was non existent vs an empty list (use the
> empty lists to skip the warning).
>
> NOTE: if a future platform were to introduce new registers
> in place of what was an empty list on existing / legacy hardware
> engines no warning is provided as the empty list is meant
> to be used intentionally. As an example, if a future hardware
> were to add blitter engine-class-registers (new) on top
> of the legacy blitter engine-instance-register (HEAD, TAIL, etc.),
> no warning is generated.
>
> Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
Reviewed-by: John Harrison <John.C.Harrison@Intel.com>
> ---
> .../gpu/drm/i915/gt/uc/intel_guc_capture.c | 78 ++++++++++++++++---
> 1 file changed, 69 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c
> index d5c03e7a7843..abf6e5eb711e 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c
> @@ -419,6 +419,44 @@ guc_capture_get_device_reglist(struct intel_guc *guc)
> return default_lists;
> }
>
> +static const char *
> +__stringify_type(u32 type)
> +{
> + switch (type) {
> + case GUC_CAPTURE_LIST_TYPE_GLOBAL:
> + return "Global";
> + case GUC_CAPTURE_LIST_TYPE_ENGINE_CLASS:
> + return "Class";
> + case GUC_CAPTURE_LIST_TYPE_ENGINE_INSTANCE:
> + return "Instance";
> + default:
> + break;
> + }
> +
> + return "unknown";
> +}
> +
> +static const char *
> +__stringify_engclass(u32 class)
> +{
> + switch (class) {
> + case GUC_RENDER_CLASS:
> + return "Render";
> + case GUC_VIDEO_CLASS:
> + return "Video";
> + case GUC_VIDEOENHANCE_CLASS:
> + return "VideoEnhance";
> + case GUC_BLITTER_CLASS:
> + return "Blitter";
> + case GUC_COMPUTE_CLASS:
> + return "Compute";
> + default:
> + break;
> + }
> +
> + return "unknown";
> +}
> +
> static int
> guc_capture_list_init(struct intel_guc *guc, u32 owner, u32 type, u32 classid,
> struct guc_mmio_reg *ptr, u16 num_entries)
> @@ -482,23 +520,38 @@ guc_cap_list_num_regs(struct intel_guc_state_capture *gc, u32 owner, u32 type, u
> return num_regs;
> }
>
> -int
> -intel_guc_capture_getlistsize(struct intel_guc *guc, u32 owner, u32 type, u32 classid,
> - size_t *size)
> +static int
> +guc_capture_getlistsize(struct intel_guc *guc, u32 owner, u32 type, u32 classid,
> + size_t *size, bool is_purpose_est)
> {
> struct intel_guc_state_capture *gc = guc->capture;
> + struct drm_i915_private *i915 = guc_to_gt(guc)->i915;
> struct __guc_capture_ads_cache *cache = &gc->ads_cache[owner][type][classid];
> int num_regs;
>
> - if (!gc->reglists)
> + if (!gc->reglists) {
> + drm_warn(&i915->drm, "GuC-capture: No reglist on this device\n");
> return -ENODEV;
> + }
>
> if (cache->is_valid) {
> *size = cache->size;
> return cache->status;
> }
>
> + if (!is_purpose_est && owner == GUC_CAPTURE_LIST_INDEX_PF &&
> + !guc_capture_get_one_list(gc->reglists, owner, type, classid)) {
> + if (type == GUC_CAPTURE_LIST_TYPE_GLOBAL)
> + drm_warn(&i915->drm, "Missing GuC-Err-Cap reglist Global!\n");
> + else
> + drm_warn(&i915->drm, "Missing GuC-Err-Cap reglist %s(%u):%s(%u)!\n",
> + __stringify_type(type), type,
> + __stringify_engclass(classid), classid);
> + return -ENODATA;
> + }
> +
> num_regs = guc_cap_list_num_regs(gc, owner, type, classid);
> + /* intentional empty lists can exist depending on hw config */
> if (!num_regs)
> return -ENODATA;
>
> @@ -508,6 +561,13 @@ intel_guc_capture_getlistsize(struct intel_guc *guc, u32 owner, u32 type, u32 cl
> return 0;
> }
>
> +int
> +intel_guc_capture_getlistsize(struct intel_guc *guc, u32 owner, u32 type, u32 classid,
> + size_t *size)
> +{
> + return guc_capture_getlistsize(guc, owner, type, classid, size, false);
> +}
> +
> static void guc_capture_create_prealloc_nodes(struct intel_guc *guc);
>
> int
> @@ -627,15 +687,15 @@ guc_capture_output_min_size_est(struct intel_guc *guc)
> worst_min_size += sizeof(struct guc_state_capture_group_header_t) +
> (3 * sizeof(struct guc_state_capture_header_t));
>
> - if (!intel_guc_capture_getlistsize(guc, 0, GUC_CAPTURE_LIST_TYPE_GLOBAL, 0, &tmp))
> + if (!guc_capture_getlistsize(guc, 0, GUC_CAPTURE_LIST_TYPE_GLOBAL, 0, &tmp, true))
> num_regs += tmp;
>
> - if (!intel_guc_capture_getlistsize(guc, 0, GUC_CAPTURE_LIST_TYPE_ENGINE_CLASS,
> - engine->class, &tmp)) {
> + if (!guc_capture_getlistsize(guc, 0, GUC_CAPTURE_LIST_TYPE_ENGINE_CLASS,
> + engine->class, &tmp, true)) {
> num_regs += tmp;
> }
> - if (!intel_guc_capture_getlistsize(guc, 0, GUC_CAPTURE_LIST_TYPE_ENGINE_INSTANCE,
> - engine->class, &tmp)) {
> + if (!guc_capture_getlistsize(guc, 0, GUC_CAPTURE_LIST_TYPE_ENGINE_INSTANCE,
> + engine->class, &tmp, true)) {
> num_regs += tmp;
> }
> }
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: Add GuC-Error-Capture-Init coverage of new engine types (rev3)
2022-10-19 15:54 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2022-10-24 20:25 ` Teres Alexis, Alan Previn
0 siblings, 0 replies; 8+ messages in thread
From: Teres Alexis, Alan Previn @ 2022-10-24 20:25 UTC (permalink / raw)
To: intel-gfx@lists.freedesktop.org
[-- Attachment #1: Type: text/plain, Size: 4069 bytes --]
I believe that the issues below are not related to this series because they were running on platforms that do not use guc-submission. Additionally, both patches of this series impact steps very early in the guc initialization phase and never again - and do not impact runtime operation of display. That said, an issue if resulting from this series were to occur, it would be noticed very early in the i915 loading process.
...alan
On Wed, 2022-10-19 at 15:54 +0000, Patchwork wrote:
Patch Details
Series: drm/i915/guc: Add GuC-Error-Capture-Init coverage of new engine types (rev3)
URL: https://patchwork.freedesktop.org/series/109737/
State: failure
Details: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/index.html
CI Bug Log - changes from CI_DRM_12259_full -> Patchwork_109737v3_full
Summary
FAILURE
Serious unknown changes coming with Patchwork_109737v3_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_109737v3_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (9 -> 11)
Additional (2): shard-rkl shard-dg1
Possible new issues
Here are the unknown changes that may have been introduced in Patchwork_109737v3_full:
IGT changes
Possible regressions
* igt@i915_suspend@fence-restore-tiled2untiled:
* shard-tglb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-tglb3/igt@i915_suspend@fence-restore-tiled2untiled.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-tglb3/igt@i915_suspend@fence-restore-tiled2untiled.html>
* igt@kms_plane_lowres@tiling-none@pipe-c-hdmi-a-2:
* shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-glk3/igt@kms_plane_lowres@tiling-none@pipe-c-hdmi-a-2.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-glk5/igt@kms_plane_lowres@tiling-none@pipe-c-hdmi-a-2.html> +1 similar issue
Warnings
* igt@gem_pwrite@basic-exhaustion:
* shard-glk: WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-glk9/igt@gem_pwrite@basic-exhaustion.html> (i915#2658<https://gitlab.freedesktop.org/drm/intel/issues/2658>) ->INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-glk8/igt@gem_pwrite@basic-exhaustion.html>
* igt@runner@aborted:
* shard-skl: (FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-skl4/igt@runner@aborted.html>,FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-skl4/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-skl7/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-skl5/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-skl2/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-skl9/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-skl9/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-skl1/igt@runner@aborted.html>) (i915#3002<https://gitlab.freedesktop.org/drm/intel/issues/3002> /i915#4312<https://gitlab.freedesktop.org/drm/intel/issues/4312> / i915#6949<https://gitlab.freedesktop.org/drm/intel/issues/6949>) -> (FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl4/igt@runner@aborted.html>,FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl6/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl10/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl1/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl1/igt@runner@aborted.html>) (i915#4312<https://gitlab.freedesktop.org/drm/intel/issues/4312>)
[-- Attachment #2: Type: text/html, Size: 5482 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-10-24 20:25 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-19 7:29 [Intel-gfx] [PATCH v3 0/2] drm/i915/guc: Add GuC-Error-Capture-Init coverage of new engine types Alan Previn
2022-10-19 7:29 ` [Intel-gfx] [PATCH v3 1/2] drm/i915/guc: Add error-capture init warnings when needed Alan Previn
2022-10-21 19:42 ` John Harrison
2022-10-19 7:29 ` [Intel-gfx] [PATCH v3 2/2] drm/i915/guc: Add compute reglist for guc err capture Alan Previn
2022-10-21 18:49 ` John Harrison
2022-10-19 8:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Add GuC-Error-Capture-Init coverage of new engine types (rev3) Patchwork
2022-10-19 15:54 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-10-24 20:25 ` Teres Alexis, Alan Previn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox