From: Keith Packard <keithp@keithp.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: limit PM related interrupt enable to those we handle
Date: Tue, 09 Aug 2011 10:02:54 -0700 [thread overview]
Message-ID: <yun4o1q8qm9.fsf@aiko.keithp.com> (raw)
In-Reply-To: <1312907360-2469-1-git-send-email-jbarnes@virtuousgeek.org>
[-- Attachment #1.1: Type: text/plain, Size: 713 bytes --]
On Tue, 9 Aug 2011 09:29:20 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> - I915_WRITE(GEN6_PMIMR, 0);
> + I915_WRITE(GEN6_PMIMR, ~GEN6_PM_DEFERRED_EVENTS);
> spin_unlock_irq(&dev_priv->rps_lock);
> - /* enable all PM interrupts */
> - I915_WRITE(GEN6_PMINTRMSK, 0);
> + /* Enable only those we respond to in the deferred work handler */
> + I915_WRITE(GEN6_PMINTRMSK, GEN6_PMINTR_DEFERRED_EVENTS);
I think this is supposed to only enable the DEFERRED_EVENTS, right? In
which case, I think you want to invert that (as 0 enables and 1 disables):
+ I915_WRITE(GEN6_PMINTRMSK, ~GEN6_PMINTR_DEFERRED_EVENTS);
just like you did for the PMIMR register?
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2011-08-09 17:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 16:29 [PATCH] drm/i915: limit PM related interrupt enable to those we handle Jesse Barnes
2011-08-09 17:02 ` Keith Packard [this message]
2011-08-09 17:11 ` Jesse Barnes
-- strict thread matches above, loose matches on Subject: below --
2011-08-11 20:24 Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yun4o1q8qm9.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox