[Intel-wired-lan] [PATCH net v1 0/2] igc: Fix Pause Frame Advertising

[Intel-wired-lan] [PATCH net v1 0/2] igc: Fix Pause Frame Advertising

[Muhammad Husaini Zulkifli]

Hi,

Kindly help to review below patches.

Summary of each patches as per below:
Patch 1: To fix "Advertised pause frame use" advertising when tx and rx are in off state with AutoNegotiate off.
Patch 2: To fix "Supported pause frame use" output via ethtool where the bit is not set.

Tested with Intel? Ethernet Controller I225(Rev4).

Thanks.

Muhammad Husaini Zulkifli (2):
  igc: Fix Pause Frame Advertising
  igc: Fix Supported Pause Frame Link Setting

 drivers/net/ethernet/intel/igc/igc_ethtool.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

--
2.17.1

[Intel-wired-lan] [PATCH net v1 1/2] igc: Fix Pause Frame Advertising

[Muhammad Husaini Zulkifli]

Fix Pause Frame Advertising when getting the advertisement via ethtool.
Remove setting the "advertising" bit in link_ksettings during default
case when tx and rx are in off state with Auto Negotiatiate off.

Below is the original output of advertisement link during tx and rx off:
Advertised pause frame use: Symmetric Receive-only

Expected output:
Advertised pause frame use: No

Fixes: 8c5ad0dae93c ("igc: Add ethtool support")
Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
Reviewed-by: Malli C <mallikarjuna.chilakala@intel.com>
---
 drivers/net/ethernet/intel/igc/igc_ethtool.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
index 824a6c454bca..67a4aed45fc2 100644
--- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
+++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
@@ -1725,9 +1725,7 @@ static int igc_ethtool_get_link_ksettings(struct net_device *netdev,
 						     Asym_Pause);
 		break;
 	default:
-		ethtool_link_ksettings_add_link_mode(cmd, advertising, Pause);
-		ethtool_link_ksettings_add_link_mode(cmd, advertising,
-						     Asym_Pause);
+		break;
 	}
 
 	status = pm_runtime_suspended(&adapter->pdev->dev) ?
-- 
2.17.1

[Intel-wired-lan] [PATCH net v1 2/2] igc: Fix Supported Pause Frame Link Setting

[Muhammad Husaini Zulkifli]

The Supported Pause Frame always display "No" eventhough the Advertised
pause frame showing the correct setting based on the pause parameters via
ethtool. Set bit in link_ksettings to "Supported" for Pause Frame.

Before output:
Supported pause frame use: No

Expected output:
Supported pause frame use: Symmetric

Fixes: 8c5ad0dae93c ("igc: Add ethtool support")
Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
Reviewed-by: Malli C <mallikarjuna.chilakala@intel.com>
---
 drivers/net/ethernet/intel/igc/igc_ethtool.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
index 67a4aed45fc2..8722294ab90c 100644
--- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
+++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
@@ -1711,6 +1711,9 @@ static int igc_ethtool_get_link_ksettings(struct net_device *netdev,
 						     Autoneg);
 	}
 
+	/* Set pause flow control settings */
+	ethtool_link_ksettings_add_link_mode(cmd, supported, Pause);
+
 	switch (hw->fc.requested_mode) {
 	case igc_fc_full:
 		ethtool_link_ksettings_add_link_mode(cmd, advertising, Pause);
-- 
2.17.1

[Intel-wired-lan] [PATCH net v1 1/2] igc: Fix Pause Frame Advertising

[Neftin, Sasha]

On 2/19/2021 18:36, Muhammad Husaini Zulkifli wrote:
> Fix Pause Frame Advertising when getting the advertisement via ethtool.
> Remove setting the "advertising" bit in link_ksettings during default
> case when tx and rx are in off state with Auto Negotiatiate off.
> 
> Below is the original output of advertisement link during tx and rx off:
> Advertised pause frame use: Symmetric Receive-only
> 
> Expected output:
> Advertised pause frame use: No
> 
> Fixes: 8c5ad0dae93c ("igc: Add ethtool support")
> Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
> Reviewed-by: Malli C <mallikarjuna.chilakala@intel.com>
> ---
>   drivers/net/ethernet/intel/igc/igc_ethtool.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> index 824a6c454bca..67a4aed45fc2 100644
> --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
> +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> @@ -1725,9 +1725,7 @@ static int igc_ethtool_get_link_ksettings(struct net_device *netdev,
>   						     Asym_Pause);
>   		break;
>   	default:
> -		ethtool_link_ksettings_add_link_mode(cmd, advertising, Pause);
> -		ethtool_link_ksettings_add_link_mode(cmd, advertising,
> -						     Asym_Pause);
> +		break;
>   	}
>   
>   	status = pm_runtime_suspended(&adapter->pdev->dev) ?
> 
Acked-by: Sasha Neftin <sasha.neftin@intel.com>

[Intel-wired-lan] [PATCH net v1 0/2] igc: Fix Pause Frame Advertising

[Dvora Fuxbrumer]

On 19/02/2021 18:36, Muhammad Husaini Zulkifli wrote:
> Hi,
> 
> Kindly help to review below patches.
> 
> Summary of each patches as per below:
> Patch 1: To fix "Advertised pause frame use" advertising when tx and rx are in off state with AutoNegotiate off.
> Patch 2: To fix "Supported pause frame use" output via ethtool where the bit is not set.
> 
> Tested with Intel? Ethernet Controller I225(Rev4).
> 
> Thanks.
> 
> Muhammad Husaini Zulkifli (2):
>    igc: Fix Pause Frame Advertising
>    igc: Fix Supported Pause Frame Link Setting
> 
>   drivers/net/ethernet/intel/igc/igc_ethtool.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> --
> 2.17.1
> 
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan at osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
> 
Tested-by: Dvora Fuxbrumer <dvorax.fuxbrumer@linux.intel.com>

[Intel-wired-lan] [PATCH net v1 1/2] igc: Fix Pause Frame Advertising

[Dvora Fuxbrumer]

On 19/02/2021 18:36, Muhammad Husaini Zulkifli wrote:
> Fix Pause Frame Advertising when getting the advertisement via ethtool.
> Remove setting the "advertising" bit in link_ksettings during default
> case when tx and rx are in off state with Auto Negotiatiate off.
> 
> Below is the original output of advertisement link during tx and rx off:
> Advertised pause frame use: Symmetric Receive-only
> 
> Expected output:
> Advertised pause frame use: No
> 
> Fixes: 8c5ad0dae93c ("igc: Add ethtool support")
> Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
> Reviewed-by: Malli C <mallikarjuna.chilakala@intel.com>
> ---
>   drivers/net/ethernet/intel/igc/igc_ethtool.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> index 824a6c454bca..67a4aed45fc2 100644
> --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
> +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> @@ -1725,9 +1725,7 @@ static int igc_ethtool_get_link_ksettings(struct net_device *netdev,
>   						     Asym_Pause);
>   		break;
>   	default:
> -		ethtool_link_ksettings_add_link_mode(cmd, advertising, Pause);
> -		ethtool_link_ksettings_add_link_mode(cmd, advertising,
> -						     Asym_Pause);
> +		break;
>   	}
>   
>   	status = pm_runtime_suspended(&adapter->pdev->dev) ?
> 
Tested-by: Dvora Fuxbrumer <dvorax.fuxbrumer@linux.intel.com>

[Intel-wired-lan] [PATCH net v1 2/2] igc: Fix Supported Pause Frame Link Setting

[Dvora Fuxbrumer]

On 19/02/2021 18:36, Muhammad Husaini Zulkifli wrote:
> The Supported Pause Frame always display "No" eventhough the Advertised
> pause frame showing the correct setting based on the pause parameters via
> ethtool. Set bit in link_ksettings to "Supported" for Pause Frame.
> 
> Before output:
> Supported pause frame use: No
> 
> Expected output:
> Supported pause frame use: Symmetric
> 
> Fixes: 8c5ad0dae93c ("igc: Add ethtool support")
> Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
> Reviewed-by: Malli C <mallikarjuna.chilakala@intel.com>
> ---
>   drivers/net/ethernet/intel/igc/igc_ethtool.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> index 67a4aed45fc2..8722294ab90c 100644
> --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
> +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> @@ -1711,6 +1711,9 @@ static int igc_ethtool_get_link_ksettings(struct net_device *netdev,
>   						     Autoneg);
>   	}
>   
> +	/* Set pause flow control settings */
> +	ethtool_link_ksettings_add_link_mode(cmd, supported, Pause);
> +
>   	switch (hw->fc.requested_mode) {
>   	case igc_fc_full:
>   		ethtool_link_ksettings_add_link_mode(cmd, advertising, Pause);
> 
Tested-by: Dvora Fuxbrumer <dvorax.fuxbrumer@linux.intel.com>

[Intel-wired-lan] [PATCH net v1 2/2] igc: Fix Supported Pause Frame Link Setting

[Neftin, Sasha]

On 3/3/2021 10:09, Dvora Fuxbrumer wrote:
> On 19/02/2021 18:36, Muhammad Husaini Zulkifli wrote:
>> The Supported Pause Frame always display "No" eventhough the Advertised
>> pause frame showing the correct setting based on the pause parameters via
>> ethtool. Set bit in link_ksettings to "Supported" for Pause Frame.
>>
>> Before output:
>> Supported pause frame use: No
>>
>> Expected output:
>> Supported pause frame use: Symmetric
>>
>> Fixes: 8c5ad0dae93c ("igc: Add ethtool support")
>> Signed-off-by: Muhammad Husaini Zulkifli 
>> <muhammad.husaini.zulkifli@intel.com>
>> Reviewed-by: Malli C <mallikarjuna.chilakala@intel.com>
>> ---
>> ? drivers/net/ethernet/intel/igc/igc_ethtool.c | 3 +++
>> ? 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c 
>> b/drivers/net/ethernet/intel/igc/igc_ethtool.c
>> index 67a4aed45fc2..8722294ab90c 100644
>> --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
>> +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
>> @@ -1711,6 +1711,9 @@ static int igc_ethtool_get_link_ksettings(struct 
>> net_device *netdev,
>> ?????????????????????????????? Autoneg);
>> ????? }
>> +??? /* Set pause flow control settings */
>> +??? ethtool_link_ksettings_add_link_mode(cmd, supported, Pause);
>> +
>> ????? switch (hw->fc.requested_mode) {
>> ????? case igc_fc_full:
>> ????????? ethtool_link_ksettings_add_link_mode(cmd, advertising, Pause);
>>
> Tested-by: Dvora Fuxbrumer <dvorax.fuxbrumer@linux.intel.com>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan at osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
Acked-by: Sasha Neftin <sasha.neftin@intel.com>