Re: [PATCH v8 25/26] drm/xe: Ensure __must_check for xe_force_wake_get() return

["Nilawar, Badal" <badal.nilawar@intel.com>]

On 08-10-2024 12:41, Himal Prasad Ghimiray wrote:
> Add __must_check attribute for xe_force_wake_get().
> 
> Cc: Badal Nilawar <badal.nilawar@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Nirmoy Das <nirmoy.das@intel.com>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> (#rev1)
> Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_force_wake.c | 4 ++--
>   drivers/gpu/drm/xe/xe_force_wake.h | 4 ++--
>   2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_force_wake.c b/drivers/gpu/drm/xe/xe_force_wake.c
> index 7ff2588a8c47..5d749bad9496 100644
> --- a/drivers/gpu/drm/xe/xe_force_wake.c
> +++ b/drivers/gpu/drm/xe/xe_force_wake.c
> @@ -169,8 +169,8 @@ static int domain_sleep_wait(struct xe_gt *gt,
>    * Return: opaque reference to woken domains or zero if none of requested
>    * domains were awake.
>    */
> -unsigned int xe_force_wake_get(struct xe_force_wake *fw,
> -			       enum xe_force_wake_domains domains)
> +unsigned int __must_check xe_force_wake_get(struct xe_force_wake *fw,
> +					    enum xe_force_wake_domains domains)
>   {
>   	struct xe_gt *gt = fw->gt;
>   	struct xe_force_wake_domain *domain;
> diff --git a/drivers/gpu/drm/xe/xe_force_wake.h b/drivers/gpu/drm/xe/xe_force_wake.h
> index f0b27dbe7581..70faec9ae2d9 100644
> --- a/drivers/gpu/drm/xe/xe_force_wake.h
> +++ b/drivers/gpu/drm/xe/xe_force_wake.h
> @@ -15,8 +15,8 @@ void xe_force_wake_init_gt(struct xe_gt *gt,
>   			   struct xe_force_wake *fw);
>   void xe_force_wake_init_engines(struct xe_gt *gt,
>   				struct xe_force_wake *fw);
> -unsigned int xe_force_wake_get(struct xe_force_wake *fw,
> -			       enum xe_force_wake_domains domains);
> +unsigned int __must_check xe_force_wake_get(struct xe_force_wake *fw,
> +					    enum xe_force_wake_domains domains);

I believe this is meant to guarantee that the return code is used; 
otherwise, it results in a compiler warning.

Reviewed-by: Badal Nilawar <badal.nilawar@intel.com>

Regards,
Badal

>   int xe_force_wake_put(struct xe_force_wake *fw,
>   		      unsigned int fw_ref);
>