Re: [PATCH v8 03/26] drm/xe/forcewake: Add a helper xe_force_wake_ref_has_domain()

["Nilawar, Badal" <badal.nilawar@intel.com>]

On 08-10-2024 12:40, Himal Prasad Ghimiray wrote:
> The helper xe_force_wake_ref_has_domain() checks if the input domain
> has been successfully reference-counted and awakened in the reference.
> 
> v2
> - Fix commit message and kernel-doc (Michal)
> - Remove unnecessary paranthesis (Michal)
> 
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Badal Nilawar <badal.nilawar@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_force_wake.h | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_force_wake.h b/drivers/gpu/drm/xe/xe_force_wake.h
> index a2577672f4e3..1608a55edc84 100644
> --- a/drivers/gpu/drm/xe/xe_force_wake.h
> +++ b/drivers/gpu/drm/xe/xe_force_wake.h
> @@ -46,4 +46,20 @@ xe_force_wake_assert_held(struct xe_force_wake *fw,
>   	xe_gt_assert(fw->gt, fw->awake_domains & domain);
>   }
>   
> +/**
> + * xe_force_wake_ref_has_domain - verifies if the domains are in fw_ref
> + * @fw_ref : the force_wake reference
> + * @domain : forcewake domain to verify
> + *
> + * This function confirms whether the @fw_ref includes a reference to the
> + * specified @domain.
> + *
> + * Return: true if domain is refcounted.
> + */
> +static inline bool
> +xe_force_wake_ref_has_domain(unsigned int fw_ref, enum xe_force_wake_domains domain)
> +{
> +	return fw_ref & domain;
> +}
> +

Reviewed-by: Badal Nilawar <badal.nilawar@intel.com>

Regards,
Badal

>   #endif