Re: [PATCH v3 0/7] Enable device atomics with a VM bind flag

[Lionel Landwerlin <lionel.g.landwerlin@intel.com>]

Just uploaded a Mesa MR for this series : 
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28823

-Lionel

On 15/04/2024 17:52, Nirmoy Das wrote:
> Currently device atomics in SMEM only buffer is not supported and
> given that simultaneous usage of device atomics and CPU atomics on
> the same SMEM buffer is not guaranteed to function without migration,
> and UMD expects no migration for SMEM-only buffer objects, so this
> provide a way to set device atomics when UMD is certain to use the
> buffer only for device atomics.
>
> v3: Capture ret value of xe_vm_bind_ioctl_validate_bo(Matt B).
>      Remove redundant coh_mode param from xe_vm_bind_ioctl_validate_bo().
>      Remove has_device_atomics_on_smem from xe_graphics_desc(Jose).
>      Replace DRM_XE_QUERY_CONFIG_SUPP_DEV_ATOMIC_ON_SMEM with
>      config flag DRM_XE_QUERY_CONFIG_FLAG_HAS_DEV_ATOMIC_ON_SMEM(Jose).
>      Mention that PTE_AE will not be applied to userptr(Matt R)
>
> v2: Add BO helper func in xe_vm_bind_ioctl()(Matt B).
>      Use XE_IOCTL_DBG for checks(Matt B).
>      Move platform checks with help of adding flags in
>      intel_device_info(Matt B).
>      Add document for DRM_XE_VM_BIND_FLAG_DEVICE_ATOMICS(Matt B).
>      Create query uAPI for this newly added VM bind flag(Jose, Lionel).
>
> Test-with: 20240415143528.4107-1-nirmoy.das@intel.com
> Cc: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
> Cc: Brian Welty <brian.welty@intel.com>
> Cc: Fei Yang <fei.yang@intel.com>
> Cc: Jose Souza <jose.souza@intel.com>
> Cc: Lionel G Landwerlin <lionel.g.landwerlin@intel.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: Michal Mrozek <michal.mrozek@intel.com>
> Cc: Oak Zeng <oak.zeng@intel.com>
> Cc: Thomas Hellstr_m <thomas.hellstrom@linux.intel.com>
>
> Nirmoy Das (7):
>    drm/xe: Introduce has_atomic_enable_pte_bit device info
>    drm/xe: Consolidate setting PTE_AE into one place
>    drm/xe: Add function to check if BO has single placement
>    drm/xe: Move vm bind bo validation to a helper function
>    drm/xe: Introduce has_device_atomics_on_smem device info
>    drm/xe/uapi: Introduce VMA bind flag for device atomics
>    drm/xe/uapi: Add a query flag for has_device_atomics_on_smem
>
>   drivers/gpu/drm/xe/xe_bo.c           |  14 ++++
>   drivers/gpu/drm/xe/xe_bo.h           |   1 +
>   drivers/gpu/drm/xe/xe_device_types.h |   4 +
>   drivers/gpu/drm/xe/xe_pci.c          |   5 ++
>   drivers/gpu/drm/xe/xe_pci_types.h    |   1 +
>   drivers/gpu/drm/xe/xe_pt.c           |   4 +-
>   drivers/gpu/drm/xe/xe_query.c        |   3 +
>   drivers/gpu/drm/xe/xe_vm.c           | 106 +++++++++++++++++----------
>   drivers/gpu/drm/xe/xe_vm_types.h     |   2 +
>   include/uapi/drm/xe_drm.h            |  22 ++++--
>   10 files changed, 116 insertions(+), 46 deletions(-)
>