From: Nirmoy Das <nirmoy.das@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Nirmoy Das <nirmoy.das@intel.com>
Subject: [PATCH v3 1/7] drm/xe: Introduce has_atomic_enable_pte_bit device info
Date: Mon, 15 Apr 2024 16:52:08 +0200 [thread overview]
Message-ID: <20240415145214.25641-2-nirmoy.das@intel.com> (raw)
In-Reply-To: <20240415145214.25641-1-nirmoy.das@intel.com>
Add has_atomic_enable_pte_bit to specify that a device
has PTE_AE bit in its PTE feild. Currently XE2 and PVC
supports this so set this for those two.
This will help consolidate setting atomic access bit in PTE
logic which is spread between multiple files.
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
drivers/gpu/drm/xe/xe_device_types.h | 2 ++
drivers/gpu/drm/xe/xe_pci.c | 3 +++
drivers/gpu/drm/xe/xe_pci_types.h | 1 +
3 files changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
index 60ced5f90c2b..bde42fe288ff 100644
--- a/drivers/gpu/drm/xe/xe_device_types.h
+++ b/drivers/gpu/drm/xe/xe_device_types.h
@@ -281,6 +281,8 @@ struct xe_device {
u8 has_heci_gscfi:1;
/** @info.skip_guc_pc: Skip GuC based PM feature init */
u8 skip_guc_pc:1;
+ /** @info.has_atomic_enable_pte_bit: Device has atomic enable PTE bit */
+ u8 has_atomic_enable_pte_bit:1;
#if IS_ENABLED(CONFIG_DRM_XE_DISPLAY)
struct {
diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
index 3b30353dbc09..9cf45559b915 100644
--- a/drivers/gpu/drm/xe/xe_pci.c
+++ b/drivers/gpu/drm/xe/xe_pci.c
@@ -146,6 +146,7 @@ static const struct xe_graphics_desc graphics_xehpc = {
.vram_flags = XE_VRAM_FLAGS_NEED64K,
.has_asid = 1,
+ .has_atomic_enable_pte_bit = 1,
.has_flat_ccs = 0,
.has_usm = 1,
};
@@ -163,6 +164,7 @@ static const struct xe_graphics_desc graphics_xelpg = {
#define XE2_GFX_FEATURES \
.dma_mask_size = 46, \
.has_asid = 1, \
+ .has_atomic_enable_pte_bit = 1, \
.has_flat_ccs = 1, \
.has_range_tlb_invalidation = 1, \
.has_usm = 1, \
@@ -627,6 +629,7 @@ static int xe_info_init(struct xe_device *xe,
xe->info.va_bits = graphics_desc->va_bits;
xe->info.vm_max_level = graphics_desc->vm_max_level;
xe->info.has_asid = graphics_desc->has_asid;
+ xe->info.has_atomic_enable_pte_bit = graphics_desc->has_atomic_enable_pte_bit;
xe->info.has_flat_ccs = graphics_desc->has_flat_ccs;
xe->info.has_range_tlb_invalidation = graphics_desc->has_range_tlb_invalidation;
xe->info.has_usm = graphics_desc->has_usm;
diff --git a/drivers/gpu/drm/xe/xe_pci_types.h b/drivers/gpu/drm/xe/xe_pci_types.h
index b1ad12fa22d6..e1f2b4879fc2 100644
--- a/drivers/gpu/drm/xe/xe_pci_types.h
+++ b/drivers/gpu/drm/xe/xe_pci_types.h
@@ -25,6 +25,7 @@ struct xe_graphics_desc {
u8 max_remote_tiles:2;
u8 has_asid:1;
+ u8 has_atomic_enable_pte_bit:1;
u8 has_flat_ccs:1;
u8 has_range_tlb_invalidation:1;
u8 has_usm:1;
--
2.42.0
next prev parent reply other threads:[~2024-04-15 15:06 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 14:52 [PATCH v3 0/7] Enable device atomics with a VM bind flag Nirmoy Das
2024-04-15 14:52 ` Nirmoy Das [this message]
2024-04-19 16:06 ` [PATCH v3 1/7] drm/xe: Introduce has_atomic_enable_pte_bit device info Zeng, Oak
2024-04-15 14:52 ` [PATCH v3 2/7] drm/xe: Consolidate setting PTE_AE into one place Nirmoy Das
2024-04-16 14:33 ` Nirmoy Das
2024-04-19 18:35 ` Zeng, Oak
2024-04-22 8:18 ` Nirmoy Das
2024-04-15 14:52 ` [PATCH v3 3/7] drm/xe: Add function to check if BO has single placement Nirmoy Das
2024-04-15 14:52 ` [PATCH v3 4/7] drm/xe: Move vm bind bo validation to a helper function Nirmoy Das
2024-04-16 0:55 ` Matthew Brost
2024-04-16 13:32 ` Nirmoy Das
2024-04-19 20:14 ` Zeng, Oak
2024-04-15 14:52 ` [PATCH v3 5/7] drm/xe: Introduce has_device_atomics_on_smem device info Nirmoy Das
2024-04-19 20:24 ` Zeng, Oak
2024-04-15 14:52 ` [PATCH v3 6/7] drm/xe/uapi: Introduce VMA bind flag for device atomics Nirmoy Das
2024-04-19 7:16 ` Lionel Landwerlin
2024-04-22 8:39 ` Nirmoy Das
2024-04-19 21:04 ` Zeng, Oak
2024-04-22 10:12 ` Nirmoy Das
2024-04-22 21:39 ` Zeng, Oak
2024-04-23 12:33 ` Nirmoy Das
2024-04-15 14:52 ` [PATCH v3 7/7] drm/xe/uapi: Add a query flag for has_device_atomics_on_smem Nirmoy Das
2024-04-19 7:08 ` Lionel Landwerlin
2024-04-22 8:53 ` Nirmoy Das
2024-04-19 21:06 ` Zeng, Oak
2024-04-15 21:19 ` ✓ CI.Patch_applied: success for Enable device atomics with a VM bind flag (rev3) Patchwork
2024-04-15 21:19 ` ✓ CI.checkpatch: " Patchwork
2024-04-15 21:21 ` ✓ CI.KUnit: " Patchwork
2024-04-15 21:37 ` ✓ CI.Build: " Patchwork
2024-04-15 21:40 ` ✓ CI.Hooks: " Patchwork
2024-04-15 21:41 ` ✓ CI.checksparse: " Patchwork
2024-04-15 22:22 ` ✗ CI.BAT: failure " Patchwork
2024-04-16 13:46 ` ✓ CI.FULL: success " Patchwork
2024-04-19 7:17 ` [PATCH v3 0/7] Enable device atomics with a VM bind flag Lionel Landwerlin
2024-04-22 10:13 ` Nirmoy Das
2024-04-22 14:50 ` Souza, Jose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240415145214.25641-2-nirmoy.das@intel.com \
--to=nirmoy.das@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox