Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe/oa: Remove WARN_ON's for unsupported configurations
@ 2024-06-19 22:56 Ashutosh Dixit
  2024-06-19 23:01 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 11+ messages in thread
From: Ashutosh Dixit @ 2024-06-19 22:56 UTC (permalink / raw)
  To: intel-xe; +Cc: Michal Wajdeczko

The OA ioctl's already have drm_dbg's which are sufficient to tell the user
that OA is not supported on unsupported configurations (execlist mode and
platform gen < 12). Having additional WARN_ON's for these during driver
probe create unnecessary noise. Just remove these WARN_ON's.

Suggested-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
 drivers/gpu/drm/xe/xe_oa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c
index 34206e0b6a08..5093a89a31f1 100644
--- a/drivers/gpu/drm/xe/xe_oa.c
+++ b/drivers/gpu/drm/xe/xe_oa.c
@@ -2382,7 +2382,7 @@ int xe_oa_init(struct xe_device *xe)
 	int ret;
 
 	/* Support OA only with GuC submission and Gen12+ */
-	if (XE_WARN_ON(!xe_device_uc_enabled(xe)) || XE_WARN_ON(GRAPHICS_VER(xe) < 12))
+	if (!xe_device_uc_enabled(xe) || GRAPHICS_VER(xe) < 12)
 		return 0;
 
 	oa->xe = xe;
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2024-06-20 16:28 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-19 22:56 [PATCH] drm/xe/oa: Remove WARN_ON's for unsupported configurations Ashutosh Dixit
2024-06-19 23:01 ` ✓ CI.Patch_applied: success for " Patchwork
2024-06-19 23:01 ` ✓ CI.checkpatch: " Patchwork
2024-06-19 23:02 ` ✓ CI.KUnit: " Patchwork
2024-06-19 23:04 ` [PATCH] " Michal Wajdeczko
2024-06-20 16:17   ` Dixit, Ashutosh
2024-06-19 23:14 ` ✓ CI.Build: success for " Patchwork
2024-06-19 23:16 ` ✗ CI.Hooks: failure " Patchwork
2024-06-19 23:17 ` ✓ CI.checksparse: success " Patchwork
2024-06-19 23:39 ` ✓ CI.BAT: " Patchwork
2024-06-20  7:17 ` ✗ CI.FULL: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox