Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tejas Upadhyay <tejas.upadhyay@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Matt Roper <matthew.d.roper@intel.com>,
	Shekhar Chauhan <shekhar.chauhan@intel.com>,
	Matthew Auld <matthew.auld@intel.com>,
	Lucas De Marchi <lucas.demarchi@intel.com>,
	Tejas Upadhyay <tejas.upadhyay@intel.com>
Subject: [PATCH V2 3/3] drm/xe: Define STATELESS_COMPRESSION_CTRL as mcr register
Date: Wed, 14 Aug 2024 15:26:14 +0530	[thread overview]
Message-ID: <20240814095614.909774-4-tejas.upadhyay@intel.com> (raw)
In-Reply-To: <20240814095614.909774-1-tejas.upadhyay@intel.com>

Register STATELESS_COMPRESSION_CTRL should be considered
mcr register which should write to all slices as per
documentation.

Bspec: 71185
Fixes: ecabb5e6ce54 ("drm/xe/xe2: Add performance turning changes")
Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
---
 drivers/gpu/drm/xe/regs/xe_gt_regs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/regs/xe_gt_regs.h b/drivers/gpu/drm/xe/regs/xe_gt_regs.h
index aeb17fcb27ac..0d1a4a9f4e11 100644
--- a/drivers/gpu/drm/xe/regs/xe_gt_regs.h
+++ b/drivers/gpu/drm/xe/regs/xe_gt_regs.h
@@ -80,7 +80,7 @@
 #define   LE_CACHEABILITY_MASK			REG_GENMASK(1, 0)
 #define   LE_CACHEABILITY(value)		REG_FIELD_PREP(LE_CACHEABILITY_MASK, value)
 
-#define STATELESS_COMPRESSION_CTRL		XE_REG(0x4148)
+#define STATELESS_COMPRESSION_CTRL		XE_REG_MCR(0x4148)
 #define   UNIFIED_COMPRESSION_FORMAT		REG_GENMASK(3, 0)
 
 #define XE2_GAMREQSTRM_CTRL			XE_REG_MCR(0x4194)
-- 
2.25.1


  parent reply	other threads:[~2024-08-14  9:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-14  9:56 [PATCH V2 0/3] Shuffle enable_host_l2_vram order and use MCR reg Tejas Upadhyay
2024-08-14  9:56 ` [PATCH V2 1/3] drm/xe: Move enable host l2 VRAM post MCR init Tejas Upadhyay
2024-08-14 16:34   ` Lucas De Marchi
2024-08-14 19:23     ` Matt Roper
2024-08-15 13:56       ` Lucas De Marchi
2024-08-14  9:56 ` [PATCH V2 2/3] drm/xe: Write all slices if its mcr register Tejas Upadhyay
2024-08-14  9:56 ` Tejas Upadhyay [this message]
2024-08-14 15:24   ` [PATCH V2 3/3] drm/xe: Define STATELESS_COMPRESSION_CTRL as " Chauhan, Shekhar
2024-08-14 10:01 ` ✓ CI.Patch_applied: success for Shuffle enable_host_l2_vram order and use MCR reg (rev2) Patchwork
2024-08-14 10:02 ` ✓ CI.checkpatch: " Patchwork
2024-08-14 10:04 ` ✓ CI.KUnit: " Patchwork
2024-08-14 10:18 ` ✓ CI.Build: " Patchwork
2024-08-14 10:20 ` ✓ CI.Hooks: " Patchwork
2024-08-14 10:22 ` ✓ CI.checksparse: " Patchwork
2024-08-14 10:49 ` ✓ CI.BAT: " Patchwork
2024-08-14 12:39 ` ✗ CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240814095614.909774-4-tejas.upadhyay@intel.com \
    --to=tejas.upadhyay@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=matthew.auld@intel.com \
    --cc=matthew.d.roper@intel.com \
    --cc=shekhar.chauhan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox