From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Subject: [PATCH 12/16] drm/i915/dp: Modify compressed bpp limitations for ultrajoiner
Date: Tue, 24 Sep 2024 00:02:48 +0530 [thread overview]
Message-ID: <20240923183248.3324009-1-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20240923181336.3303940-13-ankit.k.nautiyal@intel.com>
Add compressed bpp limitations for ultrajoiner.
v2: Fix the case for 1 pipe. (Ankit)
Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 27 +++++++++++++++++++------
1 file changed, 21 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index e4b6594d870e..b359d2e808aa 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -865,24 +865,39 @@ u32 get_max_compressed_bpp_with_joiner(struct drm_i915_private *i915,
int num_joined_pipes)
{
u32 max_bpp_small_joiner_ram;
+ u32 max_bpp_bigjoiner;
+ u32 max_bpp;
/* Small Joiner Check: output bpp <= joiner RAM (bits) / Horiz. width */
max_bpp_small_joiner_ram = small_joiner_ram_size_bits(i915) / mode_hdisplay;
- if (num_joined_pipes == 2) {
+ if (num_joined_pipes == 1)
+ return max_bpp_small_joiner_ram;
+
+ if (num_joined_pipes > 1) {
int bigjoiner_interface_bits = DISPLAY_VER(i915) >= 14 ? 36 : 24;
/* With bigjoiner multiple dsc engines are used in parallel so PPC is 2 */
int ppc = 2;
- u32 max_bpp_bigjoiner =
- i915->display.cdclk.max_cdclk_freq * ppc * bigjoiner_interface_bits /
+ int num_bigjoiners = num_joined_pipes / 2;
+
+ max_bpp_bigjoiner =
+ i915->display.cdclk.max_cdclk_freq * ppc * bigjoiner_interface_bits *
intel_dp_mode_to_fec_clock(mode_clock);
- max_bpp_small_joiner_ram *= 2;
+ max_bpp_bigjoiner *= num_bigjoiners;
+
+ max_bpp_small_joiner_ram *= num_joined_pipes;
+ }
+
+ max_bpp = min(max_bpp_small_joiner_ram, max_bpp_bigjoiner);
+
+ if (num_joined_pipes == 4) {
+ u32 max_bpp_ultrajoiner_ram = (4 * 72 * 512) / mode_hdisplay;
- return min(max_bpp_small_joiner_ram, max_bpp_bigjoiner);
+ max_bpp = min(max_bpp, max_bpp_ultrajoiner_ram);
}
- return max_bpp_small_joiner_ram;
+ return max_bpp;
}
u16 intel_dp_dsc_get_max_compressed_bpp(struct drm_i915_private *i915,
--
2.45.2
next prev parent reply other threads:[~2024-09-23 18:30 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 18:13 [PATCH 00/16] Ultrajoiner basic functionality series Ankit Nautiyal
2024-09-23 18:13 ` [PATCH 01/16] drm/i915/display_device: Add Check HAS_DSC for bigjoiner Ankit Nautiyal
2024-09-23 18:30 ` Ville Syrjälä
2024-09-23 18:13 ` [PATCH 02/16] drm/i915/display_debugfs: Allow force joiner only if supported Ankit Nautiyal
2024-09-23 18:34 ` Ville Syrjälä
2024-09-23 18:13 ` [PATCH 03/16] drm/i915/display: Modify debugfs for joiner to force n pipes Ankit Nautiyal
2024-09-23 18:36 ` Ville Syrjälä
2024-09-23 18:13 ` [PATCH 04/16] drm/i915/dp: Add helper to compute num pipes required Ankit Nautiyal
2024-09-23 18:13 ` [PATCH 05/16] drm/i915/display: Add debugfs support to avoid joiner Ankit Nautiyal
2024-09-23 18:38 ` Ville Syrjälä
2024-09-23 18:13 ` [PATCH 06/16] drm/i915: Split current joiner hw state readout Ankit Nautiyal
2024-09-23 18:13 ` [PATCH 07/16] drm/i915: Add bigjoiner and uncompressed joiner hw readout sanity checks Ankit Nautiyal
2024-09-23 18:13 ` [PATCH 08/16] drm/i915/display: Add macro HAS_ULTRAJOINER() Ankit Nautiyal
2024-09-23 18:39 ` Ville Syrjälä
2024-09-23 18:13 ` [PATCH 09/16] drm/i915: Implement hw state readout and checks for ultrajoiner Ankit Nautiyal
2024-09-23 18:44 ` Ville Syrjälä
2024-09-23 18:13 ` [PATCH 10/16] drm/i915/display: Refactor enable_joiner_pipes Ankit Nautiyal
2024-09-23 18:52 ` Ville Syrjälä
2024-09-23 18:13 ` [PATCH 11/16] drm/i915/display/vdsc: Add ultrajoiner support with DSC Ankit Nautiyal
2024-09-23 18:54 ` Ville Syrjälä
2024-09-23 18:13 ` [PATCH 12/16] drm/i915/dp: Modify compressed bpp limitations for ultrajoiner Ankit Nautiyal
2024-09-23 18:32 ` Ankit Nautiyal [this message]
2024-09-23 18:13 ` [PATCH 13/16] drm/i915/dp: Modify helper to get slice count " Ankit Nautiyal
2024-09-23 19:04 ` Ville Syrjälä
2024-09-23 18:13 ` [PATCH 14/16] drm/i915: Compute config and mode valid changes " Ankit Nautiyal
2024-09-23 19:06 ` Ville Syrjälä
2024-09-23 18:13 ` [PATCH 15/16] drm/i915/display: Consider ultrajoiner for computing maxdotclock Ankit Nautiyal
2024-09-23 19:08 ` Ville Syrjälä
2024-09-23 18:13 ` [PATCH 16/16] drm/i915/intel_dp: Add support for forcing ultrajoiner Ankit Nautiyal
2024-09-23 19:09 ` Ville Syrjälä
2024-09-25 22:13 ` ✓ CI.Patch_applied: success for Ultrajoiner basic functionality series (rev3) Patchwork
2024-09-25 22:13 ` ✗ CI.checkpatch: warning " Patchwork
2024-09-25 22:15 ` ✓ CI.KUnit: success " Patchwork
2024-09-25 22:26 ` ✓ CI.Build: " Patchwork
2024-09-25 22:29 ` ✓ CI.Hooks: " Patchwork
2024-09-25 22:30 ` ✗ CI.checksparse: warning " Patchwork
2024-09-25 22:59 ` ✗ CI.BAT: failure " Patchwork
2024-09-26 2:40 ` ✗ CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240923183248.3324009-1-ankit.k.nautiyal@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox