From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, suraj.kandpal@intel.com,
ville.syrjala@linux.intel.com
Subject: [PATCH 15/17] drm/i915: Compute config and mode valid changes for ultrajoiner
Date: Fri, 27 Sep 2024 20:52:39 +0530 [thread overview]
Message-ID: <20240927152241.4014909-16-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20240927152241.4014909-1-ankit.k.nautiyal@intel.com>
From: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Implement required changes for mode validation and compute config,
to support Ultrajoiner.
v2:
-Drop changes for HDMI.
-Separate out DSC changes into another patch.
v3: Fix check in can_ultrajoiner. (Ankit)
v4:
-Unify helper to check joiner requirement. (Ville)
-Split patches for ultrajoiner changes for max dsc slices and compressed
bpp.(Ankit)
v5: Fix check for joiner. (Ville)
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 26 +++++++++++++++++++------
1 file changed, 20 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index afc35a83eee2..d31bf66a669f 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1318,26 +1318,38 @@ intel_dp_mode_valid_downstream(struct intel_connector *connector,
}
static
-bool intel_dp_needs_bigjoiner(struct intel_dp *intel_dp,
- struct intel_connector *connector,
- int hdisplay, int clock)
+bool intel_dp_needs_joiner(struct intel_dp *intel_dp,
+ struct intel_connector *connector,
+ int hdisplay, int clock,
+ int num_joined_pipes)
{
struct drm_i915_private *i915 = dp_to_i915(intel_dp);
if (!intel_dp_has_joiner(intel_dp))
return false;
- return clock > i915->display.cdclk.max_dotclk_freq || hdisplay > 5120;
+ num_joined_pipes /= 2;
+
+ return clock > num_joined_pipes * i915->display.cdclk.max_dotclk_freq ||
+ hdisplay > num_joined_pipes * 5120;
}
int intel_dp_num_joined_pipes(struct intel_dp *intel_dp,
struct intel_connector *connector,
int hdisplay, int clock)
{
+ struct intel_display *display = to_intel_display(intel_dp);
+ struct drm_i915_private *i915 = to_i915(display->drm);
+
if (connector->force_joined_pipes)
return connector->force_joined_pipes;
- if (intel_dp_needs_bigjoiner(intel_dp, connector, hdisplay, clock))
+ if (HAS_ULTRAJOINER(i915) &&
+ intel_dp_needs_joiner(intel_dp, connector, hdisplay, clock, 4))
+ return 4;
+
+ if ((HAS_BIGJOINER(i915) || HAS_UNCOMPRESSED_JOINER(i915)) &&
+ intel_dp_needs_joiner(intel_dp, connector, hdisplay, clock, 2))
return 2;
return 1;
@@ -2543,8 +2555,10 @@ bool intel_dp_joiner_needs_dsc(struct drm_i915_private *i915,
* Pipe joiner needs compression up to display 12 due to bandwidth
* limitation. DG2 onwards pipe joiner can be enabled without
* compression.
+ * Ultrajoiner always needs compression.
*/
- return !HAS_UNCOMPRESSED_JOINER(i915) && num_joined_pipes == 2;
+ return (!HAS_UNCOMPRESSED_JOINER(i915) && num_joined_pipes == 2) ||
+ num_joined_pipes == 4;
}
static int
--
2.45.2
next prev parent reply other threads:[~2024-09-27 15:21 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-27 15:22 [PATCH 00/17] Ultrajoiner basic functionality series Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 01/17] drm/i915/display_device: Add Check HAS_DSC for bigjoiner Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 02/17] drm/i915/display_debugfs: Allow force joiner only if supported Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 03/17] drm/i915/display: Modify debugfs for joiner to force n pipes Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 04/17] drm/i915/dp: Add helper to compute num pipes required Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 05/17] drm/i915: Split current joiner hw state readout Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 06/17] drm/i915: Add bigjoiner and uncompressed joiner hw readout sanity checks Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 07/17] drm/i915/display: Add macro HAS_ULTRAJOINER() Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 08/17] drm/i915/display: Refactor enable_joiner_pipes Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 09/17] drm/i915: Implement hw state readout and checks for ultrajoiner Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 10/17] drm/i915/display/vdsc: Add ultrajoiner support with DSC Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 11/17] drm/i915/dp: Refactor joiner max_bpp calculations into separate functions Ankit Nautiyal
2024-09-27 15:43 ` Ville Syrjälä
2024-09-27 15:22 ` [PATCH 12/17] drm/i915/dp: Use num_joined_pipes in bigjoiner_bw_max_bpp Ankit Nautiyal
2024-09-27 15:44 ` Ville Syrjälä
2024-09-27 15:22 ` [PATCH 13/17] drm/i915/dp: Modify compressed bpp limitations for ultrajoiner Ankit Nautiyal
2024-09-27 15:55 ` Ville Syrjälä
2024-09-27 17:04 ` Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 14/17] drm/i915/dp: Simplify helper to get slice count with joiner Ankit Nautiyal
2024-09-27 15:22 ` Ankit Nautiyal [this message]
2024-09-27 15:22 ` [PATCH 16/17] drm/i915/display: Consider ultrajoiner for computing maxdotclock Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 17/17] drm/i915/intel_dp: Add support for forcing ultrajoiner Ankit Nautiyal
2024-09-27 17:16 ` ✓ CI.Patch_applied: success for Ultrajoiner basic functionality series (rev6) Patchwork
2024-09-27 17:17 ` ✗ CI.checkpatch: warning " Patchwork
2024-09-27 17:18 ` ✓ CI.KUnit: success " Patchwork
2024-09-27 17:29 ` ✓ CI.Build: " Patchwork
2024-09-27 17:31 ` ✓ CI.Hooks: " Patchwork
2024-09-27 17:33 ` ✗ CI.checksparse: warning " Patchwork
2024-09-27 18:03 ` ✓ CI.BAT: success " Patchwork
2024-09-27 19:38 ` ✓ CI.Patch_applied: success for Ultrajoiner basic functionality series (rev7) Patchwork
2024-09-27 19:39 ` ✗ CI.checkpatch: warning " Patchwork
2024-09-27 19:40 ` ✓ CI.KUnit: success " Patchwork
2024-09-27 19:51 ` ✓ CI.Build: " Patchwork
2024-09-27 19:54 ` ✓ CI.Hooks: " Patchwork
2024-09-27 19:55 ` ✗ CI.checksparse: warning " Patchwork
2024-09-27 20:20 ` ✓ CI.BAT: success " Patchwork
2024-09-30 6:03 ` ✗ CI.FULL: failure for Ultrajoiner basic functionality series (rev6) Patchwork
2024-09-30 6:38 ` ✗ CI.FULL: failure for Ultrajoiner basic functionality series (rev7) Patchwork
-- strict thread matches above, loose matches on Subject: below --
2024-09-27 8:38 [PATCH 00/17] Ultrajoiner basic functionality series Ankit Nautiyal
2024-09-27 8:38 ` [PATCH 15/17] drm/i915: Compute config and mode valid changes for ultrajoiner Ankit Nautiyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240927152241.4014909-16-ankit.k.nautiyal@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=suraj.kandpal@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox