Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, suraj.kandpal@intel.com,
	ville.syrjala@linux.intel.com
Subject: [PATCH 02/17] drm/i915/display_debugfs: Allow force joiner only if supported
Date: Fri, 27 Sep 2024 20:52:26 +0530	[thread overview]
Message-ID: <20240927152241.4014909-3-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20240927152241.4014909-1-ankit.k.nautiyal@intel.com>

Currently we support joiner only for DP encoder.
Do not create the debugfs for joiner if DP does not support the joiner.
This will also help avoiding cases where config has eDP MSO, with which
we do not support joiner.

v2: Check for intel_dp_has_joiner and avoid creating debugfs if not
supported. (Ville)
v3: Remove HAS_BIGJOINER check. (Ville)
v4: Reverse checks for connector type and intel_dp_has_joiner(). (Ville)
v5: Drop the local variable intel_dp and use intel_attached_dp() directly.

Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_debugfs.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
index 890ef7067b77..c38023b43682 100644
--- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
+++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
@@ -1362,9 +1362,9 @@ void intel_connector_debugfs_add(struct intel_connector *connector)
 				    connector, &i915_dsc_fractional_bpp_fops);
 	}
 
-	if (HAS_BIGJOINER(i915) &&
-	    (connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
-	     connector_type == DRM_MODE_CONNECTOR_eDP)) {
+	if ((connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
+	     connector_type == DRM_MODE_CONNECTOR_eDP) &&
+	    intel_dp_has_joiner(intel_attached_dp(connector))) {
 		debugfs_create_bool("i915_bigjoiner_force_enable", 0644, root,
 				    &connector->force_bigjoiner_enable);
 	}
-- 
2.45.2


  parent reply	other threads:[~2024-09-27 15:20 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-27 15:22 [PATCH 00/17] Ultrajoiner basic functionality series Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 01/17] drm/i915/display_device: Add Check HAS_DSC for bigjoiner Ankit Nautiyal
2024-09-27 15:22 ` Ankit Nautiyal [this message]
2024-09-27 15:22 ` [PATCH 03/17] drm/i915/display: Modify debugfs for joiner to force n pipes Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 04/17] drm/i915/dp: Add helper to compute num pipes required Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 05/17] drm/i915: Split current joiner hw state readout Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 06/17] drm/i915: Add bigjoiner and uncompressed joiner hw readout sanity checks Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 07/17] drm/i915/display: Add macro HAS_ULTRAJOINER() Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 08/17] drm/i915/display: Refactor enable_joiner_pipes Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 09/17] drm/i915: Implement hw state readout and checks for ultrajoiner Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 10/17] drm/i915/display/vdsc: Add ultrajoiner support with DSC Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 11/17] drm/i915/dp: Refactor joiner max_bpp calculations into separate functions Ankit Nautiyal
2024-09-27 15:43   ` Ville Syrjälä
2024-09-27 15:22 ` [PATCH 12/17] drm/i915/dp: Use num_joined_pipes in bigjoiner_bw_max_bpp Ankit Nautiyal
2024-09-27 15:44   ` Ville Syrjälä
2024-09-27 15:22 ` [PATCH 13/17] drm/i915/dp: Modify compressed bpp limitations for ultrajoiner Ankit Nautiyal
2024-09-27 15:55   ` Ville Syrjälä
2024-09-27 17:04   ` Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 14/17] drm/i915/dp: Simplify helper to get slice count with joiner Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 15/17] drm/i915: Compute config and mode valid changes for ultrajoiner Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 16/17] drm/i915/display: Consider ultrajoiner for computing maxdotclock Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 17/17] drm/i915/intel_dp: Add support for forcing ultrajoiner Ankit Nautiyal
2024-09-27 17:16 ` ✓ CI.Patch_applied: success for Ultrajoiner basic functionality series (rev6) Patchwork
2024-09-27 17:17 ` ✗ CI.checkpatch: warning " Patchwork
2024-09-27 17:18 ` ✓ CI.KUnit: success " Patchwork
2024-09-27 17:29 ` ✓ CI.Build: " Patchwork
2024-09-27 17:31 ` ✓ CI.Hooks: " Patchwork
2024-09-27 17:33 ` ✗ CI.checksparse: warning " Patchwork
2024-09-27 18:03 ` ✓ CI.BAT: success " Patchwork
2024-09-27 19:38 ` ✓ CI.Patch_applied: success for Ultrajoiner basic functionality series (rev7) Patchwork
2024-09-27 19:39 ` ✗ CI.checkpatch: warning " Patchwork
2024-09-27 19:40 ` ✓ CI.KUnit: success " Patchwork
2024-09-27 19:51 ` ✓ CI.Build: " Patchwork
2024-09-27 19:54 ` ✓ CI.Hooks: " Patchwork
2024-09-27 19:55 ` ✗ CI.checksparse: warning " Patchwork
2024-09-27 20:20 ` ✓ CI.BAT: success " Patchwork
2024-09-30  6:03 ` ✗ CI.FULL: failure for Ultrajoiner basic functionality series (rev6) Patchwork
2024-09-30  6:38 ` ✗ CI.FULL: failure for Ultrajoiner basic functionality series (rev7) Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-09-27  8:38 [PATCH 00/17] Ultrajoiner basic functionality series Ankit Nautiyal
2024-09-27  8:38 ` [PATCH 02/17] drm/i915/display_debugfs: Allow force joiner only if supported Ankit Nautiyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240927152241.4014909-3-ankit.k.nautiyal@intel.com \
    --to=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=suraj.kandpal@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox