From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, suraj.kandpal@intel.com,
ville.syrjala@linux.intel.com
Subject: [PATCH 11/17] drm/i915/dp: Refactor joiner max_bpp calculations into separate functions
Date: Fri, 27 Sep 2024 20:52:35 +0530 [thread overview]
Message-ID: <20240927152241.4014909-12-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20240927152241.4014909-1-ankit.k.nautiyal@intel.com>
Currently compressed max_bpp limitations for small joiner ram, big joiner
etc are intermingled. Seprate these limitations into separate functions.
v2: Use num_joined_pipes in small joiner ram helper and other minor
fixes. (Ville)
Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 46 +++++++++++++++++++------
1 file changed, 36 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index f2a2541c1091..29f8cb9c4dd0 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -859,25 +859,51 @@ u32 intel_dp_dsc_nearest_valid_bpp(struct drm_i915_private *i915, u32 bpp, u32 p
return bits_per_pixel;
}
+static int bigjoiner_interface_bits(struct intel_display *display)
+{
+ return DISPLAY_VER(display) >= 14 ? 36 : 24;
+}
+
+static u32 bigjoiner_bw_max_bpp(struct intel_display *display, u32 mode_clock)
+{
+ u32 max_bpp;
+ /* With bigjoiner multiple dsc engines are used in parallel so PPC is 2 */
+ int ppc = 2;
+
+ max_bpp = display->cdclk.max_cdclk_freq * ppc * bigjoiner_interface_bits(display) /
+ intel_dp_mode_to_fec_clock(mode_clock);
+
+ return max_bpp;
+}
+
+static u32 small_joiner_ram_max_bpp(struct intel_display *display,
+ u32 mode_hdisplay,
+ int num_joined_pipes)
+{
+ struct drm_i915_private *i915 = to_i915(display->drm);
+ u32 max_bpp;
+
+ /* Small Joiner Check: output bpp <= joiner RAM (bits) / Horiz. width */
+ max_bpp = small_joiner_ram_size_bits(i915) / mode_hdisplay;
+
+ max_bpp *= num_joined_pipes;
+
+ return max_bpp;
+}
+
static
u32 get_max_compressed_bpp_with_joiner(struct drm_i915_private *i915,
u32 mode_clock, u32 mode_hdisplay,
int num_joined_pipes)
{
+ struct intel_display *display = to_intel_display(&i915->drm);
u32 max_bpp_small_joiner_ram;
- /* Small Joiner Check: output bpp <= joiner RAM (bits) / Horiz. width */
- max_bpp_small_joiner_ram = small_joiner_ram_size_bits(i915) / mode_hdisplay;
+ max_bpp_small_joiner_ram = small_joiner_ram_max_bpp(display, mode_hdisplay,
+ num_joined_pipes);
if (num_joined_pipes == 2) {
- int bigjoiner_interface_bits = DISPLAY_VER(i915) >= 14 ? 36 : 24;
- /* With bigjoiner multiple dsc engines are used in parallel so PPC is 2 */
- int ppc = 2;
- u32 max_bpp_bigjoiner =
- i915->display.cdclk.max_cdclk_freq * ppc * bigjoiner_interface_bits /
- intel_dp_mode_to_fec_clock(mode_clock);
-
- max_bpp_small_joiner_ram *= 2;
+ u32 max_bpp_bigjoiner = bigjoiner_bw_max_bpp(display, mode_clock);
return min(max_bpp_small_joiner_ram, max_bpp_bigjoiner);
}
--
2.45.2
next prev parent reply other threads:[~2024-09-27 15:21 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-27 15:22 [PATCH 00/17] Ultrajoiner basic functionality series Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 01/17] drm/i915/display_device: Add Check HAS_DSC for bigjoiner Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 02/17] drm/i915/display_debugfs: Allow force joiner only if supported Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 03/17] drm/i915/display: Modify debugfs for joiner to force n pipes Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 04/17] drm/i915/dp: Add helper to compute num pipes required Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 05/17] drm/i915: Split current joiner hw state readout Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 06/17] drm/i915: Add bigjoiner and uncompressed joiner hw readout sanity checks Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 07/17] drm/i915/display: Add macro HAS_ULTRAJOINER() Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 08/17] drm/i915/display: Refactor enable_joiner_pipes Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 09/17] drm/i915: Implement hw state readout and checks for ultrajoiner Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 10/17] drm/i915/display/vdsc: Add ultrajoiner support with DSC Ankit Nautiyal
2024-09-27 15:22 ` Ankit Nautiyal [this message]
2024-09-27 15:43 ` [PATCH 11/17] drm/i915/dp: Refactor joiner max_bpp calculations into separate functions Ville Syrjälä
2024-09-27 15:22 ` [PATCH 12/17] drm/i915/dp: Use num_joined_pipes in bigjoiner_bw_max_bpp Ankit Nautiyal
2024-09-27 15:44 ` Ville Syrjälä
2024-09-27 15:22 ` [PATCH 13/17] drm/i915/dp: Modify compressed bpp limitations for ultrajoiner Ankit Nautiyal
2024-09-27 15:55 ` Ville Syrjälä
2024-09-27 17:04 ` Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 14/17] drm/i915/dp: Simplify helper to get slice count with joiner Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 15/17] drm/i915: Compute config and mode valid changes for ultrajoiner Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 16/17] drm/i915/display: Consider ultrajoiner for computing maxdotclock Ankit Nautiyal
2024-09-27 15:22 ` [PATCH 17/17] drm/i915/intel_dp: Add support for forcing ultrajoiner Ankit Nautiyal
2024-09-27 17:16 ` ✓ CI.Patch_applied: success for Ultrajoiner basic functionality series (rev6) Patchwork
2024-09-27 17:17 ` ✗ CI.checkpatch: warning " Patchwork
2024-09-27 17:18 ` ✓ CI.KUnit: success " Patchwork
2024-09-27 17:29 ` ✓ CI.Build: " Patchwork
2024-09-27 17:31 ` ✓ CI.Hooks: " Patchwork
2024-09-27 17:33 ` ✗ CI.checksparse: warning " Patchwork
2024-09-27 18:03 ` ✓ CI.BAT: success " Patchwork
2024-09-27 19:38 ` ✓ CI.Patch_applied: success for Ultrajoiner basic functionality series (rev7) Patchwork
2024-09-27 19:39 ` ✗ CI.checkpatch: warning " Patchwork
2024-09-27 19:40 ` ✓ CI.KUnit: success " Patchwork
2024-09-27 19:51 ` ✓ CI.Build: " Patchwork
2024-09-27 19:54 ` ✓ CI.Hooks: " Patchwork
2024-09-27 19:55 ` ✗ CI.checksparse: warning " Patchwork
2024-09-27 20:20 ` ✓ CI.BAT: success " Patchwork
2024-09-30 6:03 ` ✗ CI.FULL: failure for Ultrajoiner basic functionality series (rev6) Patchwork
2024-09-30 6:38 ` ✗ CI.FULL: failure for Ultrajoiner basic functionality series (rev7) Patchwork
-- strict thread matches above, loose matches on Subject: below --
2024-09-27 8:38 [PATCH 00/17] Ultrajoiner basic functionality series Ankit Nautiyal
2024-09-27 8:38 ` [PATCH 11/17] drm/i915/dp: Refactor joiner max_bpp calculations into separate functions Ankit Nautiyal
2024-09-27 12:27 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240927152241.4014909-12-ankit.k.nautiyal@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=suraj.kandpal@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox