Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maarten@mblankhorst.nl, Lankhorst@mblankhorst.nl,
	dev@lankhorst.se
Subject: [PATCH 6/9] drm/xe/sriov: Move VF bootstrap and query_config to vf_guc_init
Date: Thu,  7 Nov 2024 11:01:37 +0100	[thread overview]
Message-ID: <20241107100140.292928-6-maarten.lankhorst@linux.intel.com> (raw)
In-Reply-To: <20241107100140.292928-1-maarten.lankhorst@linux.intel.com>

We want to split up GUC init to an alloc and noalloc part to keep the
init path the same for VF and !VF as much as possible.

Everything in vf_guc_init should be done as early as possible, otherwise
VRAM probing becomes impossible.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241105121857.17389-6-maarten.lankhorst@linux.intel.com
Signed-off-by: Maarten Lankhorst,,, <dev@lankhorst.se>
---
 drivers/gpu/drm/xe/xe_gt_sriov_vf.c |  1 -
 drivers/gpu/drm/xe/xe_guc.c         | 17 +++++++++--------
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_gt_sriov_vf.c b/drivers/gpu/drm/xe/xe_gt_sriov_vf.c
index cca5d57328021..997438047a037 100644
--- a/drivers/gpu/drm/xe/xe_gt_sriov_vf.c
+++ b/drivers/gpu/drm/xe/xe_gt_sriov_vf.c
@@ -948,7 +948,6 @@ u32 xe_gt_sriov_vf_read32(struct xe_gt *gt, struct xe_reg reg)
 	struct vf_runtime_reg *rr;
 
 	xe_gt_assert(gt, IS_SRIOV_VF(gt_to_xe(gt)));
-	xe_gt_assert(gt, gt->sriov.vf.pf_version.major);
 	xe_gt_assert(gt, !reg.vf);
 
 	if (reg.addr == GMD_ID.addr) {
diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c
index 7224593c9ce9b..5a050a5379911 100644
--- a/drivers/gpu/drm/xe/xe_guc.c
+++ b/drivers/gpu/drm/xe/xe_guc.c
@@ -301,6 +301,7 @@ static int xe_guc_realloc_post_hwconfig(struct xe_guc *guc)
 
 static int vf_guc_init(struct xe_guc *guc)
 {
+	struct xe_gt *gt = guc_to_gt(guc);
 	int err;
 
 	xe_guc_comm_init_early(guc);
@@ -313,6 +314,14 @@ static int vf_guc_init(struct xe_guc *guc)
 	if (err)
 		return err;
 
+	err = xe_gt_sriov_vf_bootstrap(gt);
+	if (err)
+		return err;
+
+	err = xe_gt_sriov_vf_query_config(gt);
+	if (err)
+		return err;
+
 	return 0;
 }
 
@@ -753,14 +762,6 @@ static int vf_guc_min_load_for_hwconfig(struct xe_guc *guc)
 	struct xe_gt *gt = guc_to_gt(guc);
 	int ret;
 
-	ret = xe_gt_sriov_vf_bootstrap(gt);
-	if (ret)
-		return ret;
-
-	ret = xe_gt_sriov_vf_query_config(gt);
-	if (ret)
-		return ret;
-
 	ret = xe_guc_hwconfig_init(guc);
 	if (ret)
 		return ret;
-- 
2.45.2


  parent reply	other threads:[~2024-11-07 10:02 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-07 10:01 [PATCH 1/9] drm/xe: Remove double pageflip Maarten Lankhorst
2024-11-07 10:01 ` [PATCH 2/9] drm/xe/display: Add intel_plane_initial_vblank_wait Maarten Lankhorst
2024-11-07 11:36   ` [PATCH] " Maarten Lankhorst
2024-11-07 12:21     ` Ville Syrjälä
2024-11-07 17:45       ` Maarten Lankhorst
2024-11-07 10:01 ` [PATCH 3/9] drm/xe: Move suballocator init to after display init Maarten Lankhorst
2024-11-12 18:18   ` Rodrigo Vivi
2024-11-07 10:01 ` [PATCH 4/9] drm/xe: Defer irq init until after xe_display_init_noaccel Maarten Lankhorst
2024-11-12 18:21   ` Rodrigo Vivi
2024-11-07 10:01 ` [PATCH 5/9] drm/xe/display: Use a single early init call for display Maarten Lankhorst
2024-11-12 18:39   ` Rodrigo Vivi
2024-11-13 10:30     ` Maarten Lankhorst
2024-11-14 16:05       ` Rodrigo Vivi
2024-11-07 10:01 ` Maarten Lankhorst [this message]
2024-11-14 16:09   ` [PATCH 6/9] drm/xe/sriov: Move VF bootstrap and query_config to vf_guc_init Rodrigo Vivi
2024-11-15 14:21     ` Maarten Lankhorst
2024-11-15 19:06       ` Rodrigo Vivi
2024-11-15 19:50         ` Maarten Lankhorst
2024-11-15 20:02           ` Rodrigo Vivi
2024-11-15 20:51             ` Maarten Lankhorst
2024-11-07 10:01 ` [PATCH 7/9] drm/xe: Simplify GuC early initialisation Maarten Lankhorst
2024-11-07 10:01 ` [PATCH 8/9] drm/xe: Make it possible to read instance0 MCR registers after xe_gt_mcr_init_early Maarten Lankhorst
2024-11-07 10:01 ` [PATCH 9/9] drm/xe: Split init of xe_gt_init_hwconfig to xe_gt_init and *_early Maarten Lankhorst
2024-11-07 10:08 ` ✓ CI.Patch_applied: success for series starting with [1/9] drm/xe: Remove double pageflip Patchwork
2024-11-07 10:08 ` ✗ CI.checkpatch: warning " Patchwork
2024-11-07 10:09 ` ✓ CI.KUnit: success " Patchwork
2024-11-07 10:14 ` ✗ CI.Build: failure " Patchwork
2024-11-07 12:57 ` ✓ CI.Patch_applied: success for series starting with [1/9] drm/xe: Remove double pageflip (rev2) Patchwork
2024-11-07 12:57 ` ✗ CI.checkpatch: warning " Patchwork
2024-11-07 12:59 ` ✓ CI.KUnit: success " Patchwork
2024-11-07 13:10 ` ✓ CI.Build: " Patchwork
2024-11-07 13:12 ` ✓ CI.Hooks: " Patchwork
2024-11-07 13:14 ` ✗ CI.checksparse: warning " Patchwork
2024-11-07 13:52 ` ✓ CI.BAT: success " Patchwork
2024-11-08 20:13 ` ✗ CI.FULL: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-11-05 12:18 [PATCH 1/9] drm/xe: Remove double pageflip Maarten Lankhorst
2024-11-05 12:18 ` [PATCH 6/9] drm/xe/sriov: Move VF bootstrap and query_config to vf_guc_init Maarten Lankhorst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241107100140.292928-6-maarten.lankhorst@linux.intel.com \
    --to=maarten.lankhorst@linux.intel.com \
    --cc=Lankhorst@mblankhorst.nl \
    --cc=Maarten@mblankhorst.nl \
    --cc=dev@lankhorst.se \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox