Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, suraj.kandpal@intel.com,
	jani.nikula@linux.intel.com, imre.deak@intel.com
Subject: [PATCH 02/14] drm/i915/dp: Return early if DSC not supported
Date: Wed,  4 Dec 2024 14:56:30 +0530	[thread overview]
Message-ID: <20241204092642.1835807-3-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20241204092642.1835807-1-ankit.k.nautiyal@intel.com>

Check for DSC support before computing link config with DSC.
For DP MST we are already doing the same.

Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index eb65c7a64a32..4291aa4f4ab4 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -2370,9 +2370,6 @@ int intel_dp_dsc_compute_config(struct intel_dp *intel_dp,
 		 intel_dp_supports_fec(intel_dp, connector, pipe_config) &&
 		 !intel_dp_is_uhbr(pipe_config));
 
-	if (!intel_dp_supports_dsc(intel_dp, connector, pipe_config))
-		return -EINVAL;
-
 	if (!intel_dp_dsc_supports_format(connector, pipe_config->output_format))
 		return -EINVAL;
 
@@ -2635,6 +2632,9 @@ intel_dp_compute_link_config(struct intel_encoder *encoder,
 			    str_yes_no(ret), str_yes_no(joiner_needs_dsc),
 			    str_yes_no(intel_dp->force_dsc_en));
 
+		if (!intel_dp_supports_dsc(intel_dp, connector, pipe_config))
+			return -EINVAL;
+
 		if (!intel_dp_compute_config_limits(intel_dp, pipe_config,
 						    respect_downstream_limits,
 						    true,
-- 
2.45.2


  parent reply	other threads:[~2024-12-04  9:24 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-04  9:26 [PATCH 00/14] DP DSC min/max src bpc fixes Ankit Nautiyal
2024-12-04  9:26 ` [PATCH 01/14] drm/i915/dp: Refactor FEC support check in intel_dp_supports_dsc Ankit Nautiyal
2024-12-11  4:47   ` Kandpal, Suraj
2024-12-04  9:26 ` Ankit Nautiyal [this message]
2024-12-04  9:26 ` [PATCH 03/14] drm/i915/dp: Separate out helper for compute fec_enable Ankit Nautiyal
2024-12-05  6:18   ` Kandpal, Suraj
2024-12-04  9:26 ` [PATCH 04/14] drm/i915/dp: Drop check for FEC in intel_dp_fec_compute_config Ankit Nautiyal
2024-12-05  6:26   ` Kandpal, Suraj
2024-12-13 12:28     ` Nautiyal, Ankit K
2024-12-04  9:26 ` [PATCH 05/14] drm/i915/dp: Remove HAS_DSC macro for intel_dp_dsc_max_src_input_bpc Ankit Nautiyal
2024-12-04 16:08   ` Kandpal, Suraj
2024-12-04  9:26 ` [PATCH 06/14] drm/i915/dp: Return int from dsc_max/min_src_input_bpc helpers Ankit Nautiyal
2024-12-04  9:26 ` [PATCH 07/14] drm/i915/dp: Use intel_display in intel_dp_dsc_max_src_input_bpc() Ankit Nautiyal
2024-12-04 16:09   ` Kandpal, Suraj
2024-12-04  9:26 ` [PATCH 08/14] drm/i915/dp_mst: Use helpers to get dsc min/max input bpc Ankit Nautiyal
2024-12-05  6:29   ` Kandpal, Suraj
2024-12-04  9:26 ` [PATCH 09/14] drm/i915/dp: Drop max_requested_bpc for dsc pipe_min/max bpp Ankit Nautiyal
2024-12-04  9:26 ` [PATCH 10/14] drm/i915/dp: Refactor pipe_bpp limits with dsc Ankit Nautiyal
2024-12-04  9:26 ` [PATCH 11/14] drm/i915/dp_mst: Refactor pipe_bpp limits with dsc for mst Ankit Nautiyal
2024-12-13  9:37   ` Jani Nikula
2024-12-13 12:32     ` Nautiyal, Ankit K
2024-12-04  9:26 ` [PATCH 12/14] drm/i915/dp: Use clamp for pipe_bpp limits with DSC Ankit Nautiyal
2024-12-04  9:26 ` [PATCH 13/14] drm/i915/dp: Make dsc helpers accept const crtc_state pointers Ankit Nautiyal
2024-12-04  9:26 ` [PATCH 14/14] drm/i915/dp: Set the DSC link limits intel_dp_compute_config_link_bpp_limits Ankit Nautiyal
2024-12-11  4:49   ` Kandpal, Suraj
2024-12-04  9:50 ` ✓ CI.Patch_applied: success for DP DSC min/max src bpc fixes (rev3) Patchwork
2024-12-04  9:50 ` ✓ CI.checkpatch: " Patchwork
2024-12-04  9:51 ` ✓ CI.KUnit: " Patchwork
2024-12-04 10:09 ` ✓ CI.Build: " Patchwork
2024-12-04 10:12 ` ✓ CI.Hooks: " Patchwork
2024-12-04 10:13 ` ✗ CI.checksparse: warning " Patchwork
2024-12-04 10:34 ` ✓ Xe.CI.BAT: success " Patchwork
2024-12-04 11:28 ` ✗ Xe.CI.Full: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-12-17  9:32 [PATCH 00/14] DP DSC min/max src bpc fixes Ankit Nautiyal
2024-12-17  9:32 ` [PATCH 02/14] drm/i915/dp: Return early if DSC not supported Ankit Nautiyal
2024-12-17 10:55   ` Jani Nikula
2024-12-17 11:02     ` Jani Nikula
2024-12-24 10:08       ` Nautiyal, Ankit K

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241204092642.1835807-3-ankit.k.nautiyal@intel.com \
    --to=ankit.k.nautiyal@intel.com \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=suraj.kandpal@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox