Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, suraj.kandpal@intel.com,
	jani.nikula@linux.intel.com, imre.deak@intel.com
Subject: [PATCH 08/14] drm/i915/dp_mst: Use helpers to get dsc min/max input bpc
Date: Wed,  4 Dec 2024 14:56:36 +0530	[thread overview]
Message-ID: <20241204092642.1835807-9-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20241204092642.1835807-1-ankit.k.nautiyal@intel.com>

Use helpers for source min/max input bpc with DSC.

Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c     |  2 --
 drivers/gpu/drm/i915/display/intel_dp.h     |  3 +++
 drivers/gpu/drm/i915/display/intel_dp_mst.c | 13 +++++--------
 3 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index edfe084dca39..bff7441d2ddd 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1780,7 +1780,6 @@ intel_dp_compute_link_config_wide(struct intel_dp *intel_dp,
 	return -EINVAL;
 }
 
-static
 int intel_dp_dsc_max_src_input_bpc(struct intel_display *display)
 {
 	/* Max DSC Input BPC for ICL is 10 and for TGL+ is 12 */
@@ -2183,7 +2182,6 @@ static int dsc_compute_compressed_bpp(struct intel_dp *intel_dp,
 					   dsc_max_bpp, dsc_min_bpp, pipe_bpp, timeslots);
 }
 
-static
 int intel_dp_dsc_min_src_input_bpc(void)
 {
 	/* Min DSC Input BPC for ICL+ is 8 */
diff --git a/drivers/gpu/drm/i915/display/intel_dp.h b/drivers/gpu/drm/i915/display/intel_dp.h
index 4ae54e9718ce..4895b52d41e8 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.h
+++ b/drivers/gpu/drm/i915/display/intel_dp.h
@@ -20,6 +20,7 @@ struct intel_atomic_state;
 struct intel_connector;
 struct intel_crtc_state;
 struct intel_digital_port;
+struct intel_display;
 struct intel_dp;
 struct intel_encoder;
 
@@ -207,5 +208,7 @@ bool intel_dp_link_params_valid(struct intel_dp *intel_dp, int link_rate,
 				u8 lane_count);
 bool intel_dp_has_connector(struct intel_dp *intel_dp,
 			    const struct drm_connector_state *conn_state);
+int intel_dp_dsc_max_src_input_bpc(struct intel_display *display);
+int intel_dp_dsc_min_src_input_bpc(void);
 
 #endif /* __INTEL_DP_H__ */
diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
index 9b64c8a0e55e..795594191717 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
@@ -365,17 +365,14 @@ static int mst_stream_dsc_compute_link_config(struct intel_dp *intel_dp,
 	int i, num_bpc;
 	u8 dsc_bpc[3] = {};
 	int min_bpp, max_bpp, sink_min_bpp, sink_max_bpp;
-	u8 dsc_max_bpc;
+	int dsc_max_bpc, dsc_min_bpc;
 	int min_compressed_bpp, max_compressed_bpp;
 
-	/* Max DSC Input BPC for ICL is 10 and for TGL+ is 12 */
-	if (DISPLAY_VER(display) >= 12)
-		dsc_max_bpc = min_t(u8, 12, conn_state->max_requested_bpc);
-	else
-		dsc_max_bpc = min_t(u8, 10, conn_state->max_requested_bpc);
+	dsc_max_bpc = intel_dp_dsc_max_src_input_bpc(display);
+	dsc_min_bpc = intel_dp_dsc_min_src_input_bpc();
 
-	max_bpp = min_t(u8, dsc_max_bpc * 3, limits->pipe.max_bpp);
-	min_bpp = limits->pipe.min_bpp;
+	max_bpp = min(dsc_max_bpc * 3, limits->pipe.max_bpp);
+	min_bpp = max(dsc_min_bpc * 3, limits->pipe.min_bpp);
 
 	num_bpc = drm_dp_dsc_sink_supported_input_bpcs(connector->dp.dsc_dpcd,
 						       dsc_bpc);
-- 
2.45.2


  parent reply	other threads:[~2024-12-04  9:24 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-04  9:26 [PATCH 00/14] DP DSC min/max src bpc fixes Ankit Nautiyal
2024-12-04  9:26 ` [PATCH 01/14] drm/i915/dp: Refactor FEC support check in intel_dp_supports_dsc Ankit Nautiyal
2024-12-11  4:47   ` Kandpal, Suraj
2024-12-04  9:26 ` [PATCH 02/14] drm/i915/dp: Return early if DSC not supported Ankit Nautiyal
2024-12-04  9:26 ` [PATCH 03/14] drm/i915/dp: Separate out helper for compute fec_enable Ankit Nautiyal
2024-12-05  6:18   ` Kandpal, Suraj
2024-12-04  9:26 ` [PATCH 04/14] drm/i915/dp: Drop check for FEC in intel_dp_fec_compute_config Ankit Nautiyal
2024-12-05  6:26   ` Kandpal, Suraj
2024-12-13 12:28     ` Nautiyal, Ankit K
2024-12-04  9:26 ` [PATCH 05/14] drm/i915/dp: Remove HAS_DSC macro for intel_dp_dsc_max_src_input_bpc Ankit Nautiyal
2024-12-04 16:08   ` Kandpal, Suraj
2024-12-04  9:26 ` [PATCH 06/14] drm/i915/dp: Return int from dsc_max/min_src_input_bpc helpers Ankit Nautiyal
2024-12-04  9:26 ` [PATCH 07/14] drm/i915/dp: Use intel_display in intel_dp_dsc_max_src_input_bpc() Ankit Nautiyal
2024-12-04 16:09   ` Kandpal, Suraj
2024-12-04  9:26 ` Ankit Nautiyal [this message]
2024-12-05  6:29   ` [PATCH 08/14] drm/i915/dp_mst: Use helpers to get dsc min/max input bpc Kandpal, Suraj
2024-12-04  9:26 ` [PATCH 09/14] drm/i915/dp: Drop max_requested_bpc for dsc pipe_min/max bpp Ankit Nautiyal
2024-12-04  9:26 ` [PATCH 10/14] drm/i915/dp: Refactor pipe_bpp limits with dsc Ankit Nautiyal
2024-12-04  9:26 ` [PATCH 11/14] drm/i915/dp_mst: Refactor pipe_bpp limits with dsc for mst Ankit Nautiyal
2024-12-13  9:37   ` Jani Nikula
2024-12-13 12:32     ` Nautiyal, Ankit K
2024-12-04  9:26 ` [PATCH 12/14] drm/i915/dp: Use clamp for pipe_bpp limits with DSC Ankit Nautiyal
2024-12-04  9:26 ` [PATCH 13/14] drm/i915/dp: Make dsc helpers accept const crtc_state pointers Ankit Nautiyal
2024-12-04  9:26 ` [PATCH 14/14] drm/i915/dp: Set the DSC link limits intel_dp_compute_config_link_bpp_limits Ankit Nautiyal
2024-12-11  4:49   ` Kandpal, Suraj
2024-12-04  9:50 ` ✓ CI.Patch_applied: success for DP DSC min/max src bpc fixes (rev3) Patchwork
2024-12-04  9:50 ` ✓ CI.checkpatch: " Patchwork
2024-12-04  9:51 ` ✓ CI.KUnit: " Patchwork
2024-12-04 10:09 ` ✓ CI.Build: " Patchwork
2024-12-04 10:12 ` ✓ CI.Hooks: " Patchwork
2024-12-04 10:13 ` ✗ CI.checksparse: warning " Patchwork
2024-12-04 10:34 ` ✓ Xe.CI.BAT: success " Patchwork
2024-12-04 11:28 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241204092642.1835807-9-ankit.k.nautiyal@intel.com \
    --to=ankit.k.nautiyal@intel.com \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=suraj.kandpal@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox