Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Animesh Manna <animesh.manna@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jouni.hogander@intel.com, jani.nikula@intel.com,
	jeevan.b@intel.com, Animesh Manna <animesh.manna@intel.com>
Subject: [PATCH v4 3/8] drm/i915/lobf: Add fixed refresh rate check in compute_config()
Date: Mon, 24 Feb 2025 13:38:42 +0530	[thread overview]
Message-ID: <20250224080847.326350-4-animesh.manna@intel.com> (raw)
In-Reply-To: <20250224080847.326350-1-animesh.manna@intel.com>

LOBF can be enabled with vrr fixed rate mode, so add check
if vmin = vmax = flipline in compute_config().

Signed-off-by: Animesh Manna <animesh.manna@intel.com>
---
 drivers/gpu/drm/i915/display/intel_alpm.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c b/drivers/gpu/drm/i915/display/intel_alpm.c
index d94c96ba46b1..1438e125cde1 100644
--- a/drivers/gpu/drm/i915/display/intel_alpm.c
+++ b/drivers/gpu/drm/i915/display/intel_alpm.c
@@ -288,6 +288,10 @@ void intel_alpm_lobf_compute_config(struct intel_dp *intel_dp,
 	if (crtc_state->has_psr)
 		return;
 
+	if (!(crtc_state->vrr.vmin == crtc_state->vrr.vmax &&
+	      crtc_state->vrr.vmin == crtc_state->vrr.flipline))
+		return;
+
 	if (!(intel_alpm_aux_wake_supported(intel_dp) ||
 	      intel_alpm_aux_less_wake_supported(intel_dp)))
 		return;
-- 
2.29.0


  parent reply	other threads:[~2025-02-24 13:43 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-24  8:08 [PATCH v4 0/8] LOBF enablement fix Animesh Manna
2025-02-24  8:08 ` [PATCH v4 1/8] drm/i915/lobf: Add lobf enablement in post plane update Animesh Manna
2025-02-24 10:42   ` Jani Nikula
2025-02-25  8:23     ` Manna, Animesh
2025-02-24  8:08 ` [PATCH v4 2/8] drm/i915/lobf: Disintegrate alpm_disable from psr_disable Animesh Manna
2025-02-24 10:45   ` Jani Nikula
2025-02-25  9:02     ` Manna, Animesh
2025-03-03  9:21       ` Manna, Animesh
2025-02-24  8:08 ` Animesh Manna [this message]
2025-02-24 10:46   ` [PATCH v4 3/8] drm/i915/lobf: Add fixed refresh rate check in compute_config() Jani Nikula
2025-02-25  8:25     ` Manna, Animesh
2025-02-24  8:08 ` [PATCH v4 4/8] drm/i915/lobf: Update lobf if any change in dependent parameters Animesh Manna
2025-02-24 10:48   ` Jani Nikula
2025-02-25  6:41     ` Manna, Animesh
2025-02-25  8:02       ` Jani Nikula
2025-02-25  8:22         ` Manna, Animesh
2025-02-24 10:49   ` Jani Nikula
2025-02-25  4:09   ` kernel test robot
2025-02-24  8:08 ` [PATCH v4 5/8] drm/i915/lobf: Add debug interface for lobf Animesh Manna
2025-02-24 10:55   ` Jani Nikula
2025-02-25  8:21     ` Manna, Animesh
2025-02-25  9:15       ` Jani Nikula
2025-02-24  8:08 ` [PATCH v4 6/8] drm/i915/lobf: Check for sink error and disable LOBF Animesh Manna
2025-02-24  8:08 ` [PATCH v4 7/8] drm/i915/lobf: Add mutex for alpm update Animesh Manna
2025-02-26  8:11   ` Dan Carpenter
2025-02-24  8:08 ` [PATCH v4 8/8] drm/i915/lobf: Add debug print for LOBF Animesh Manna
2025-02-24 18:45 ` ✓ CI.Patch_applied: success for LOBF enablement fix (rev3) Patchwork
2025-02-24 18:45 ` ✗ CI.checkpatch: warning " Patchwork
2025-02-24 18:46 ` ✓ CI.KUnit: success " Patchwork
2025-02-24 19:03 ` ✓ CI.Build: " Patchwork
2025-02-24 19:05 ` ✓ CI.Hooks: " Patchwork
2025-02-24 19:07 ` ✗ CI.checksparse: warning " Patchwork
2025-02-24 19:38 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-02-24 20:41 ` ✗ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250224080847.326350-4-animesh.manna@intel.com \
    --to=animesh.manna@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=jeevan.b@intel.com \
    --cc=jouni.hogander@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox