Re: [PATCH v4 3/8] drm/i915/lobf: Add fixed refresh rate check in compute_config()

[Jani Nikula <jani.nikula@intel.com>]

On Mon, 24 Feb 2025, Animesh Manna <animesh.manna@intel.com> wrote:
> LOBF can be enabled with vrr fixed rate mode, so add check
> if vmin = vmax = flipline in compute_config().
>
> Signed-off-by: Animesh Manna <animesh.manna@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_alpm.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c b/drivers/gpu/drm/i915/display/intel_alpm.c
> index d94c96ba46b1..1438e125cde1 100644
> --- a/drivers/gpu/drm/i915/display/intel_alpm.c
> +++ b/drivers/gpu/drm/i915/display/intel_alpm.c
> @@ -288,6 +288,10 @@ void intel_alpm_lobf_compute_config(struct intel_dp *intel_dp,
>  	if (crtc_state->has_psr)
>  		return;
>  
> +	if (!(crtc_state->vrr.vmin == crtc_state->vrr.vmax &&
> +	      crtc_state->vrr.vmin == crtc_state->vrr.flipline))

if vmin != vmax || vmin != flipline, right?


> +		return;
> +
>  	if (!(intel_alpm_aux_wake_supported(intel_dp) ||
>  	      intel_alpm_aux_less_wake_supported(intel_dp)))
>  		return;

-- 
Jani Nikula, Intel