Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Animesh Manna <animesh.manna@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jouni.hogander@intel.com, jani.nikula@intel.com,
	jeevan.b@intel.com, Animesh Manna <animesh.manna@intel.com>
Subject: [PATCH v4 4/8] drm/i915/lobf: Update lobf if any change in dependent parameters
Date: Mon, 24 Feb 2025 13:38:43 +0530	[thread overview]
Message-ID: <20250224080847.326350-5-animesh.manna@intel.com> (raw)
In-Reply-To: <20250224080847.326350-1-animesh.manna@intel.com>

For every commit the dependent condition for LOBF is checked
and accordingly update has_lobf flag which will be used
to update the ALPM_CTL register during commit.

Signed-off-by: Animesh Manna <animesh.manna@intel.com>
---
 drivers/gpu/drm/i915/display/intel_alpm.c | 16 ++++++++++++++++
 drivers/gpu/drm/i915/display/intel_alpm.h |  1 +
 drivers/gpu/drm/i915/display/intel_ddi.c  |  2 ++
 3 files changed, 19 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c b/drivers/gpu/drm/i915/display/intel_alpm.c
index 1438e125cde1..83719ee1721c 100644
--- a/drivers/gpu/drm/i915/display/intel_alpm.c
+++ b/drivers/gpu/drm/i915/display/intel_alpm.c
@@ -312,6 +312,22 @@ void intel_alpm_lobf_compute_config(struct intel_dp *intel_dp,
 		(first_sdp_position + waketime_in_lines);
 }
 
+void intel_alpm_lobf_update(const struct intel_crtc_state *crtc_state)
+{
+	struct intel_display *display = to_intel_display(crtc_state);
+	enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
+	u32 alpm_ctl;
+
+	if (DISPLAY_VER(display) < 20)
+		return;
+
+	alpm_ctl = intel_de_read(display, ALPM_CTL(display, cpu_transcoder));
+	if (alpm_ctl & ALPM_CTL_LOBF_ENABLE && !crtc_state->has_lobf) {
+		alpm_ctl &= ~ALPM_CTL_LOBF_ENABLE;
+		intel_de_write(display, ALPM_CTL(display, cpu_transcoder), alpm_ctl);
+	}
+}
+
 static void lnl_alpm_configure(struct intel_dp *intel_dp,
 			       const struct intel_crtc_state *crtc_state)
 {
diff --git a/drivers/gpu/drm/i915/display/intel_alpm.h b/drivers/gpu/drm/i915/display/intel_alpm.h
index 91f51fb24f98..c6efd25c2062 100644
--- a/drivers/gpu/drm/i915/display/intel_alpm.h
+++ b/drivers/gpu/drm/i915/display/intel_alpm.h
@@ -23,6 +23,7 @@ void intel_alpm_lobf_compute_config(struct intel_dp *intel_dp,
 				    struct drm_connector_state *conn_state);
 void intel_alpm_configure(struct intel_dp *intel_dp,
 			  const struct intel_crtc_state *crtc_state);
+void intel_alpm_lobf_update(const struct intel_crtc_state *crtc_state);
 void intel_alpm_post_plane_update(struct intel_atomic_state *state,
 				  struct intel_crtc *crtc);
 void intel_alpm_lobf_debugfs_add(struct intel_connector *connector);
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index 26aa32d4d50e..44258ba0d951 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -37,6 +37,7 @@
 #include "icl_dsi.h"
 #include "intel_alpm.h"
 #include "intel_audio.h"
+#include "intel_alpm.h"
 #include "intel_audio_regs.h"
 #include "intel_backlight.h"
 #include "intel_combo_phy.h"
@@ -3621,6 +3622,7 @@ static void intel_ddi_update_pipe_dp(struct intel_atomic_state *state,
 	intel_ddi_set_dp_msa(crtc_state, conn_state);
 
 	intel_dp_set_infoframes(encoder, true, crtc_state, conn_state);
+	intel_alpm_lobf_update(crtc_state);
 
 	intel_backlight_update(state, encoder, crtc_state, conn_state);
 	drm_connector_update_privacy_screen(conn_state);
-- 
2.29.0


  parent reply	other threads:[~2025-02-24 13:43 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-24  8:08 [PATCH v4 0/8] LOBF enablement fix Animesh Manna
2025-02-24  8:08 ` [PATCH v4 1/8] drm/i915/lobf: Add lobf enablement in post plane update Animesh Manna
2025-02-24 10:42   ` Jani Nikula
2025-02-25  8:23     ` Manna, Animesh
2025-02-24  8:08 ` [PATCH v4 2/8] drm/i915/lobf: Disintegrate alpm_disable from psr_disable Animesh Manna
2025-02-24 10:45   ` Jani Nikula
2025-02-25  9:02     ` Manna, Animesh
2025-03-03  9:21       ` Manna, Animesh
2025-02-24  8:08 ` [PATCH v4 3/8] drm/i915/lobf: Add fixed refresh rate check in compute_config() Animesh Manna
2025-02-24 10:46   ` Jani Nikula
2025-02-25  8:25     ` Manna, Animesh
2025-02-24  8:08 ` Animesh Manna [this message]
2025-02-24 10:48   ` [PATCH v4 4/8] drm/i915/lobf: Update lobf if any change in dependent parameters Jani Nikula
2025-02-25  6:41     ` Manna, Animesh
2025-02-25  8:02       ` Jani Nikula
2025-02-25  8:22         ` Manna, Animesh
2025-02-24 10:49   ` Jani Nikula
2025-02-25  4:09   ` kernel test robot
2025-02-24  8:08 ` [PATCH v4 5/8] drm/i915/lobf: Add debug interface for lobf Animesh Manna
2025-02-24 10:55   ` Jani Nikula
2025-02-25  8:21     ` Manna, Animesh
2025-02-25  9:15       ` Jani Nikula
2025-02-24  8:08 ` [PATCH v4 6/8] drm/i915/lobf: Check for sink error and disable LOBF Animesh Manna
2025-02-24  8:08 ` [PATCH v4 7/8] drm/i915/lobf: Add mutex for alpm update Animesh Manna
2025-02-26  8:11   ` Dan Carpenter
2025-02-24  8:08 ` [PATCH v4 8/8] drm/i915/lobf: Add debug print for LOBF Animesh Manna
2025-02-24 18:45 ` ✓ CI.Patch_applied: success for LOBF enablement fix (rev3) Patchwork
2025-02-24 18:45 ` ✗ CI.checkpatch: warning " Patchwork
2025-02-24 18:46 ` ✓ CI.KUnit: success " Patchwork
2025-02-24 19:03 ` ✓ CI.Build: " Patchwork
2025-02-24 19:05 ` ✓ CI.Hooks: " Patchwork
2025-02-24 19:07 ` ✗ CI.checksparse: warning " Patchwork
2025-02-24 19:38 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-02-24 20:41 ` ✗ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250224080847.326350-5-animesh.manna@intel.com \
    --to=animesh.manna@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=jeevan.b@intel.com \
    --cc=jouni.hogander@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox