From: Maarten Lankhorst <dev@lankhorst.se>
To: intel-xe@lists.freedesktop.org
Cc: Maarten Lankhorst <dev@lankhorst.se>,
Lucas De Marchi <lucas.demarchi@intel.com>,
Ilia Levi <ilia.levi@intel.com>
Subject: [PATCH 1/8] drm/xe: Defer memirq init until needed
Date: Mon, 10 Mar 2025 21:06:46 +0100 [thread overview]
Message-ID: <20250310200653.89731-2-dev@lankhorst.se> (raw)
In-Reply-To: <20250310200653.89731-1-dev@lankhorst.se>
memirqs require allocations into GGTT, which we cannot use until
after display is enabled.
Now that the initialisation of interrupts is postponed, move memirq
init too.
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Ilia Levi <ilia.levi@intel.com>
Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
---
drivers/gpu/drm/xe/xe_device.c | 4 ----
drivers/gpu/drm/xe/xe_tile.c | 7 +++++++
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index 539da525aa14b..38b8e3e961a2f 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -41,7 +41,6 @@
#include "xe_hw_engine_group.h"
#include "xe_hwmon.h"
#include "xe_irq.h"
-#include "xe_memirq.h"
#include "xe_mmio.h"
#include "xe_module.h"
#include "xe_oa.h"
@@ -795,9 +794,6 @@ int xe_device_probe(struct xe_device *xe)
err = xe_ggtt_init_early(tile->mem.ggtt);
if (err)
return err;
- err = xe_memirq_init(&tile->memirq);
- if (err)
- return err;
}
for_each_gt(gt, xe, id) {
diff --git a/drivers/gpu/drm/xe/xe_tile.c b/drivers/gpu/drm/xe/xe_tile.c
index d29658ff4dd41..be760c7fbfa28 100644
--- a/drivers/gpu/drm/xe/xe_tile.c
+++ b/drivers/gpu/drm/xe/xe_tile.c
@@ -10,6 +10,7 @@
#include "xe_device.h"
#include "xe_ggtt.h"
#include "xe_gt.h"
+#include "xe_memirq.h"
#include "xe_migrate.h"
#include "xe_pcode.h"
#include "xe_sa.h"
@@ -173,6 +174,12 @@ int xe_tile_init_noalloc(struct xe_tile *tile)
int xe_tile_init(struct xe_tile *tile)
{
+ int err;
+
+ err = xe_memirq_init(&tile->memirq);
+ if (err)
+ return err;
+
tile->mem.kernel_bb_pool = xe_sa_bo_manager_init(tile, SZ_1M, 16);
if (IS_ERR(tile->mem.kernel_bb_pool))
return PTR_ERR(tile->mem.kernel_bb_pool);
--
2.45.2
next prev parent reply other threads:[~2025-03-10 20:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 20:06 [PATCH 0/8] drm/xe: GT initialization rework Maarten Lankhorst
2025-03-10 20:06 ` Maarten Lankhorst [this message]
2025-03-10 20:06 ` [PATCH 2/8] drm/xe/sriov: Move VF bootstrap and query_config to vf_guc_init Maarten Lankhorst
2025-03-10 20:06 ` [PATCH 3/8] drm/xe: Simplify GuC early initialization Maarten Lankhorst
2025-03-11 20:48 ` Lucas De Marchi
2025-03-12 10:43 ` Maarten Lankhorst
2025-04-01 19:02 ` Lucas De Marchi
2025-03-10 20:06 ` [PATCH 4/8] drm/xe: Make it possible to read instance0 MCR registers after xe_gt_mcr_init_early Maarten Lankhorst
2025-03-10 20:06 ` [PATCH 5/8] drm/xe: Only dump PAT when xe_hw_engines_init_early fails Maarten Lankhorst
2025-04-01 19:18 ` Lucas De Marchi
2025-03-10 20:06 ` [PATCH 6/8] drm/xe/gt: Inline gt_fw_domain_init Maarten Lankhorst
2025-04-01 19:21 ` Lucas De Marchi
2025-03-10 20:06 ` [PATCH 7/8] drm/xe/gt: Inline all_fw_domain_init Maarten Lankhorst
2025-04-01 19:21 ` Lucas De Marchi
2025-03-10 20:06 ` [PATCH 8/8] drm/xe: Split init of xe_gt_init_hwconfig to xe_gt_init and *_early Maarten Lankhorst
2025-03-11 20:55 ` Lucas De Marchi
2025-03-13 9:19 ` Maarten Lankhorst
2025-03-13 14:28 ` Lucas De Marchi
2025-03-13 19:23 ` Maarten Lankhorst
2025-04-01 18:56 ` Lucas De Marchi
2025-04-01 19:23 ` Lucas De Marchi
2025-03-10 22:57 ` ✓ CI.Patch_applied: success for drm/xe: GT initialization rework Patchwork
2025-03-10 22:57 ` ✗ CI.checkpatch: warning " Patchwork
2025-03-10 22:58 ` ✓ CI.KUnit: success " Patchwork
2025-03-10 23:15 ` ✓ CI.Build: " Patchwork
2025-03-10 23:17 ` ✓ CI.Hooks: " Patchwork
2025-03-10 23:18 ` ✓ CI.checksparse: " Patchwork
2025-03-11 5:58 ` ✓ Xe.CI.BAT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250310200653.89731-2-dev@lankhorst.se \
--to=dev@lankhorst.se \
--cc=ilia.levi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox