Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <dev@lankhorst.se>
To: intel-xe@lists.freedesktop.org
Cc: Maarten Lankhorst <dev@lankhorst.se>
Subject: [PATCH 2/8] drm/xe/sriov: Move VF bootstrap and query_config to vf_guc_init
Date: Mon, 10 Mar 2025 21:06:47 +0100	[thread overview]
Message-ID: <20250310200653.89731-3-dev@lankhorst.se> (raw)
In-Reply-To: <20250310200653.89731-1-dev@lankhorst.se>

We want to split up GUC init to an alloc and noalloc part to keep the
init path the same for VF and !VF as much as possible.

Everything in vf_guc_init should be done as early as possible, otherwise
VRAM probing becomes impossible.

Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
---
 drivers/gpu/drm/xe/xe_gt_sriov_vf.c |  1 -
 drivers/gpu/drm/xe/xe_guc.c         | 17 +++++++++--------
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_gt_sriov_vf.c b/drivers/gpu/drm/xe/xe_gt_sriov_vf.c
index a439261bf4d72..a43dc3844274d 100644
--- a/drivers/gpu/drm/xe/xe_gt_sriov_vf.c
+++ b/drivers/gpu/drm/xe/xe_gt_sriov_vf.c
@@ -974,7 +974,6 @@ u32 xe_gt_sriov_vf_read32(struct xe_gt *gt, struct xe_reg reg)
 	struct vf_runtime_reg *rr;
 
 	xe_gt_assert(gt, IS_SRIOV_VF(gt_to_xe(gt)));
-	xe_gt_assert(gt, gt->sriov.vf.pf_version.major);
 	xe_gt_assert(gt, !reg.vf);
 
 	if (reg.addr == GMD_ID.addr) {
diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c
index bc1ff0a4e1e7d..ecf597f9d80c6 100644
--- a/drivers/gpu/drm/xe/xe_guc.c
+++ b/drivers/gpu/drm/xe/xe_guc.c
@@ -628,6 +628,7 @@ static int xe_guc_realloc_post_hwconfig(struct xe_guc *guc)
 
 static int vf_guc_init(struct xe_guc *guc)
 {
+	struct xe_gt *gt = guc_to_gt(guc);
 	int err;
 
 	xe_guc_comm_init_early(guc);
@@ -640,6 +641,14 @@ static int vf_guc_init(struct xe_guc *guc)
 	if (err)
 		return err;
 
+	err = xe_gt_sriov_vf_bootstrap(gt);
+	if (err)
+		return err;
+
+	err = xe_gt_sriov_vf_query_config(gt);
+	if (err)
+		return err;
+
 	return 0;
 }
 
@@ -1097,14 +1106,6 @@ static int vf_guc_min_load_for_hwconfig(struct xe_guc *guc)
 	struct xe_gt *gt = guc_to_gt(guc);
 	int ret;
 
-	ret = xe_gt_sriov_vf_bootstrap(gt);
-	if (ret)
-		return ret;
-
-	ret = xe_gt_sriov_vf_query_config(gt);
-	if (ret)
-		return ret;
-
 	ret = xe_guc_hwconfig_init(guc);
 	if (ret)
 		return ret;
-- 
2.45.2


  parent reply	other threads:[~2025-03-10 20:07 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-10 20:06 [PATCH 0/8] drm/xe: GT initialization rework Maarten Lankhorst
2025-03-10 20:06 ` [PATCH 1/8] drm/xe: Defer memirq init until needed Maarten Lankhorst
2025-03-10 20:06 ` Maarten Lankhorst [this message]
2025-03-10 20:06 ` [PATCH 3/8] drm/xe: Simplify GuC early initialization Maarten Lankhorst
2025-03-11 20:48   ` Lucas De Marchi
2025-03-12 10:43     ` Maarten Lankhorst
2025-04-01 19:02       ` Lucas De Marchi
2025-03-10 20:06 ` [PATCH 4/8] drm/xe: Make it possible to read instance0 MCR registers after xe_gt_mcr_init_early Maarten Lankhorst
2025-03-10 20:06 ` [PATCH 5/8] drm/xe: Only dump PAT when xe_hw_engines_init_early fails Maarten Lankhorst
2025-04-01 19:18   ` Lucas De Marchi
2025-03-10 20:06 ` [PATCH 6/8] drm/xe/gt: Inline gt_fw_domain_init Maarten Lankhorst
2025-04-01 19:21   ` Lucas De Marchi
2025-03-10 20:06 ` [PATCH 7/8] drm/xe/gt: Inline all_fw_domain_init Maarten Lankhorst
2025-04-01 19:21   ` Lucas De Marchi
2025-03-10 20:06 ` [PATCH 8/8] drm/xe: Split init of xe_gt_init_hwconfig to xe_gt_init and *_early Maarten Lankhorst
2025-03-11 20:55   ` Lucas De Marchi
2025-03-13  9:19     ` Maarten Lankhorst
2025-03-13 14:28       ` Lucas De Marchi
2025-03-13 19:23         ` Maarten Lankhorst
2025-04-01 18:56           ` Lucas De Marchi
2025-04-01 19:23   ` Lucas De Marchi
2025-03-10 22:57 ` ✓ CI.Patch_applied: success for drm/xe: GT initialization rework Patchwork
2025-03-10 22:57 ` ✗ CI.checkpatch: warning " Patchwork
2025-03-10 22:58 ` ✓ CI.KUnit: success " Patchwork
2025-03-10 23:15 ` ✓ CI.Build: " Patchwork
2025-03-10 23:17 ` ✓ CI.Hooks: " Patchwork
2025-03-10 23:18 ` ✓ CI.checksparse: " Patchwork
2025-03-11  5:58 ` ✓ Xe.CI.BAT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250310200653.89731-3-dev@lankhorst.se \
    --to=dev@lankhorst.se \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox