Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael J. Ruhl" <michael.j.ruhl@intel.com>
To: platform-driver-x86@vger.kernel.org,
	intel-xe@lists.freedesktop.org, hdegoede@redhat.com,
	ilpo.jarvinen@linux.intel.com, lucas.demarchi@intel.com,
	rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com,
	airlied@gmail.com, simona@ffwll.ch, david.e.box@linux.intel.com
Cc: "Michael J. Ruhl" <michael.j.ruhl@intel.com>
Subject: [PATCH v5 02/12] drm/xe: Correct BMG VSEC header sizing
Date: Fri, 27 Jun 2025 16:43:11 -0400	[thread overview]
Message-ID: <20250627204321.521628-3-michael.j.ruhl@intel.com> (raw)
In-Reply-To: <20250627204321.521628-1-michael.j.ruhl@intel.com>

The intel_vsec_header information for the crashlog feature is
incorrect.

Update the VSEC header with correct sizing and count.

Since the crashlog entries are "merged" (num_entries = 2), the
separate capabilities entries must be merged as well.

Fixes: 0c45e76fcc62 ("drm/xe/vsec: Support BMG devices")
Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
---
 drivers/gpu/drm/xe/xe_vsec.c | 20 +++++---------------
 1 file changed, 5 insertions(+), 15 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c
index 3e573b0b7ebd..67238fc57a4d 100644
--- a/drivers/gpu/drm/xe/xe_vsec.c
+++ b/drivers/gpu/drm/xe/xe_vsec.c
@@ -32,28 +32,18 @@ static struct intel_vsec_header bmg_telemetry = {
 	.offset = BMG_DISCOVERY_OFFSET,
 };
 
-static struct intel_vsec_header bmg_punit_crashlog = {
-	.length = 0x10,
+static struct intel_vsec_header bmg_crashlog = {
+	.length = 0x18,
 	.id = VSEC_ID_CRASHLOG,
-	.num_entries = 1,
-	.entry_size = 4,
+	.num_entries = 2,
+	.entry_size = 6,
 	.tbir = 0,
 	.offset = BMG_DISCOVERY_OFFSET + 0x60,
 };
 
-static struct intel_vsec_header bmg_oobmsm_crashlog = {
-	.length = 0x10,
-	.id = VSEC_ID_CRASHLOG,
-	.num_entries = 1,
-	.entry_size = 4,
-	.tbir = 0,
-	.offset = BMG_DISCOVERY_OFFSET + 0x78,
-};
-
 static struct intel_vsec_header *bmg_capabilities[] = {
 	&bmg_telemetry,
-	&bmg_punit_crashlog,
-	&bmg_oobmsm_crashlog,
+	&bmg_crashlog,
 	NULL
 };
 
-- 
2.49.0


  parent reply	other threads:[~2025-06-27 20:43 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-27 20:43 [PATCH v5 00/12] Crashlog Type1 Version2 support Michael J. Ruhl
2025-06-27 20:43 ` [PATCH v5 01/12] platform/x86/intel/pmt: fix a crashlog NULL pointer access Michael J. Ruhl
2025-06-30  9:29   ` Ilpo Järvinen
2025-06-30 15:00     ` Ruhl, Michael J
2025-06-27 20:43 ` Michael J. Ruhl [this message]
2025-06-30 19:57   ` [PATCH v5 02/12] drm/xe: Correct BMG VSEC header sizing Rodrigo Vivi
2025-06-30 22:00     ` Ruhl, Michael J
2025-06-27 20:43 ` [PATCH v5 03/12] platform/x86/intel/pmt: white space cleanup Michael J. Ruhl
2025-06-27 20:43 ` [PATCH v5 04/12] platform/x86/intel/pmt: mutex clean up Michael J. Ruhl
2025-06-27 20:43 ` [PATCH v5 05/12] platform/x86/intel/pmt: use guard(mutex) Michael J. Ruhl
2025-06-27 20:43 ` [PATCH v5 06/12] platform/x86/intel/pmt: re-order trigger logic Michael J. Ruhl
2025-06-27 20:43 ` [PATCH v5 07/12] platform/x86/intel/pmt: correct types Michael J. Ruhl
2025-06-27 20:43 ` [PATCH v5 08/12] platform/x86/intel/pmt: decouple sysfs and namespace Michael J. Ruhl
2025-06-27 20:43 ` [PATCH v5 09/12] platform/x86/intel/pmt: add register access helpers Michael J. Ruhl
2025-07-02 15:50   ` Ruhl, Michael J
2025-06-27 20:43 ` [PATCH v5 10/12] platform/x86/intel/pmt: refactor base parameter Michael J. Ruhl
2025-06-27 20:43 ` [PATCH v5 11/12] platform/x86/intel/pmt: use a version struct Michael J. Ruhl
2025-06-27 20:43 ` [PATCH v5 12/12] platform/x86/intel/pmt: support BMG crashlog Michael J. Ruhl
2025-06-30 20:36 ` ✓ CI.KUnit: success for Crashlog Type1 Version2 support (rev5) Patchwork
2025-06-30 21:42 ` ✓ Xe.CI.BAT: " Patchwork
2025-07-02  3:19 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250627204321.521628-3-michael.j.ruhl@intel.com \
    --to=michael.j.ruhl@intel.com \
    --cc=airlied@gmail.com \
    --cc=david.e.box@linux.intel.com \
    --cc=hdegoede@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=simona@ffwll.ch \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox