From: "Michael J. Ruhl" <michael.j.ruhl@intel.com>
To: platform-driver-x86@vger.kernel.org,
intel-xe@lists.freedesktop.org, hdegoede@redhat.com,
ilpo.jarvinen@linux.intel.com, lucas.demarchi@intel.com,
rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com,
airlied@gmail.com, simona@ffwll.ch, david.e.box@linux.intel.com
Cc: "Michael J. Ruhl" <michael.j.ruhl@intel.com>
Subject: [PATCH v5 07/12] platform/x86/intel/pmt: correct types
Date: Fri, 27 Jun 2025 16:43:16 -0400 [thread overview]
Message-ID: <20250627204321.521628-8-michael.j.ruhl@intel.com> (raw)
In-Reply-To: <20250627204321.521628-1-michael.j.ruhl@intel.com>
A couple of auto variables do not match the return types of some of
the functions.
Update the mismatched types to match.
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: David E. Box <david.e.box@linux.intel.com>
Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
---
drivers/platform/x86/intel/pmt/crashlog.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/intel/pmt/crashlog.c b/drivers/platform/x86/intel/pmt/crashlog.c
index 440d2045e90d..881f4abdae14 100644
--- a/drivers/platform/x86/intel/pmt/crashlog.c
+++ b/drivers/platform/x86/intel/pmt/crashlog.c
@@ -138,7 +138,7 @@ static ssize_t
enable_show(struct device *dev, struct device_attribute *attr, char *buf)
{
struct intel_pmt_entry *entry = dev_get_drvdata(dev);
- int enabled = !pmt_crashlog_disabled(entry);
+ bool enabled = !pmt_crashlog_disabled(entry);
return sprintf(buf, "%d\n", enabled);
}
@@ -169,7 +169,7 @@ static ssize_t
trigger_show(struct device *dev, struct device_attribute *attr, char *buf)
{
struct intel_pmt_entry *entry;
- int trigger;
+ bool trigger;
entry = dev_get_drvdata(dev);
trigger = pmt_crashlog_complete(entry);
--
2.49.0
next prev parent reply other threads:[~2025-06-27 20:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 20:43 [PATCH v5 00/12] Crashlog Type1 Version2 support Michael J. Ruhl
2025-06-27 20:43 ` [PATCH v5 01/12] platform/x86/intel/pmt: fix a crashlog NULL pointer access Michael J. Ruhl
2025-06-30 9:29 ` Ilpo Järvinen
2025-06-30 15:00 ` Ruhl, Michael J
2025-06-27 20:43 ` [PATCH v5 02/12] drm/xe: Correct BMG VSEC header sizing Michael J. Ruhl
2025-06-30 19:57 ` Rodrigo Vivi
2025-06-30 22:00 ` Ruhl, Michael J
2025-06-27 20:43 ` [PATCH v5 03/12] platform/x86/intel/pmt: white space cleanup Michael J. Ruhl
2025-06-27 20:43 ` [PATCH v5 04/12] platform/x86/intel/pmt: mutex clean up Michael J. Ruhl
2025-06-27 20:43 ` [PATCH v5 05/12] platform/x86/intel/pmt: use guard(mutex) Michael J. Ruhl
2025-06-27 20:43 ` [PATCH v5 06/12] platform/x86/intel/pmt: re-order trigger logic Michael J. Ruhl
2025-06-27 20:43 ` Michael J. Ruhl [this message]
2025-06-27 20:43 ` [PATCH v5 08/12] platform/x86/intel/pmt: decouple sysfs and namespace Michael J. Ruhl
2025-06-27 20:43 ` [PATCH v5 09/12] platform/x86/intel/pmt: add register access helpers Michael J. Ruhl
2025-07-02 15:50 ` Ruhl, Michael J
2025-06-27 20:43 ` [PATCH v5 10/12] platform/x86/intel/pmt: refactor base parameter Michael J. Ruhl
2025-06-27 20:43 ` [PATCH v5 11/12] platform/x86/intel/pmt: use a version struct Michael J. Ruhl
2025-06-27 20:43 ` [PATCH v5 12/12] platform/x86/intel/pmt: support BMG crashlog Michael J. Ruhl
2025-06-30 20:36 ` ✓ CI.KUnit: success for Crashlog Type1 Version2 support (rev5) Patchwork
2025-06-30 21:42 ` ✓ Xe.CI.BAT: " Patchwork
2025-07-02 3:19 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250627204321.521628-8-michael.j.ruhl@intel.com \
--to=michael.j.ruhl@intel.com \
--cc=airlied@gmail.com \
--cc=david.e.box@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox