Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
To: intel-xe@lists.freedesktop.org
Cc: kernel-dev@igalia.com, Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Subject: [PATCH v13 07/12] drm/xe: Export xe_emit_aux_table_inv
Date: Mon, 20 Oct 2025 08:58:25 +0100	[thread overview]
Message-ID: <20251020075831.32818-8-tvrtko.ursulin@igalia.com> (raw)
In-Reply-To: <20251020075831.32818-1-tvrtko.ursulin@igalia.com>

Export the existing AuxCCS invalidation ring buffer programming helper
which we will need to use to setup the indirect context workaround in the
next patch.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
---
 drivers/gpu/drm/xe/xe_ring_ops.c | 77 +++++++++++++++++++-------------
 drivers/gpu/drm/xe/xe_ring_ops.h |  3 ++
 2 files changed, 49 insertions(+), 31 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_ring_ops.c b/drivers/gpu/drm/xe/xe_ring_ops.c
index 071c45abda2a..3cbd192df0c4 100644
--- a/drivers/gpu/drm/xe/xe_ring_ops.c
+++ b/drivers/gpu/drm/xe/xe_ring_ops.c
@@ -50,22 +50,51 @@ static u32 preparser_disable(bool state)
 	return MI_ARB_CHECK | BIT(8) | state;
 }
 
-static int emit_aux_table_inv(struct xe_gt *gt, struct xe_reg reg,
-			      u32 *dw, int i)
+u32 *xe_emit_aux_table_inv(struct xe_hw_engine *hwe, u32 *cmd)
 {
-	dw[i++] = MI_LOAD_REGISTER_IMM | MI_LRI_NUM_REGS(1) | MI_LRI_MMIO_REMAP_EN;
-	dw[i++] = reg.addr + gt->mmio.adj_offset;
-	dw[i++] = AUX_INV;
-	dw[i++] = MI_SEMAPHORE_WAIT_TOKEN |
-		  MI_SEMAPHORE_REGISTER_POLL |
-		  MI_SEMAPHORE_POLL |
-		  MI_SEMAPHORE_SAD_EQ_SDD;
-	dw[i++] = 0;
-	dw[i++] = reg.addr + gt->mmio.adj_offset;
-	dw[i++] = 0;
-	dw[i++] = 0;
+	struct xe_gt *gt = hwe->gt;
+	struct xe_reg reg;
 
-	return i;
+	switch (hwe->class) {
+	case XE_ENGINE_CLASS_RENDER:
+	case XE_ENGINE_CLASS_COMPUTE:
+		reg = CCS_AUX_INV;
+		break;
+	case XE_ENGINE_CLASS_COPY:
+		reg = BCS_AUX_INV;
+		break;
+	case XE_ENGINE_CLASS_VIDEO_DECODE:
+		reg = VD0_AUX_INV;
+		break;
+	case XE_ENGINE_CLASS_VIDEO_ENHANCE:
+		reg = VE0_AUX_INV;
+		break;
+	default:
+		return cmd;
+	};
+
+	*cmd++ = MI_LOAD_REGISTER_IMM | MI_LRI_NUM_REGS(1) |
+		 MI_LRI_MMIO_REMAP_EN;
+	*cmd++ = reg.addr + gt->mmio.adj_offset;
+	*cmd++ = AUX_INV;
+	*cmd++ = MI_SEMAPHORE_WAIT_TOKEN | MI_SEMAPHORE_REGISTER_POLL |
+		 MI_SEMAPHORE_POLL | MI_SEMAPHORE_SAD_EQ_SDD;
+	*cmd++ = 0;
+	*cmd++ = reg.addr + gt->mmio.adj_offset;
+	*cmd++ = 0;
+	*cmd++ = 0;
+
+	return cmd;
+}
+
+static int emit_aux_table_inv(struct xe_hw_engine *hwe, u32 *dw, int i)
+{
+	u32 *start, *end;
+
+	start = dw + i;
+	end = xe_emit_aux_table_inv(hwe, start);
+
+	return i + (end - start);
 }
 
 static int emit_user_interrupt(u32 *dw, int i)
@@ -293,22 +322,8 @@ static void __emit_job_gen12_xcs(struct xe_sched_job *job, struct xe_lrc *lrc,
 					seqno, MI_INVALIDATE_TLB | flags, dw,
 					i);
 		/* hsdes: 1809175790 */
-		if (aux_ccs) {
-			struct xe_reg reg;
-
-			switch (job->q->class) {
-			case XE_ENGINE_CLASS_COPY:
-				reg = BCS_AUX_INV;
-				break;
-			case XE_ENGINE_CLASS_VIDEO_DECODE:
-				reg = VD0_AUX_INV;
-				break;
-			default:
-				reg = VE0_AUX_INV;
-			};
-
-			i = emit_aux_table_inv(gt, reg, dw, i);
-		}
+		if (aux_ccs)
+			i = emit_aux_table_inv(job->q->hwe, dw, i);
 		dw[i++] = preparser_disable(false);
 	} else {
 		i = emit_store_imm_ggtt(xe_lrc_start_seqno_ggtt_addr(lrc),
@@ -368,7 +383,7 @@ static void __emit_job_gen12_render_compute(struct xe_sched_job *job,
 
 	/* hsdes: 1809175790 */
 	if (aux_ccs)
-		i = emit_aux_table_inv(gt, CCS_AUX_INV, dw, i);
+		i = emit_aux_table_inv(job->q->hwe, dw, i);
 
 	dw[i++] = preparser_disable(false);
 
diff --git a/drivers/gpu/drm/xe/xe_ring_ops.h b/drivers/gpu/drm/xe/xe_ring_ops.h
index e942735d76a6..5a2d32f9bb25 100644
--- a/drivers/gpu/drm/xe/xe_ring_ops.h
+++ b/drivers/gpu/drm/xe/xe_ring_ops.h
@@ -10,8 +10,11 @@
 #include "xe_ring_ops_types.h"
 
 struct xe_gt;
+struct xe_hw_engine;
 
 const struct xe_ring_ops *
 xe_ring_ops_get(struct xe_gt *gt, enum xe_engine_class class);
 
+u32 *xe_emit_aux_table_inv(struct xe_hw_engine *hwe, u32 *cmd);
+
 #endif
-- 
2.48.0


  parent reply	other threads:[~2025-10-20  7:58 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-20  7:58 [PATCH v13 00/12] AuxCCS handling and render compression modifiers Tvrtko Ursulin
2025-10-20  7:58 ` [PATCH v13 01/12] drm/xe: Fix ggtt fb alignment Tvrtko Ursulin
2025-10-20  7:58 ` [PATCH v13 02/12] drm/xe/xelpg: Flush CCS when flushing caches Tvrtko Ursulin
2025-10-20 11:27   ` Ville Syrjälä
2025-10-20  7:58 ` [PATCH v13 03/12] drm/xe/xelp: Quiesce memory traffic before invalidating AuxCCS Tvrtko Ursulin
2025-10-20  7:58 ` [PATCH v13 04/12] drm/xe/xelp: Support auxccs invalidation on blitter Tvrtko Ursulin
2025-10-22 22:58   ` Matt Roper
2025-10-23  7:51     ` Tvrtko Ursulin
2025-10-23 17:10       ` Matt Roper
2025-10-24 10:50         ` Tvrtko Ursulin
2025-10-20  7:58 ` [PATCH v13 05/12] drm/xe/xelp: Use MI_FLUSH_DW_CCS on auxccs platforms Tvrtko Ursulin
2025-10-22 23:13   ` Matt Roper
2025-10-23  7:55     ` Tvrtko Ursulin
2025-10-23 17:14       ` Matt Roper
2025-10-20  7:58 ` [PATCH v13 06/12] drm/xe/xelp: Wait for AuxCCS invalidation to complete Tvrtko Ursulin
2025-10-20  7:58 ` Tvrtko Ursulin [this message]
2025-10-20  7:58 ` [PATCH v13 08/12] drm/xe/xelp: Add AuxCCS invalidation to the indirect context workarounds Tvrtko Ursulin
2025-10-20 11:31   ` Ville Syrjälä
2025-10-20 15:13     ` Tvrtko Ursulin
2025-10-20  7:58 ` [PATCH v13 09/12] drm/xe: Flush GGTT writes after populating DPT Tvrtko Ursulin
2025-10-20  7:58 ` [PATCH v13 10/12] drm/xe: Handle DPT in system memory Tvrtko Ursulin
2025-10-20  7:58 ` [PATCH v13 11/12] drm/xe/display: Add support for AuxCCS Tvrtko Ursulin
2025-10-20  7:58 ` [PATCH v13 12/12] drm/i915/display: Expose AuxCCS frame buffer modifiers for Xe Tvrtko Ursulin
2025-10-20 11:46 ` ✗ CI.checkpatch: warning for AuxCCS handling and render compression modifiers Patchwork
2025-10-20 11:47 ` ✓ CI.KUnit: success " Patchwork
2025-10-20 12:32 ` ✓ Xe.CI.BAT: " Patchwork
2025-10-20 14:52 ` ✗ Xe.CI.Full: failure " Patchwork
2025-10-20 15:03   ` Tvrtko Ursulin
2025-10-20 16:35 ` ✗ CI.checkpatch: warning for AuxCCS handling and render compression modifiers (rev2) Patchwork
2025-10-20 16:37 ` ✓ CI.KUnit: success " Patchwork
2025-10-20 22:10 ` ✗ Xe.CI.Full: failure " Patchwork
2025-10-21 16:02 ` ✗ CI.checkpatch: warning for AuxCCS handling and render compression modifiers (rev3) Patchwork
2025-10-21 16:03 ` ✓ CI.KUnit: success " Patchwork
2025-10-21 16:47 ` ✓ Xe.CI.BAT: " Patchwork
2025-10-21 19:39 ` ✗ Xe.CI.Full: failure " Patchwork
2025-10-22  7:36   ` Tvrtko Ursulin
2025-10-22 18:01 ` ✗ CI.checkpatch: warning for AuxCCS handling and render compression modifiers (rev4) Patchwork
2025-10-22 18:02 ` ✓ CI.KUnit: success " Patchwork
2025-10-22 18:40 ` ✓ Xe.CI.BAT: " Patchwork
2025-10-22 22:10 ` ✗ Xe.CI.Full: failure " Patchwork
2025-10-23 10:54 ` ✗ CI.checkpatch: warning for AuxCCS handling and render compression modifiers (rev5) Patchwork
2025-10-23 10:56 ` ✓ CI.KUnit: success " Patchwork
2025-10-23 12:15 ` ✓ Xe.CI.BAT: " Patchwork
2025-10-23 18:58 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251020075831.32818-8-tvrtko.ursulin@igalia.com \
    --to=tvrtko.ursulin@igalia.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=kernel-dev@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox