From: Raag Jadav <raag.jadav@intel.com>
To: lucas.demarchi@intel.com, rodrigo.vivi@intel.com
Cc: intel-xe@lists.freedesktop.org, riana.tauro@intel.com,
daniele.ceraolospurio@intel.com, matthew.brost@intel.com,
michal.wajdeczko@intel.com, badal.nilawar@intel.com,
Raag Jadav <raag.jadav@intel.com>
Subject: [PATCH v6 3/4] drm/xe/pm: Assert on runtime suspend if VFs are enabled
Date: Wed, 22 Oct 2025 15:12:45 +0530 [thread overview]
Message-ID: <20251022094246.3584785-4-raag.jadav@intel.com> (raw)
In-Reply-To: <20251022094246.3584785-1-raag.jadav@intel.com>
We hold an additional reference to the runtime PM to keep PF in D0
during VFs lifetime, as our VFs do not implement the PM capability.
This means we should never be runtime suspending as long as VFs are
enabled.
Suggested-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
drivers/gpu/drm/xe/xe_pci.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
index c326430e75b5..c2939faa2296 100644
--- a/drivers/gpu/drm/xe/xe_pci.c
+++ b/drivers/gpu/drm/xe/xe_pci.c
@@ -1132,6 +1132,14 @@ static int xe_pci_runtime_suspend(struct device *dev)
struct xe_device *xe = pdev_to_xe_device(pdev);
int err;
+ /*
+ * We hold an additional reference to the runtime PM to keep PF in D0
+ * during VFs lifetime, as our VFs do not implement the PM capability.
+ * This means we should never be runtime suspending as long as VFs are
+ * enabled.
+ */
+ xe_assert(xe, !pci_num_vf(pdev));
+
err = xe_pm_runtime_suspend(xe);
if (err)
return err;
--
2.34.1
next prev parent reply other threads:[~2025-10-22 9:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 9:42 [PATCH v6 0/4] Introduce GT runtime suspend/resume Raag Jadav
2025-10-22 9:42 ` [PATCH v6 1/4] drm/xe/vf: Update pause/unpause() helpers with VF naming Raag Jadav
2025-10-22 15:23 ` Matthew Brost
2025-10-22 17:01 ` Raag Jadav
2025-10-22 17:16 ` Matthew Brost
2025-10-22 15:29 ` Michal Wajdeczko
2025-10-22 9:42 ` [PATCH v6 2/4] drm/xe/guc_submit: Bring back pause/unpause() helpers Raag Jadav
2025-10-22 15:31 ` Matthew Brost
2025-10-22 9:42 ` Raag Jadav [this message]
2025-10-22 9:42 ` [PATCH v6 4/4] drm/xe/gt: Introduce runtime suspend/resume Raag Jadav
2025-10-22 15:38 ` Matthew Brost
2025-10-22 12:36 ` ✓ CI.KUnit: success for Introduce GT runtime suspend/resume (rev4) Patchwork
2025-10-22 14:00 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-10-22 15:38 ` ✗ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251022094246.3584785-4-raag.jadav@intel.com \
--to=raag.jadav@intel.com \
--cc=badal.nilawar@intel.com \
--cc=daniele.ceraolospurio@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=matthew.brost@intel.com \
--cc=michal.wajdeczko@intel.com \
--cc=riana.tauro@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox