Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: Raag Jadav <raag.jadav@intel.com>, <lucas.demarchi@intel.com>,
	<rodrigo.vivi@intel.com>, <matthew.brost@intel.com>
Cc: <intel-xe@lists.freedesktop.org>, <riana.tauro@intel.com>,
	<daniele.ceraolospurio@intel.com>, <badal.nilawar@intel.com>
Subject: Re: [PATCH v6 1/4] drm/xe/vf: Update pause/unpause() helpers with VF naming
Date: Wed, 22 Oct 2025 17:29:58 +0200	[thread overview]
Message-ID: <ba0ab63e-a552-4a25-8900-e01bac7b2408@intel.com> (raw)
In-Reply-To: <20251022094246.3584785-2-raag.jadav@intel.com>



On 10/22/2025 11:42 AM, Raag Jadav wrote:
> Now that pause/unpause() helpers have been updated for VF migration
> usecase, update their naming to match the functionality.
> 
> Suggested-by: Matthew Brost <matthew.brost@intel.com>
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> ---

...

> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.h b/drivers/gpu/drm/xe/xe_guc_submit.h
> index b49a2748ec46..cb5cc2cc9497 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.h
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.h
> @@ -20,10 +20,10 @@ int xe_guc_submit_reset_prepare(struct xe_guc *guc);
>  void xe_guc_submit_reset_wait(struct xe_guc *guc);
>  void xe_guc_submit_stop(struct xe_guc *guc);
>  int xe_guc_submit_start(struct xe_guc *guc);
> -void xe_guc_submit_pause(struct xe_guc *guc);
> -void xe_guc_submit_unpause(struct xe_guc *guc);
> -void xe_guc_submit_unpause_prepare(struct xe_guc *guc);
>  void xe_guc_submit_pause_abort(struct xe_guc *guc);
> +void xe_guc_submit_vf_pause(struct xe_guc *guc);
> +void xe_guc_submit_vf_unpause(struct xe_guc *guc);
> +void xe_guc_submit_vf_unpause_prepare(struct xe_guc *guc);

can we have this "vf" as a suffix instead?

   void xe_guc_submit_pause_vf(struct xe_guc *guc);
   void xe_guc_submit_unpause_vf(struct xe_guc *guc);
   void xe_guc_submit_unpause_prepare_vf(struct xe_guc *guc);




  parent reply	other threads:[~2025-10-22 15:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-22  9:42 [PATCH v6 0/4] Introduce GT runtime suspend/resume Raag Jadav
2025-10-22  9:42 ` [PATCH v6 1/4] drm/xe/vf: Update pause/unpause() helpers with VF naming Raag Jadav
2025-10-22 15:23   ` Matthew Brost
2025-10-22 17:01     ` Raag Jadav
2025-10-22 17:16       ` Matthew Brost
2025-10-22 15:29   ` Michal Wajdeczko [this message]
2025-10-22  9:42 ` [PATCH v6 2/4] drm/xe/guc_submit: Bring back pause/unpause() helpers Raag Jadav
2025-10-22 15:31   ` Matthew Brost
2025-10-22  9:42 ` [PATCH v6 3/4] drm/xe/pm: Assert on runtime suspend if VFs are enabled Raag Jadav
2025-10-22  9:42 ` [PATCH v6 4/4] drm/xe/gt: Introduce runtime suspend/resume Raag Jadav
2025-10-22 15:38   ` Matthew Brost
2025-10-22 12:36 ` ✓ CI.KUnit: success for Introduce GT runtime suspend/resume (rev4) Patchwork
2025-10-22 14:00 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-10-22 15:38 ` ✗ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba0ab63e-a552-4a25-8900-e01bac7b2408@intel.com \
    --to=michal.wajdeczko@intel.com \
    --cc=badal.nilawar@intel.com \
    --cc=daniele.ceraolospurio@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=matthew.brost@intel.com \
    --cc=raag.jadav@intel.com \
    --cc=riana.tauro@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox