Re: [PATCH v6 1/4] drm/xe/vf: Update pause/unpause() helpers with VF naming

[Matthew Brost <matthew.brost@intel.com>]

On Wed, Oct 22, 2025 at 03:12:43PM +0530, Raag Jadav wrote:
> Now that pause/unpause() helpers have been updated for VF migration
> usecase, update their naming to match the functionality.
> 
> Suggested-by: Matthew Brost <matthew.brost@intel.com>
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_gt_sriov_vf.c |  6 +++---
>  drivers/gpu/drm/xe/xe_guc_submit.c  | 12 ++++++------
>  drivers/gpu/drm/xe/xe_guc_submit.h  |  6 +++---
>  3 files changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt_sriov_vf.c b/drivers/gpu/drm/xe/xe_gt_sriov_vf.c
> index 46518e629ba3..fca96556335a 100644
> --- a/drivers/gpu/drm/xe/xe_gt_sriov_vf.c
> +++ b/drivers/gpu/drm/xe/xe_gt_sriov_vf.c
> @@ -1129,7 +1129,7 @@ static bool vf_post_migration_shutdown(struct xe_gt *gt)
>  	spin_unlock_irq(&gt->sriov.vf.migration.lock);
>  
>  	xe_guc_ct_flush_and_stop(&gt->uc.guc.ct);
> -	xe_guc_submit_pause(&gt->uc.guc);
> +	xe_guc_submit_vf_pause(&gt->uc.guc);
>  	xe_tlb_inval_reset(&gt->tlb_inval);
>  
>  	return false;
> @@ -1164,12 +1164,12 @@ static int vf_post_migration_fixups(struct xe_gt *gt)
>  static void vf_post_migration_rearm(struct xe_gt *gt)
>  {
>  	xe_guc_ct_restart(&gt->uc.guc.ct);
> -	xe_guc_submit_unpause_prepare(&gt->uc.guc);
> +	xe_guc_submit_vf_unpause_prepare(&gt->uc.guc);
>  }
>  
>  static void vf_post_migration_kickstart(struct xe_gt *gt)
>  {
> -	xe_guc_submit_unpause(&gt->uc.guc);
> +	xe_guc_submit_vf_unpause(&gt->uc.guc);
>  }
>  
>  static void vf_post_migration_abort(struct xe_gt *gt)
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index 0ef67d3523a7..8fbb6b27095d 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -2162,10 +2162,10 @@ static void guc_exec_queue_pause(struct xe_guc *guc, struct xe_exec_queue *q)
>  }
>  
>  /**
> - * xe_guc_submit_pause - Stop further runs of submission tasks on given GuC.
> + * xe_guc_submit_vf_pause - Stop further runs of submission tasks for VF.
>   * @guc: the &xe_guc struct instance whose scheduler is to be disabled
>   */
> -void xe_guc_submit_pause(struct xe_guc *guc)
> +void xe_guc_submit_vf_pause(struct xe_guc *guc)
>  {
>  	struct xe_exec_queue *q;
>  	unsigned long index;

Can we now have xe_gt_assert in the renamed functions that IS_SRIOV_VF
is true?

Feel free add those in next rev and retain:

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> @@ -2259,10 +2259,10 @@ static void guc_exec_queue_unpause_prepare(struct xe_guc *guc,
>  }
>  
>  /**
> - * xe_guc_submit_unpause_prepare - Prepare unpause submission tasks on given GuC.
> + * xe_guc_submit_vf_unpause_prepare - Prepare unpause submission tasks for VF.
>   * @guc: the &xe_guc struct instance whose scheduler is to be prepared for unpause
>   */
> -void xe_guc_submit_unpause_prepare(struct xe_guc *guc)
> +void xe_guc_submit_vf_unpause_prepare(struct xe_guc *guc)
>  {
>  	struct xe_exec_queue *q;
>  	unsigned long index;
> @@ -2334,10 +2334,10 @@ static void guc_exec_queue_unpause(struct xe_guc *guc, struct xe_exec_queue *q)
>  }
>  
>  /**
> - * xe_guc_submit_unpause - Allow further runs of submission tasks on given GuC.
> + * xe_guc_submit_vf_unpause - Allow further runs of submission tasks for VF.
>   * @guc: the &xe_guc struct instance whose scheduler is to be enabled
>   */
> -void xe_guc_submit_unpause(struct xe_guc *guc)
> +void xe_guc_submit_vf_unpause(struct xe_guc *guc)
>  {
>  	struct xe_exec_queue *q;
>  	unsigned long index;
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.h b/drivers/gpu/drm/xe/xe_guc_submit.h
> index b49a2748ec46..cb5cc2cc9497 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.h
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.h
> @@ -20,10 +20,10 @@ int xe_guc_submit_reset_prepare(struct xe_guc *guc);
>  void xe_guc_submit_reset_wait(struct xe_guc *guc);
>  void xe_guc_submit_stop(struct xe_guc *guc);
>  int xe_guc_submit_start(struct xe_guc *guc);
> -void xe_guc_submit_pause(struct xe_guc *guc);
> -void xe_guc_submit_unpause(struct xe_guc *guc);
> -void xe_guc_submit_unpause_prepare(struct xe_guc *guc);
>  void xe_guc_submit_pause_abort(struct xe_guc *guc);
> +void xe_guc_submit_vf_pause(struct xe_guc *guc);
> +void xe_guc_submit_vf_unpause(struct xe_guc *guc);
> +void xe_guc_submit_vf_unpause_prepare(struct xe_guc *guc);
>  void xe_guc_submit_wedge(struct xe_guc *guc);
>  
>  int xe_guc_read_stopped(struct xe_guc *guc);
> -- 
> 2.34.1
>