Re: [PATCH v6 2/4] drm/xe/guc_submit: Bring back pause/unpause() helpers

[Matthew Brost <matthew.brost@intel.com>]

On Wed, Oct 22, 2025 at 03:12:44PM +0530, Raag Jadav wrote:
> In preparation of non-VF usecases which require stopping/starting
> submission on GuC, bring back original pause/unpause() helpers.
> 
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>

I'd reword the commit message to explain what the new functions do,
why they are needed, rather than referring to previously changed code.

Patch itself LGTM.

Matt

> ---
>  drivers/gpu/drm/xe/xe_guc_submit.c | 30 ++++++++++++++++++++++++++++++
>  drivers/gpu/drm/xe/xe_guc_submit.h |  2 ++
>  2 files changed, 32 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index 8fbb6b27095d..62771d5c1d91 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -2161,6 +2161,21 @@ static void guc_exec_queue_pause(struct xe_guc *guc, struct xe_exec_queue *q)
>  	}
>  }
>  
> +/**
> + * xe_guc_submit_pause - Stop further runs of submission tasks on given GuC.
> + * @guc: the &xe_guc struct instance whose scheduler is to be disabled
> + */
> +void xe_guc_submit_pause(struct xe_guc *guc)
> +{
> +	struct xe_exec_queue *q;
> +	unsigned long index;
> +
> +	mutex_lock(&guc->submission_state.lock);
> +	xa_for_each(&guc->submission_state.exec_queue_lookup, index, q)
> +		xe_sched_submission_stop(&q->guc->sched);
> +	mutex_unlock(&guc->submission_state.lock);
> +}
> +
>  /**
>   * xe_guc_submit_vf_pause - Stop further runs of submission tasks for VF.
>   * @guc: the &xe_guc struct instance whose scheduler is to be disabled
> @@ -2333,6 +2348,21 @@ static void guc_exec_queue_unpause(struct xe_guc *guc, struct xe_exec_queue *q)
>  	xe_sched_submission_resume_tdr(sched);
>  }
>  
> +/**
> + * xe_guc_submit_unpause - Allow further runs of submission tasks on given GuC.
> + * @guc: the &xe_guc struct instance whose scheduler is to be enabled
> + */
> +void xe_guc_submit_unpause(struct xe_guc *guc)
> +{
> +	struct xe_exec_queue *q;
> +	unsigned long index;
> +
> +	mutex_lock(&guc->submission_state.lock);
> +	xa_for_each(&guc->submission_state.exec_queue_lookup, index, q)
> +		xe_sched_submission_start(&q->guc->sched);
> +	mutex_unlock(&guc->submission_state.lock);
> +}
> +
>  /**
>   * xe_guc_submit_vf_unpause - Allow further runs of submission tasks for VF.
>   * @guc: the &xe_guc struct instance whose scheduler is to be enabled
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.h b/drivers/gpu/drm/xe/xe_guc_submit.h
> index cb5cc2cc9497..8057a4b71ff3 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.h
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.h
> @@ -20,7 +20,9 @@ int xe_guc_submit_reset_prepare(struct xe_guc *guc);
>  void xe_guc_submit_reset_wait(struct xe_guc *guc);
>  void xe_guc_submit_stop(struct xe_guc *guc);
>  int xe_guc_submit_start(struct xe_guc *guc);
> +void xe_guc_submit_pause(struct xe_guc *guc);
>  void xe_guc_submit_pause_abort(struct xe_guc *guc);
> +void xe_guc_submit_unpause(struct xe_guc *guc);
>  void xe_guc_submit_vf_pause(struct xe_guc *guc);
>  void xe_guc_submit_vf_unpause(struct xe_guc *guc);
>  void xe_guc_submit_vf_unpause_prepare(struct xe_guc *guc);
> -- 
> 2.34.1
>