Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Sousa <gustavo.sousa@intel.com>
To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: gustavo.sousa@intel.com
Subject: [CI 13/17] drm/i915/xe3p_lpd: Reload DMC MMIO for pipes C and D
Date: Wed,  5 Nov 2025 11:07:02 -0300	[thread overview]
Message-ID: <20251105140651.71713-32-gustavo.sousa@intel.com> (raw)
In-Reply-To: <20251105140651.71713-19-gustavo.sousa@intel.com>

Xe3p_LPD has the same behavior as for Xe3_LPD with respect to DMC
context data for pipes C and D, which are lost when their power wells
are disabled.  As such, let's extend the condition for Xe3_LPD in
need_pipedmc_load_mmio() to also catch Xe3p_LPD.

Bspec: 68851
Reviewed-by: Matt Atwood <matthew.s.atwood@intel.com>
Link: https://patch.msgid.link/20251103-xe3p_lpd-basic-enabling-v3-13-00e87b510ae7@intel.com
Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dmc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
index 1b3a9b5608c0..ca70cc4932df 100644
--- a/drivers/gpu/drm/i915/display/intel_dmc.c
+++ b/drivers/gpu/drm/i915/display/intel_dmc.c
@@ -718,11 +718,11 @@ static bool need_pipedmc_load_program(struct intel_display *display)
 static bool need_pipedmc_load_mmio(struct intel_display *display, enum pipe pipe)
 {
 	/*
-	 * PTL:
+	 * Xe3_LPD/Xe3p_LPD:
 	 * - pipe A/B DMC doesn't need save/restore
 	 * - pipe C/D DMC is in PG0, needs manual save/restore
 	 */
-	if (DISPLAY_VER(display) == 30)
+	if (IS_DISPLAY_VER(display, 30, 35))
 		return pipe >= PIPE_C;
 
 	/*
-- 
2.51.0


  parent reply	other threads:[~2025-11-05 14:08 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-05 14:06 [CI 00/17] Reviewed patches from: [PATCH v3 00/29] drm/i915/display: Add initial support for Xe3p_LPD Gustavo Sousa
2025-11-05 14:06 ` [CI 01/17] drm/i915/xe3p_lpd: Add Xe3p_LPD display IP features Gustavo Sousa
2025-11-05 14:06 ` [CI 02/17] drm/i915/xe3p_lpd: Drop north display reset option programming Gustavo Sousa
2025-11-05 14:06 ` [CI 03/17] drm/i915/display: Use braces for if-ladder in intel_bw_init_hw() Gustavo Sousa
2025-11-05 14:06 ` [CI 04/17] drm/i915/xe3p_lpd: Update bandwidth parameters Gustavo Sousa
2025-11-05 14:06 ` [CI 05/17] drm/i915/xe3p_lpd: Expand bifield masks dbuf blocks fields Gustavo Sousa
2025-11-05 14:06 ` [CI 06/17] drm/i915/xe3p_lpd: Horizontal flip support for linear surfaces Gustavo Sousa
2025-11-05 14:06 ` [CI 07/17] drm/i915/xe3p_lpd: Remove gamma,csc bottom color checks Gustavo Sousa
2025-11-05 14:06 ` [CI 08/17] drm/i915/xe3p_lpd: Add CDCLK table Gustavo Sousa
2025-11-05 14:06 ` [CI 09/17] drm/i915/xe3p_lpd: Load DMC firmware Gustavo Sousa
2025-11-05 14:06 ` [CI 10/17] drm/i915/xe3p_lpd: Drop support for interlace mode Gustavo Sousa
2025-11-05 14:07 ` [CI 11/17] drm/i915/xe3p_lpd: Extend Wa_16025573575 Gustavo Sousa
2025-11-05 14:07 ` [CI 12/17] drm/i915/xe3p_lpd: Don't allow odd ypan or ysize with semiplanar format Gustavo Sousa
2025-11-05 14:07 ` Gustavo Sousa [this message]
2025-11-05 14:07 ` [CI 14/17] drm/i915/wm: don't use method1 in Xe3p_LPD onwards Gustavo Sousa
2025-11-05 14:07 ` [CI 15/17] drm/i915/dram: Add field ecc_impacting_de_bw Gustavo Sousa
2025-11-05 14:07 ` [CI 16/17] drm/i915/xe3p_lpd: Always apply WaWmMemoryReadLatency Gustavo Sousa
2025-11-05 14:07 ` [CI 17/17] drm/i915/xe3p_lpd: Adapt to updates on MBUS_CTL/DBUF_CTL registers Gustavo Sousa
2025-11-05 14:58 ` ✗ CI.checkpatch: warning for Reviewed patches from: [PATCH v3 00/29] drm/i915/display: Add initial support for Xe3p_LPD Patchwork
2025-11-05 15:00 ` ✓ CI.KUnit: success " Patchwork
2025-11-05 15:15 ` ✗ CI.checksparse: warning " Patchwork
2025-11-05 15:45 ` ✓ Xe.CI.BAT: success " Patchwork
2025-11-05 22:42 ` ✗ Xe.CI.Full: failure " Patchwork
2025-11-06 21:13   ` Gustavo Sousa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251105140651.71713-32-gustavo.sousa@intel.com \
    --to=gustavo.sousa@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox