Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Sousa <gustavo.sousa@intel.com>
To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: gustavo.sousa@intel.com
Subject: [CI 16/17] drm/i915/xe3p_lpd: Always apply WaWmMemoryReadLatency
Date: Wed,  5 Nov 2025 11:07:05 -0300	[thread overview]
Message-ID: <20251105140651.71713-35-gustavo.sousa@intel.com> (raw)
In-Reply-To: <20251105140651.71713-19-gustavo.sousa@intel.com>

When reading memory latencies for watermark calculations, previous
display releases instructed to apply an adjustment of adding a certain
value (e.g. 6us) to all levels when the level 0's memory latency read
from hardware was zero.

For Xe3p_LPD, the instruction is to always use 6us for level 0 and to
add that value to the other levels.  Add the necessary code in
sanitize_wm_latency() so that WaWmMemoryReadLatency is always applied
for Xe3p_LPD and beyond.

v2:
  - Rebased after addition of prep patch "drm/i915/wm: Reorder
    adjust_wm_latency() for Xe3_LPD" (dropped in v3).
v3:
  - Back to the simpler approach of doing the 'wm[0] = 0' step without
    modifying the rest of the code, and that inside
    sanitize_wm_latency(). (Matt Roper, Ville)

Bspec: 68986, 69126
Cc: Matt Atwood <matthew.s.atwood@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://patch.msgid.link/20251103-xe3p_lpd-basic-enabling-v3-20-00e87b510ae7@intel.com
Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
---
 drivers/gpu/drm/i915/display/skl_watermark.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c b/drivers/gpu/drm/i915/display/skl_watermark.c
index c888b0896d89..95941e878bf1 100644
--- a/drivers/gpu/drm/i915/display/skl_watermark.c
+++ b/drivers/gpu/drm/i915/display/skl_watermark.c
@@ -3184,6 +3184,13 @@ static void sanitize_wm_latency(struct intel_display *display)
 	u16 *wm = display->wm.skl_latency;
 	int level, num_levels = display->wm.num_levels;
 
+	/*
+	 * Xe3p and beyond should ignore level 0's reported latency and
+	 * always apply WaWmMemoryReadLatency logic.
+	 */
+	if (DISPLAY_VER(display) >= 35)
+		wm[0] = 0;
+
 	/*
 	 * If a level n (n > 1) has a 0us latency, all levels m (m >= n)
 	 * need to be disabled. We make sure to sanitize the values out
-- 
2.51.0


  parent reply	other threads:[~2025-11-05 14:08 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-05 14:06 [CI 00/17] Reviewed patches from: [PATCH v3 00/29] drm/i915/display: Add initial support for Xe3p_LPD Gustavo Sousa
2025-11-05 14:06 ` [CI 01/17] drm/i915/xe3p_lpd: Add Xe3p_LPD display IP features Gustavo Sousa
2025-11-05 14:06 ` [CI 02/17] drm/i915/xe3p_lpd: Drop north display reset option programming Gustavo Sousa
2025-11-05 14:06 ` [CI 03/17] drm/i915/display: Use braces for if-ladder in intel_bw_init_hw() Gustavo Sousa
2025-11-05 14:06 ` [CI 04/17] drm/i915/xe3p_lpd: Update bandwidth parameters Gustavo Sousa
2025-11-05 14:06 ` [CI 05/17] drm/i915/xe3p_lpd: Expand bifield masks dbuf blocks fields Gustavo Sousa
2025-11-05 14:06 ` [CI 06/17] drm/i915/xe3p_lpd: Horizontal flip support for linear surfaces Gustavo Sousa
2025-11-05 14:06 ` [CI 07/17] drm/i915/xe3p_lpd: Remove gamma,csc bottom color checks Gustavo Sousa
2025-11-05 14:06 ` [CI 08/17] drm/i915/xe3p_lpd: Add CDCLK table Gustavo Sousa
2025-11-05 14:06 ` [CI 09/17] drm/i915/xe3p_lpd: Load DMC firmware Gustavo Sousa
2025-11-05 14:06 ` [CI 10/17] drm/i915/xe3p_lpd: Drop support for interlace mode Gustavo Sousa
2025-11-05 14:07 ` [CI 11/17] drm/i915/xe3p_lpd: Extend Wa_16025573575 Gustavo Sousa
2025-11-05 14:07 ` [CI 12/17] drm/i915/xe3p_lpd: Don't allow odd ypan or ysize with semiplanar format Gustavo Sousa
2025-11-05 14:07 ` [CI 13/17] drm/i915/xe3p_lpd: Reload DMC MMIO for pipes C and D Gustavo Sousa
2025-11-05 14:07 ` [CI 14/17] drm/i915/wm: don't use method1 in Xe3p_LPD onwards Gustavo Sousa
2025-11-05 14:07 ` [CI 15/17] drm/i915/dram: Add field ecc_impacting_de_bw Gustavo Sousa
2025-11-05 14:07 ` Gustavo Sousa [this message]
2025-11-05 14:07 ` [CI 17/17] drm/i915/xe3p_lpd: Adapt to updates on MBUS_CTL/DBUF_CTL registers Gustavo Sousa
2025-11-05 14:58 ` ✗ CI.checkpatch: warning for Reviewed patches from: [PATCH v3 00/29] drm/i915/display: Add initial support for Xe3p_LPD Patchwork
2025-11-05 15:00 ` ✓ CI.KUnit: success " Patchwork
2025-11-05 15:15 ` ✗ CI.checksparse: warning " Patchwork
2025-11-05 15:45 ` ✓ Xe.CI.BAT: success " Patchwork
2025-11-05 22:42 ` ✗ Xe.CI.Full: failure " Patchwork
2025-11-06 21:13   ` Gustavo Sousa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251105140651.71713-35-gustavo.sousa@intel.com \
    --to=gustavo.sousa@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox