Re: [v7 05/15] drm/i915/color: Add framework to program CSC

[kernel test robot <lkp@intel.com>]

Hi Uma,

kernel test robot noticed the following build errors:

[auto build test ERROR on next-20251201]
[cannot apply to drm-xe/drm-xe-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip v6.18 v6.18-rc7 v6.18-rc6 linus/master v6.18]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Uma-Shankar/drm-i915-display-Add-identifiers-for-driver-specific-blocks/20251201-150245
base:   next-20251201
patch link:    https://lore.kernel.org/r/20251201064655.3579280-6-uma.shankar%40intel.com
patch subject: [v7 05/15] drm/i915/color: Add framework to program CSC
config: x86_64-randconfig-012-20251201 (https://download.01.org/0day-ci/archive/20251201/202512012301.V42g2qYb-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251201/202512012301.V42g2qYb-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512012301.V42g2qYb-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from drivers/gpu/drm/i915/display/intel_colorop.h:9,
                    from drivers/gpu/drm/i915/display/intel_plane.c:52:
   drivers/gpu/drm/i915/display/intel_display_types.h:1993:28: error: field 'base' has incomplete type
    1993 |         struct drm_colorop base;
         |                            ^~~~
   drivers/gpu/drm/i915/display/intel_plane.c: In function 'intel_plane_color_copy_uapi_to_hw_state':
   drivers/gpu/drm/i915/display/intel_plane.c:367:41: error: 'struct drm_plane_state' has no member named 'color_pipeline'
     367 |         iter_colorop = plane_state->uapi.color_pipeline;
         |                                         ^
   drivers/gpu/drm/i915/display/intel_plane.c:370:17: error: implicit declaration of function 'for_each_new_colorop_in_state'; did you mean 'for_each_new_crtc_in_state'? [-Wimplicit-function-declaration]
     370 |                 for_each_new_colorop_in_state(state, colorop, new_colorop_state, i) {
         |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                 for_each_new_crtc_in_state
   drivers/gpu/drm/i915/display/intel_plane.c:370:84: error: expected ';' before '{' token
     370 |                 for_each_new_colorop_in_state(state, colorop, new_colorop_state, i) {
         |                                                                                    ^~
         |                                                                                    ;
>> drivers/gpu/drm/i915/display/intel_plane.c:360:35: error: unused variable 'blob' [-Werror=unused-variable]
     360 |         struct drm_property_blob *blob;
         |                                   ^~~~
>> drivers/gpu/drm/i915/display/intel_plane.c:359:31: error: unused variable 'intel_colorop' [-Werror=unused-variable]
     359 |         struct intel_colorop *intel_colorop;
         |                               ^~~~~~~~~~~~~
   drivers/gpu/drm/i915/display/intel_plane.c: At top level:
>> drivers/gpu/drm/i915/display/intel_plane.c:341:1: error: 'intel_plane_colorop_replace_blob' defined but not used [-Werror=unused-function]
     341 | intel_plane_colorop_replace_blob(struct intel_plane_state *plane_state,
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors


vim +/blob +360 drivers/gpu/drm/i915/display/intel_plane.c

   339	
   340	static bool
 > 341	intel_plane_colorop_replace_blob(struct intel_plane_state *plane_state,
   342					 struct intel_colorop *intel_colorop,
   343					 struct drm_property_blob *blob)
   344	{
   345		if (intel_colorop->id == INTEL_PLANE_CB_CSC)
   346			return drm_property_replace_blob(&plane_state->hw.ctm, blob);
   347	
   348		return false;
   349	}
   350	
   351	static void
   352	intel_plane_color_copy_uapi_to_hw_state(struct intel_plane_state *plane_state,
   353						const struct intel_plane_state *from_plane_state,
   354						struct intel_crtc *crtc)
   355	{
   356		struct drm_colorop *iter_colorop, *colorop;
   357		struct drm_colorop_state *new_colorop_state;
   358		struct drm_atomic_state *state = plane_state->uapi.state;
 > 359		struct intel_colorop *intel_colorop;
 > 360		struct drm_property_blob *blob;
   361		int i = 0;
   362		struct intel_atomic_state *intel_atomic_state = to_intel_atomic_state(state);
   363		struct intel_crtc_state *new_crtc_state = intel_atomic_state ?
   364			intel_atomic_get_new_crtc_state(intel_atomic_state, crtc) : NULL;
   365		bool changed = false;
   366	
   367		iter_colorop = plane_state->uapi.color_pipeline;
   368	
   369		while (iter_colorop) {
 > 370			for_each_new_colorop_in_state(state, colorop, new_colorop_state, i) {
   371				if (new_colorop_state->colorop == iter_colorop) {
   372					blob = new_colorop_state->bypass ? NULL : new_colorop_state->data;
   373					intel_colorop = to_intel_colorop(colorop);
   374					changed |= intel_plane_colorop_replace_blob(plane_state,
   375										    intel_colorop,
   376										    blob);
   377				}
   378			}
   379			iter_colorop = iter_colorop->next;
   380		}
   381	
   382		if (new_crtc_state && changed)
   383			new_crtc_state->plane_color_changed = true;
   384	}
   385	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki