Re: [v7 15/15] drm/i915/color: Enable Plane Color Pipelines

[kernel test robot <lkp@intel.com>]

Hi Uma,

kernel test robot noticed the following build errors:

[auto build test ERROR on next-20251201]
[cannot apply to drm-xe/drm-xe-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip v6.18 v6.18-rc7 v6.18-rc6 linus/master v6.18]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Uma-Shankar/drm-i915-display-Add-identifiers-for-driver-specific-blocks/20251201-150245
base:   next-20251201
patch link:    https://lore.kernel.org/r/20251201064655.3579280-16-uma.shankar%40intel.com
patch subject: [v7 15/15] drm/i915/color: Enable Plane Color Pipelines
config: i386-buildonly-randconfig-006-20251201 (https://download.01.org/0day-ci/archive/20251202/202512020555.0E687sGd-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251202/202512020555.0E687sGd-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512020555.0E687sGd-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from drivers/gpu/drm/i915/display/skl_universal_plane.c:19:
   drivers/gpu/drm/i915/display/intel_display_types.h:1993:28: error: field 'base' has incomplete type
    1993 |         struct drm_colorop base;
         |                            ^~~~
   drivers/gpu/drm/i915/display/skl_universal_plane.c: In function 'glk_plane_color_ctl':
>> drivers/gpu/drm/i915/display/skl_universal_plane.c:1288:21: error: implicit declaration of function 'drm_color_lut32_size'; did you mean 'drm_color_lut_size'? [-Wimplicit-function-declaration]
    1288 |                 if (drm_color_lut32_size(plane_state->hw.gamma_lut) != 32)
         |                     ^~~~~~~~~~~~~~~~~~~~
         |                     drm_color_lut_size


vim +1288 drivers/gpu/drm/i915/display/skl_universal_plane.c

  1245	
  1246	static u32 glk_plane_color_ctl(const struct intel_plane_state *plane_state)
  1247	{
  1248		struct intel_display *display = to_intel_display(plane_state);
  1249		const struct drm_framebuffer *fb = plane_state->hw.fb;
  1250		struct intel_plane *plane = to_intel_plane(plane_state->uapi.plane);
  1251		u32 plane_color_ctl = 0;
  1252	
  1253		plane_color_ctl |= PLANE_COLOR_PLANE_GAMMA_DISABLE;
  1254		plane_color_ctl |= glk_plane_color_ctl_alpha(plane_state);
  1255	
  1256		if (fb->format->is_yuv && !icl_is_hdr_plane(display, plane->id)) {
  1257			switch (plane_state->hw.color_encoding) {
  1258			case DRM_COLOR_YCBCR_BT709:
  1259				plane_color_ctl |= PLANE_COLOR_CSC_MODE_YUV709_TO_RGB709;
  1260				break;
  1261			case DRM_COLOR_YCBCR_BT2020:
  1262				plane_color_ctl |=
  1263					PLANE_COLOR_CSC_MODE_YUV2020_TO_RGB2020;
  1264				break;
  1265			default:
  1266				plane_color_ctl |=
  1267					PLANE_COLOR_CSC_MODE_YUV601_TO_RGB601;
  1268			}
  1269			if (plane_state->hw.color_range == DRM_COLOR_YCBCR_FULL_RANGE)
  1270				plane_color_ctl |= PLANE_COLOR_YUV_RANGE_CORRECTION_DISABLE;
  1271		} else if (fb->format->is_yuv) {
  1272			plane_color_ctl |= PLANE_COLOR_INPUT_CSC_ENABLE;
  1273			if (plane_state->hw.color_range == DRM_COLOR_YCBCR_FULL_RANGE)
  1274				plane_color_ctl |= PLANE_COLOR_YUV_RANGE_CORRECTION_DISABLE;
  1275		}
  1276	
  1277		if (plane_state->force_black)
  1278			plane_color_ctl |= PLANE_COLOR_PLANE_CSC_ENABLE;
  1279	
  1280		if (plane_state->hw.degamma_lut)
  1281			plane_color_ctl |= PLANE_COLOR_PRE_CSC_GAMMA_ENABLE;
  1282	
  1283		if (plane_state->hw.ctm)
  1284			plane_color_ctl |= PLANE_COLOR_PLANE_CSC_ENABLE;
  1285	
  1286		if (plane_state->hw.gamma_lut) {
  1287			plane_color_ctl &= ~PLANE_COLOR_PLANE_GAMMA_DISABLE;
> 1288			if (drm_color_lut32_size(plane_state->hw.gamma_lut) != 32)
  1289				plane_color_ctl |= PLANE_COLOR_POST_CSC_GAMMA_MULTSEG_ENABLE;
  1290		}
  1291	
  1292		return plane_color_ctl;
  1293	}
  1294	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki